Replace occurrences of humanId with the full Id

Sascha created 4 years ago

Unless an ID must be shorted for user convenience, the full id should be used
to prevent collisions.

Change summary

webui/src/components/Author.tsx                    |  2 +-
webui/src/components/BugTitleForm/BugTitleForm.tsx |  2 +-
webui/src/components/Identity/CurrentIdentity.tsx  |  2 +-
webui/src/graphql/fragments.graphql                |  1 +
webui/src/pages/identity/BugList.tsx               |  6 +++---
webui/src/pages/identity/Identity.tsx              | 12 ++++++------
webui/src/pages/list/BugRow.tsx                    |  2 +-
webui/src/pages/new/NewBug.graphql                 |  4 ++--
webui/src/pages/new/NewBugPage.tsx                 |  2 +-
9 files changed, 17 insertions(+), 16 deletions(-)

Detailed changes

webui/src/components/Author.tsx

@@ -15,7 +15,7 @@ type Props = AuthoredFragment & {
 const Author = ({ author, ...props }: Props) => {
   return (
     <Tooltip title={`Goto the ${author.displayName}'s profile.`}>
-      <Link {...props} component={RouterLink} to={`/user/${author.humanId}`}>
+      <Link {...props} component={RouterLink} to={`/user/${author.id}`}>
         {author.displayName}
       </Link>
     </Tooltip>

webui/src/components/BugTitleForm/BugTitleForm.tsx

@@ -90,7 +90,7 @@ function BugTitleForm({ bug }: Props) {
     setTitle({
       variables: {
         input: {
-          prefix: bug.humanId,
+          prefix: bug.id,
           title: issueTitleInput.value,
         },
       },

webui/src/components/Identity/CurrentIdentity.tsx

@@ -96,7 +96,7 @@ const CurrentIdentity = () => {
                       color="inherit"
                       className={classes.profileLink}
                       component={RouterLink}
-                      to={`/user/${user.humanId}`}
+                      to={`/user/${user.id}`}
                     >
                       Open profile
                     </Link>

webui/src/graphql/fragments.graphql

@@ -16,5 +16,6 @@ fragment authored on Authored {
     displayName
     avatarUrl
     humanId
+    id
   }
 }

webui/src/pages/identity/BugList.tsx

@@ -24,14 +24,14 @@ const useStyles = makeStyles((theme) => ({
 }));
 
 type Props = {
-  humanId: string;
+  id: string;
 };
 
-function BugList({ humanId }: Props) {
+function BugList({ id }: Props) {
   const classes = useStyles();
   const { loading, error, data } = useGetBugsByUserQuery({
     variables: {
-      query: 'author:' + humanId + ' sort:creation',
+      query: 'author:' + id + ' sort:creation',
     },
   });
 

webui/src/pages/identity/Identity.tsx

@@ -51,9 +51,9 @@ const Identity = ({ identity }: Props) => {
 
   const { loading, error, data } = useGetUserStatisticQuery({
     variables: {
-      authorQuery: 'author:' + user?.humanId,
-      participantQuery: 'participant:' + user?.humanId,
-      actionQuery: 'actor:' + user?.humanId,
+      authorQuery: 'author:' + user?.id,
+      participantQuery: 'participant:' + user?.id,
+      actionQuery: 'actor:' + user?.id,
     },
   });
 
@@ -111,7 +111,7 @@ const Identity = ({ identity }: Props) => {
               <h1 className={classes.header}>Statistics</h1>
               <Link
                 component={RouterLink}
-                to={`/?q=author%3A${user?.humanId}+sort%3Acreation`}
+                to={`/?q=author%3A${user?.id}+sort%3Acreation`}
                 color={'inherit'}
               >
                 <Typography variant="subtitle1">
@@ -120,7 +120,7 @@ const Identity = ({ identity }: Props) => {
               </Link>
               <Link
                 component={RouterLink}
-                to={`/?q=participant%3A${user?.humanId}+sort%3Acreation`}
+                to={`/?q=participant%3A${user?.id}+sort%3Acreation`}
                 color={'inherit'}
               >
                 <Typography variant="subtitle1">
@@ -129,7 +129,7 @@ const Identity = ({ identity }: Props) => {
               </Link>
               <Link
                 component={RouterLink}
-                to={`/?q=actor%3A${user?.humanId}+sort%3Acreation`}
+                to={`/?q=actor%3A${user?.id}+sort%3Acreation`}
                 color={'inherit'}
               >
                 <Typography variant="subtitle1">

webui/src/pages/list/BugRow.tsx

@@ -106,7 +106,7 @@ function BugRow({ bug }: Props) {
       <TableCell className={classes.cell}>
         <BugStatus status={bug.status} className={classes.status} />
         <div className={classes.expand}>
-          <Link to={'bug/' + bug.humanId}>
+          <Link to={'bug/' + bug.id}>
             <div className={classes.bugTitleWrapper}>
               <span className={classes.title}>{bug.title}</span>
               {bug.labels.length > 0 &&

webui/src/pages/new/NewBug.graphql

@@ -1,7 +1,7 @@
 mutation newBug($input: NewBugInput!) {
   newBug(input: $input) {
     bug {
-      humanId
+      id
     }
   }
-}
+}

webui/src/pages/new/NewBugPage.tsx

@@ -62,7 +62,7 @@ function NewBugPage() {
         },
       },
     }).then(function (data) {
-      const id = data.data?.newBug.bug.humanId;
+      const id = data.data?.newBug.bug.id;
       history.push('/bug/' + id);
     });
     issueTitleInput.value = '';