From 7a511f9a13f3d1064fd11c9146e6b21cb961a8b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michael=20Mur=C3=A9?= <batolettre@gmail.com>
Date: Wed, 17 Oct 2018 20:38:10 +0200
Subject: [PATCH] commands: don't load the repo for commands that don't need it

fix #67
---
 commands/add.go              | 7 ++++---
 commands/bridge.go           | 9 +++++----
 commands/bridge_configure.go | 7 ++++---
 commands/bridge_pull.go      | 7 ++++---
 commands/bridge_rm.go        | 9 +++++----
 commands/comment.go          | 7 ++++---
 commands/comment_add.go      | 7 ++++---
 commands/deselect.go         | 3 ++-
 commands/label.go            | 7 ++++---
 commands/label_add.go        | 7 ++++---
 commands/label_rm.go         | 7 ++++---
 commands/ls-labels.go        | 3 ++-
 commands/ls.go               | 3 ++-
 commands/pull.go             | 7 ++++---
 commands/push.go             | 7 ++++---
 commands/root.go             | 4 ----
 commands/select.go           | 3 ++-
 commands/show.go             | 7 ++++---
 commands/status.go           | 7 ++++---
 commands/status_close.go     | 7 ++++---
 commands/status_open.go      | 7 ++++---
 commands/termui.go           | 7 ++++---
 commands/title.go            | 7 ++++---
 commands/title_edit.go       | 7 ++++---
 commands/webui.go            | 7 ++++---
 25 files changed, 90 insertions(+), 70 deletions(-)

diff --git a/commands/add.go b/commands/add.go
index 944f0a99a29c9a3df15bfbe3a96e1daf5f36c55d..081c99f13b4aa1fc2c1f3c647fb2ec70eb956bf7 100644
--- a/commands/add.go
+++ b/commands/add.go
@@ -53,9 +53,10 @@ func runAddBug(cmd *cobra.Command, args []string) error {
 }
 
 var addCmd = &cobra.Command{
-	Use:   "add",
-	Short: "Create a new bug",
-	RunE:  runAddBug,
+	Use:     "add",
+	Short:   "Create a new bug",
+	PreRunE: loadRepo,
+	RunE:    runAddBug,
 }
 
 func init() {
diff --git a/commands/bridge.go b/commands/bridge.go
index 5dc4e744db0da452d124962685eece47e81100c4..4576cd0aac1c5537157300aeeab7e4e97e9d007d 100644
--- a/commands/bridge.go
+++ b/commands/bridge.go
@@ -28,10 +28,11 @@ func runBridge(cmd *cobra.Command, args []string) error {
 }
 
 var bridgeCmd = &cobra.Command{
-	Use:   "bridge",
-	Short: "Configure and use bridges to other bug trackers",
-	RunE:  runBridge,
-	Args:  cobra.NoArgs,
+	Use:     "bridge",
+	Short:   "Configure and use bridges to other bug trackers",
+	PreRunE: loadRepo,
+	RunE:    runBridge,
+	Args:    cobra.NoArgs,
 }
 
 func init() {
diff --git a/commands/bridge_configure.go b/commands/bridge_configure.go
index 4329b54cfe5f991fc9bd659581c09585e1a7f3a0..ed18cae9df2f9707a1f74282f0a1ee2cebfb56a9 100644
--- a/commands/bridge_configure.go
+++ b/commands/bridge_configure.go
@@ -88,9 +88,10 @@ func promptName() (string, error) {
 }
 
 var bridgeConfigureCmd = &cobra.Command{
-	Use:   "configure",
-	Short: "Configure a new bridge",
-	RunE:  runBridgeConfigure,
+	Use:     "configure",
+	Short:   "Configure a new bridge",
+	PreRunE: loadRepo,
+	RunE:    runBridgeConfigure,
 }
 
 func init() {
diff --git a/commands/bridge_pull.go b/commands/bridge_pull.go
index 521f2d9c2616ab2961a952daaea7d77bef11c850..a90a533f03b088f52694829664e71527ea692d55 100644
--- a/commands/bridge_pull.go
+++ b/commands/bridge_pull.go
@@ -35,9 +35,10 @@ func runBridgePull(cmd *cobra.Command, args []string) error {
 }
 
 var bridgePullCmd = &cobra.Command{
-	Use:   "pull [<name>]",
-	Short: "Pull updates",
-	RunE:  runBridgePull,
+	Use:     "pull [<name>]",
+	Short:   "Pull updates",
+	PreRunE: loadRepo,
+	RunE:    runBridgePull,
 }
 
 func init() {
diff --git a/commands/bridge_rm.go b/commands/bridge_rm.go
index acde9da54339ff7cf8a8d97100e889e60f921db8..2ebc17a7a47fce533a3db6f0940173ef3d1112b0 100644
--- a/commands/bridge_rm.go
+++ b/commands/bridge_rm.go
@@ -22,10 +22,11 @@ func runBridgeRm(cmd *cobra.Command, args []string) error {
 }
 
 var bridgeRmCmd = &cobra.Command{
-	Use:   "rm name <name>",
-	Short: "Delete a configured bridge",
-	RunE:  runBridgeRm,
-	Args:  cobra.ExactArgs(1),
+	Use:     "rm name <name>",
+	Short:   "Delete a configured bridge",
+	PreRunE: loadRepo,
+	RunE:    runBridgeRm,
+	Args:    cobra.ExactArgs(1),
 }
 
 func init() {
diff --git a/commands/comment.go b/commands/comment.go
index c05fd25526442653943328950111a3e9bb6e22dd..fc4b6a6b24d566db65ce874aedcea2f2d69a57c2 100644
--- a/commands/comment.go
+++ b/commands/comment.go
@@ -43,9 +43,10 @@ func commentsTextOutput(comments []bug.Comment) {
 }
 
 var commentCmd = &cobra.Command{
-	Use:   "comment [<id>]",
-	Short: "Display or add comments",
-	RunE:  runComment,
+	Use:     "comment [<id>]",
+	Short:   "Display or add comments",
+	PreRunE: loadRepo,
+	RunE:    runComment,
 }
 
 func init() {
diff --git a/commands/comment_add.go b/commands/comment_add.go
index 8736f9c27fa92ffcb6428691ed23bc00263f69fa..6ee3fc15068c9e09ddd1b62ddc4271eda5e9f62b 100644
--- a/commands/comment_add.go
+++ b/commands/comment_add.go
@@ -53,9 +53,10 @@ func runCommentAdd(cmd *cobra.Command, args []string) error {
 }
 
 var commentAddCmd = &cobra.Command{
-	Use:   "add [<id>]",
-	Short: "Add a new comment",
-	RunE:  runCommentAdd,
+	Use:     "add [<id>]",
+	Short:   "Add a new comment",
+	PreRunE: loadRepo,
+	RunE:    runCommentAdd,
 }
 
 func init() {
diff --git a/commands/deselect.go b/commands/deselect.go
index f2907c70512f0920e5445becc67b35a9654e31e5..a2e8d30d65057c6605c1478fcbcf74e555f5b829 100644
--- a/commands/deselect.go
+++ b/commands/deselect.go
@@ -29,7 +29,8 @@ git bug comment
 git bug status
 git bug deselect
 `,
-	RunE: runDeselect,
+	PreRunE: loadRepo,
+	RunE:    runDeselect,
 }
 
 func init() {
diff --git a/commands/label.go b/commands/label.go
index fd958d688d394fca84c50127e25b410ed6d39e04..0221701ca2ac62a0531d2a250b9943c0967b7851 100644
--- a/commands/label.go
+++ b/commands/label.go
@@ -30,9 +30,10 @@ func runLabel(cmd *cobra.Command, args []string) error {
 }
 
 var labelCmd = &cobra.Command{
-	Use:   "label [<id>]",
-	Short: "Display, add or remove labels",
-	RunE:  runLabel,
+	Use:     "label [<id>]",
+	Short:   "Display, add or remove labels",
+	PreRunE: loadRepo,
+	RunE:    runLabel,
 }
 
 func init() {
diff --git a/commands/label_add.go b/commands/label_add.go
index 06c4e6c5429f8ceb46b537c6be7d2cca11a6efd2..278d64721e977f2611af828d7ce7e1d56d1248de 100644
--- a/commands/label_add.go
+++ b/commands/label_add.go
@@ -34,9 +34,10 @@ func runLabelAdd(cmd *cobra.Command, args []string) error {
 }
 
 var labelAddCmd = &cobra.Command{
-	Use:   "add [<id>] <label>[...]",
-	Short: "Add a label",
-	RunE:  runLabelAdd,
+	Use:     "add [<id>] <label>[...]",
+	Short:   "Add a label",
+	PreRunE: loadRepo,
+	RunE:    runLabelAdd,
 }
 
 func init() {
diff --git a/commands/label_rm.go b/commands/label_rm.go
index 5e9c8f24c8cfb26b2dbe4575c8e564db33aa5362..e53ac09a0997bfffb0a3fc37ad7d49a9f06fb459 100644
--- a/commands/label_rm.go
+++ b/commands/label_rm.go
@@ -34,9 +34,10 @@ func runLabelRm(cmd *cobra.Command, args []string) error {
 }
 
 var labelRmCmd = &cobra.Command{
-	Use:   "rm [<id>] <label>[...]",
-	Short: "Remove a label",
-	RunE:  runLabelRm,
+	Use:     "rm [<id>] <label>[...]",
+	Short:   "Remove a label",
+	PreRunE: loadRepo,
+	RunE:    runLabelRm,
 }
 
 func init() {
diff --git a/commands/ls-labels.go b/commands/ls-labels.go
index 49f4c7cb643fc2a4a0d319fb17461a1413cdbb72..9dd94f081d6b6f09bc3c79183fb45092733609b5 100644
--- a/commands/ls-labels.go
+++ b/commands/ls-labels.go
@@ -29,7 +29,8 @@ var lsLabelCmd = &cobra.Command{
 	Long: `List valid labels.
 
 Note: in the future, a proper label policy could be implemented where valid labels are defined in a configuration file. Until that, the default behavior is to return the list of labels already used.`,
-	RunE: runLsLabel,
+	PreRunE: loadRepo,
+	RunE:    runLsLabel,
 }
 
 func init() {
diff --git a/commands/ls.go b/commands/ls.go
index 1fababaad1dd13ba85eaa01d52f07e03a96f60c2..1a759a264769f959860ebc7e72afdc467f7b42b0 100644
--- a/commands/ls.go
+++ b/commands/ls.go
@@ -139,7 +139,8 @@ git bug ls status:open sort:edit-desc
 List closed bugs sorted by creation with flags:
 git bug ls --status closed --by creation
 `,
-	RunE: runLsBug,
+	PreRunE: loadRepo,
+	RunE:    runLsBug,
 }
 
 func init() {
diff --git a/commands/pull.go b/commands/pull.go
index 73a27d3d92553b99615e5ac6ab1ad9d18861733e..27c0953ba79ef8f8555495903a3483d4e04867ab 100644
--- a/commands/pull.go
+++ b/commands/pull.go
@@ -51,9 +51,10 @@ func runPull(cmd *cobra.Command, args []string) error {
 
 // showCmd defines the "push" subcommand.
 var pullCmd = &cobra.Command{
-	Use:   "pull [<remote>]",
-	Short: "Pull bugs update from a git remote",
-	RunE:  runPull,
+	Use:     "pull [<remote>]",
+	Short:   "Pull bugs update from a git remote",
+	PreRunE: loadRepo,
+	RunE:    runPull,
 }
 
 func init() {
diff --git a/commands/push.go b/commands/push.go
index 06a4044b4c0e80d7a55aa15b2c5656ec9ddeed87..11282ada4c42e5b6da4389daf90113c8fc1ed87d 100644
--- a/commands/push.go
+++ b/commands/push.go
@@ -36,9 +36,10 @@ func runPush(cmd *cobra.Command, args []string) error {
 
 // showCmd defines the "push" subcommand.
 var pushCmd = &cobra.Command{
-	Use:   "push [<remote>]",
-	Short: "Push bugs update to a git remote",
-	RunE:  runPush,
+	Use:     "push [<remote>]",
+	Short:   "Push bugs update to a git remote",
+	PreRunE: loadRepo,
+	RunE:    runPush,
 }
 
 func init() {
diff --git a/commands/root.go b/commands/root.go
index d7e7216d27b49696639a5e64b8d592e468d593ee..27268bf4deaa6e0023df66fb05e611f5d840db8d 100644
--- a/commands/root.go
+++ b/commands/root.go
@@ -38,10 +38,6 @@ the same git remote your are already using to collaborate with other peoples.
 		}
 	},
 
-	// Load the repo before any command execution
-	// Note, this concern only commands that actually have a Run function
-	PersistentPreRunE: loadRepo,
-
 	DisableAutoGenTag: true,
 
 	// Custom bash code to connect the git completion for "git bug" to the
diff --git a/commands/select.go b/commands/select.go
index b917d31d7550cdececd57be773b7db7959d8dcbe..0c50d1a6bd73676df18f0d2bbc27e41b7bc9b631 100644
--- a/commands/select.go
+++ b/commands/select.go
@@ -44,7 +44,8 @@ var selectCmd = &cobra.Command{
 git bug comment
 git bug status
 `,
-	RunE: runSelect,
+	PreRunE: loadRepo,
+	RunE:    runSelect,
 }
 
 func init() {
diff --git a/commands/show.go b/commands/show.go
index c061b69bc4defe853849e2f68e3ad586d2281675..c41af02daa2252796fe9fc1f236cf55286f0176a 100644
--- a/commands/show.go
+++ b/commands/show.go
@@ -73,9 +73,10 @@ func runShowBug(cmd *cobra.Command, args []string) error {
 }
 
 var showCmd = &cobra.Command{
-	Use:   "show [<id>]",
-	Short: "Display the details of a bug",
-	RunE:  runShowBug,
+	Use:     "show [<id>]",
+	Short:   "Display the details of a bug",
+	PreRunE: loadRepo,
+	RunE:    runShowBug,
 }
 
 func init() {
diff --git a/commands/status.go b/commands/status.go
index a34b091859a4962e7249b4daf337e1a8196bfa28..6aed000a6fe42724734d6ec58b0d5864ffd727a7 100644
--- a/commands/status.go
+++ b/commands/status.go
@@ -28,9 +28,10 @@ func runStatus(cmd *cobra.Command, args []string) error {
 }
 
 var statusCmd = &cobra.Command{
-	Use:   "status [<id>]",
-	Short: "Display or change a bug status",
-	RunE:  runStatus,
+	Use:     "status [<id>]",
+	Short:   "Display or change a bug status",
+	PreRunE: loadRepo,
+	RunE:    runStatus,
 }
 
 func init() {
diff --git a/commands/status_close.go b/commands/status_close.go
index fd713a39fcbd834461c018c6f19b7818b716de3f..ec4e503eff736ce444b65a524b4262daa45755a2 100644
--- a/commands/status_close.go
+++ b/commands/status_close.go
@@ -27,9 +27,10 @@ func runStatusClose(cmd *cobra.Command, args []string) error {
 }
 
 var closeCmd = &cobra.Command{
-	Use:   "close [<id>]",
-	Short: "Mark a bug as closed",
-	RunE:  runStatusClose,
+	Use:     "close [<id>]",
+	Short:   "Mark a bug as closed",
+	PreRunE: loadRepo,
+	RunE:    runStatusClose,
 }
 
 func init() {
diff --git a/commands/status_open.go b/commands/status_open.go
index 9c6363a071ff4c4bb2f6014077646b6012bc0b3c..c8717cd2f90f7dae2812ec01628e92f9f6d70fae 100644
--- a/commands/status_open.go
+++ b/commands/status_open.go
@@ -27,9 +27,10 @@ func runStatusOpen(cmd *cobra.Command, args []string) error {
 }
 
 var openCmd = &cobra.Command{
-	Use:   "open [<id>]",
-	Short: "Mark a bug as open",
-	RunE:  runStatusOpen,
+	Use:     "open [<id>]",
+	Short:   "Mark a bug as open",
+	PreRunE: loadRepo,
+	RunE:    runStatusOpen,
 }
 
 func init() {
diff --git a/commands/termui.go b/commands/termui.go
index 5d600710b47ff8353e9439237d1247953a9a5954..8df5ba7c0bb9bcc37bbaff147a145db57b5bdf5f 100644
--- a/commands/termui.go
+++ b/commands/termui.go
@@ -17,9 +17,10 @@ func runTermUI(cmd *cobra.Command, args []string) error {
 }
 
 var termUICmd = &cobra.Command{
-	Use:   "termui",
-	Short: "Launch the terminal UI",
-	RunE:  runTermUI,
+	Use:     "termui",
+	Short:   "Launch the terminal UI",
+	PreRunE: loadRepo,
+	RunE:    runTermUI,
 }
 
 func init() {
diff --git a/commands/title.go b/commands/title.go
index f930ffb1144da8d9913236a6462312fa0aa489d7..5d7237551d62486e123911ace45757d6bef73fb1 100644
--- a/commands/title.go
+++ b/commands/title.go
@@ -28,9 +28,10 @@ func runTitle(cmd *cobra.Command, args []string) error {
 }
 
 var titleCmd = &cobra.Command{
-	Use:   "title [<id>]",
-	Short: "Display or change a title",
-	RunE:  runTitle,
+	Use:     "title [<id>]",
+	Short:   "Display or change a title",
+	PreRunE: loadRepo,
+	RunE:    runTitle,
 }
 
 func init() {
diff --git a/commands/title_edit.go b/commands/title_edit.go
index 2d824383ce402896a0e5c3acfa7f7b4ea18eaba9..f3b93bb1d635b67e4c15f950ee070dfeb98ee55f 100644
--- a/commands/title_edit.go
+++ b/commands/title_edit.go
@@ -51,9 +51,10 @@ func runTitleEdit(cmd *cobra.Command, args []string) error {
 }
 
 var titleEditCmd = &cobra.Command{
-	Use:   "edit [<id>]",
-	Short: "Edit a title",
-	RunE:  runTitleEdit,
+	Use:     "edit [<id>]",
+	Short:   "Edit a title",
+	PreRunE: loadRepo,
+	RunE:    runTitleEdit,
 }
 
 func init() {
diff --git a/commands/webui.go b/commands/webui.go
index b1bccd5cdfdfc0c8dabae41ae58620e9344759d6..e2a3265c35acec4d55786fa7a56e9f2d13f91df8 100644
--- a/commands/webui.go
+++ b/commands/webui.go
@@ -223,9 +223,10 @@ func (gufh *gitUploadFileHandler) ServeHTTP(rw http.ResponseWriter, r *http.Requ
 }
 
 var webUICmd = &cobra.Command{
-	Use:   "webui",
-	Short: "Launch the web UI",
-	RunE:  runWebUI,
+	Use:     "webui",
+	Short:   "Launch the web UI",
+	PreRunE: loadRepo,
+	RunE:    runWebUI,
 }
 
 func init() {