From 7b0af1129e11c60d6f07199e8dcfa09adb000d2e Mon Sep 17 00:00:00 2001
From: Quentin Gliech <quentingliech@gmail.com>
Date: Sun, 29 Mar 2026 19:08:03 +0200
Subject: [PATCH] fix(web): resolve all oxlint errors

- add `void` to unhandled promises (no-floating-promises)
- wrap async handlers passed to React event props (no-misused-promises)
- stabilize allLabels/allAuthors/allIdentities with useMemo to avoid
  new array references on every render (exhaustive-deps)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 webui2/src/components/bugs/CommentBox.tsx   | 12 ++++++++++--
 webui2/src/components/bugs/IssueFilters.tsx | 18 +++++++++++++-----
 webui2/src/components/bugs/LabelEditor.tsx  |  4 +++-
 webui2/src/components/bugs/QueryInput.tsx   |  7 +++++--
 webui2/src/components/bugs/Timeline.tsx     |  2 +-
 webui2/src/components/bugs/TitleEditor.tsx  | 10 ++++++++--
 webui2/src/components/code/CommitList.tsx   |  2 +-
 webui2/src/components/code/FileDiffView.tsx |  2 +-
 webui2/src/components/code/FileViewer.tsx   |  4 ++--
 webui2/src/components/layout/Header.tsx     |  2 +-
 webui2/src/lib/auth.tsx                     |  2 +-
 webui2/src/pages/IdentitySelectPage.tsx     | 18 +++++++++++++++---
 webui2/src/pages/NewBugPage.tsx             |  7 ++++++-
 13 files changed, 67 insertions(+), 23 deletions(-)

diff --git a/webui2/src/components/bugs/CommentBox.tsx b/webui2/src/components/bugs/CommentBox.tsx
index 8edf8a67c3c115da2800f2c3cc6bcdbc8dc039d2..d33ce023286182ba6f24168ee23bd9f6fcb01a51 100644
--- a/webui2/src/components/bugs/CommentBox.tsx
+++ b/webui2/src/components/bugs/CommentBox.tsx
@@ -124,13 +124,21 @@ export function CommentBox({ bugPrefix, bugStatus, ref_ }: CommentBoxProps) {
           <Button
             variant="outline"
             size="sm"
-            onClick={handleToggleStatus}
+            onClick={() => {
+              void handleToggleStatus();
+            }}
             disabled={busy}
             className="min-w-[7.5rem]"
           >
             {isOpen ? "Close issue" : "Reopen issue"}
           </Button>
-          <Button size="sm" onClick={handleComment} disabled={!hasMessage || busy}>
+          <Button
+            size="sm"
+            onClick={() => {
+              void handleComment();
+            }}
+            disabled={!hasMessage || busy}
+          >
             Comment
           </Button>
         </div>
diff --git a/webui2/src/components/bugs/IssueFilters.tsx b/webui2/src/components/bugs/IssueFilters.tsx
index c90fa87dd3c82f6f48be49cafe2903f0599225f2..de5c6fece870d01d7b621b2dd5ecd1b2279e5149 100644
--- a/webui2/src/components/bugs/IssueFilters.tsx
+++ b/webui2/src/components/bugs/IssueFilters.tsx
@@ -1,5 +1,5 @@
 import { ArrowUpDown, ChevronDown, Tag, User, X, Search, Check } from "lucide-react";
-import { useState } from "react";
+import { useMemo, useState } from "react";
 
 import { useValidLabelsQuery, useAllIdentitiesQuery } from "@/__generated__/graphql";
 import { Avatar, AvatarFallback, AvatarImage } from "@/components/ui/avatar";
@@ -79,12 +79,20 @@ export function IssueFilters({
   const [labelSearch, setLabelSearch] = useState("");
   const [authorSearch, setAuthorSearch] = useState("");
 
-  const validLabels = [...(labelsData?.repository?.validLabels.nodes ?? [])].sort((a, b) =>
-    a.name.localeCompare(b.name),
+  const validLabels = useMemo(
+    () =>
+      [...(labelsData?.repository?.validLabels.nodes ?? [])].sort((a, b) =>
+        a.name.localeCompare(b.name),
+      ),
+    [labelsData],
   );
 
-  const allIdentities = [...(authorsData?.repository?.allIdentities.nodes ?? [])].sort((a, b) =>
-    a.displayName.localeCompare(b.displayName),
+  const allIdentities = useMemo(
+    () =>
+      [...(authorsData?.repository?.allIdentities.nodes ?? [])].sort((a, b) =>
+        a.displayName.localeCompare(b.displayName),
+      ),
+    [authorsData],
   );
 
   const filteredLabels = labelSearch.trim()
diff --git a/webui2/src/components/bugs/LabelEditor.tsx b/webui2/src/components/bugs/LabelEditor.tsx
index 479cef6f6f2df3f2f702c3657565d18c7d23720b..cd92551b31702e486e40748ed53372d4b3929a53 100644
--- a/webui2/src/components/bugs/LabelEditor.tsx
+++ b/webui2/src/components/bugs/LabelEditor.tsx
@@ -64,7 +64,9 @@ export function LabelEditor({ bugPrefix, currentLabels, ref_ }: LabelEditorProps
                   return (
                     <button
                       key={label.name}
-                      onClick={() => toggleLabel(label.name)}
+                      onClick={() => {
+                        void toggleLabel(label.name);
+                      }}
                       className="flex w-full items-center gap-2 rounded px-2 py-1.5 text-sm hover:bg-muted"
                     >
                       <span
diff --git a/webui2/src/components/bugs/QueryInput.tsx b/webui2/src/components/bugs/QueryInput.tsx
index 33124c134be9a0fd1dfacc377db61f9497209a1d..7533e383af3189dcb390cbc9a2f1865a4e15e64f 100644
--- a/webui2/src/components/bugs/QueryInput.tsx
+++ b/webui2/src/components/bugs/QueryInput.tsx
@@ -169,8 +169,11 @@ export function QueryInput({ value, onChange, onSubmit, placeholder, className }
   const { data: labelsData } = useValidLabelsQuery({ variables: { ref: repo } });
   const { data: authorsData } = useAllIdentitiesQuery({ variables: { ref: repo } });
 
-  const allLabels = labelsData?.repository?.validLabels.nodes ?? [];
-  const allAuthors = authorsData?.repository?.allIdentities.nodes ?? [];
+  const allLabels = useMemo(() => labelsData?.repository?.validLabels.nodes ?? [], [labelsData]);
+  const allAuthors = useMemo(
+    () => authorsData?.repository?.allIdentities.nodes ?? [],
+    [authorsData],
+  );
 
   // Compute the filtered suggestion list whenever completion info changes.
   const suggestions = useMemo(() => {
diff --git a/webui2/src/components/bugs/Timeline.tsx b/webui2/src/components/bugs/Timeline.tsx
index f4a3776fd40549529da8b4992ebe208e657994c5..6cff6a89ce8090d9c19b0d64a874b11b0c4ae5b8 100644
--- a/webui2/src/components/bugs/Timeline.tsx
+++ b/webui2/src/components/bugs/Timeline.tsx
@@ -74,7 +74,7 @@ function CommentItem({ item, bugPrefix }: { item: CommentItem; bugPrefix: string
       setEditing(false);
       return;
     }
-    editComment({
+    void editComment({
       variables: { input: { targetPrefix: item.id, message: editValue } },
     }).then(() => setEditing(false));
   }
diff --git a/webui2/src/components/bugs/TitleEditor.tsx b/webui2/src/components/bugs/TitleEditor.tsx
index dfe7036567cb592b98d53ae33da421ee22625eb6..94b32c67ae5b01119b77c69d38d033dc3dc86a4a 100644
--- a/webui2/src/components/bugs/TitleEditor.tsx
+++ b/webui2/src/components/bugs/TitleEditor.tsx
@@ -44,7 +44,7 @@ export function TitleEditor({ bugPrefix, title, humanId, ref_ }: TitleEditorProp
   }
 
   function handleKeyDown(e: React.KeyboardEvent) {
-    if (e.key === "Enter") handleSave();
+    if (e.key === "Enter") void handleSave();
     if (e.key === "Escape") {
       setValue(title);
       setEditing(false);
@@ -62,7 +62,13 @@ export function TitleEditor({ bugPrefix, title, humanId, ref_ }: TitleEditorProp
           className="text-xl font-semibold"
           disabled={loading}
         />
-        <Button size="sm" onClick={handleSave} disabled={loading || !value.trim()}>
+        <Button
+          size="sm"
+          onClick={() => {
+            void handleSave();
+          }}
+          disabled={loading || !value.trim()}
+        >
           Save
         </Button>
         <Button
diff --git a/webui2/src/components/code/CommitList.tsx b/webui2/src/components/code/CommitList.tsx
index a1ec4696e15de5f635992731dd4915c4c751d61f..916bd841e50da4e203405217cb181adcc2a67acc 100644
--- a/webui2/src/components/code/CommitList.tsx
+++ b/webui2/src/components/code/CommitList.tsx
@@ -67,7 +67,7 @@ export function CommitList({ ref_, path }: CommitListProps) {
   function loadMore() {
     if (!cursor) return;
     setLoadingMore(true);
-    fetchMore({
+    void fetchMore({
       variables: { after: cursor },
     })
       .then((result) => {
diff --git a/webui2/src/components/code/FileDiffView.tsx b/webui2/src/components/code/FileDiffView.tsx
index fb55a105a34ad1e247220461f762c8d2bfda68aa..129af9d61c3a1c657c6d863ab72dc0c0a9139331 100644
--- a/webui2/src/components/code/FileDiffView.tsx
+++ b/webui2/src/components/code/FileDiffView.tsx
@@ -63,7 +63,7 @@ export function FileDiffView({ hash, path, oldPath, status }: FileDiffViewProps)
 
   function toggle() {
     if (!open && !data && !loading) {
-      fetchDiff({ variables: { repo, hash, path } });
+      void fetchDiff({ variables: { repo, hash, path } });
     }
     setOpen((v) => !v);
   }
diff --git a/webui2/src/components/code/FileViewer.tsx b/webui2/src/components/code/FileViewer.tsx
index 1e6d8d1410b530288c4f4115466f5eea2c8c0091..feb48d8b204a28b4d820ad89408fdeeda2fdec6b 100644
--- a/webui2/src/components/code/FileViewer.tsx
+++ b/webui2/src/components/code/FileViewer.tsx
@@ -23,7 +23,7 @@ export function FileViewer({ blob, loading }: FileViewerProps) {
     }
     setHighlighted(null);
     let cancelled = false;
-    import("highlight.js").then(({ default: hljs }) => {
+    void import("highlight.js").then(({ default: hljs }) => {
       if (cancelled) return;
       const ext = blob.path.split(".").pop() ?? "";
       const result = hljs.getLanguage(ext)
@@ -43,7 +43,7 @@ export function FileViewer({ blob, loading }: FileViewerProps) {
   const { html, lineCount } = highlighted;
 
   function copyToClipboard() {
-    if (blob.text) navigator.clipboard.writeText(blob.text);
+    if (blob.text) void navigator.clipboard.writeText(blob.text);
   }
 
   return (
diff --git a/webui2/src/components/layout/Header.tsx b/webui2/src/components/layout/Header.tsx
index 8c2046675f997a73e95ecd3704f0c92c47acddc3..e0de44737547c1cf4ebbba7768c949fbbd53e3a5 100644
--- a/webui2/src/components/layout/Header.tsx
+++ b/webui2/src/components/layout/Header.tsx
@@ -19,7 +19,7 @@ import { cn } from "@/lib/utils";
 // A full reload is the simplest way to reset all Apollo cache + React state.
 function SignOutButton() {
   function handleSignOut() {
-    fetch("/auth/logout", { method: "POST", credentials: "include" }).finally(() =>
+    void fetch("/auth/logout", { method: "POST", credentials: "include" }).finally(() =>
       window.location.assign("/"),
     );
   }
diff --git a/webui2/src/lib/auth.tsx b/webui2/src/lib/auth.tsx
index 6b8d4bc5440d402b0103d25fc9ef1385979c5a0f..e06bfb0319cd34b84b5a2a4864ee25fa80580768 100644
--- a/webui2/src/lib/auth.tsx
+++ b/webui2/src/lib/auth.tsx
@@ -101,7 +101,7 @@ function ExternalAuthProvider({
   const [loading, setLoading] = useState(true);
 
   useEffect(() => {
-    fetch("/auth/user", { credentials: "include" })
+    void fetch("/auth/user", { credentials: "include" })
       .then((res) => {
         if (res.status === 401) return null;
         if (!res.ok) throw new Error(`/auth/user returned ${res.status}`);
diff --git a/webui2/src/pages/IdentitySelectPage.tsx b/webui2/src/pages/IdentitySelectPage.tsx
index 1504efd562e8efd45c9fa773aeba053a315fe959..f101e563034852d7b18acaafaabaff85de903b95 100644
--- a/webui2/src/pages/IdentitySelectPage.tsx
+++ b/webui2/src/pages/IdentitySelectPage.tsx
@@ -27,7 +27,7 @@ export function IdentitySelectPage() {
   const [working, setWorking] = useState(false);
 
   useEffect(() => {
-    fetch("/auth/identities", { credentials: "include" })
+    void fetch("/auth/identities", { credentials: "include" })
       .then((res) => {
         if (!res.ok) throw new Error(`unexpected status ${res.status}`);
         return res.json() as Promise<IdentityItem[]>;
@@ -90,7 +90,13 @@ export function IdentitySelectPage() {
                 {id.repoSlug} · {id.humanId}
               </p>
             </div>
-            <Button size="sm" disabled={working} onClick={() => adopt(id.id)}>
+            <Button
+              size="sm"
+              disabled={working}
+              onClick={() => {
+                void adopt(id.id);
+              }}
+            >
               Adopt
             </Button>
           </div>
@@ -104,7 +110,13 @@ export function IdentitySelectPage() {
               A fresh git-bug identity will be created from your OAuth profile.
             </p>
           </div>
-          <Button size="sm" disabled={working} onClick={() => adopt(null)}>
+          <Button
+            size="sm"
+            disabled={working}
+            onClick={() => {
+              void adopt(null);
+            }}
+          >
             <Plus className="size-4" />
             Create
           </Button>
diff --git a/webui2/src/pages/NewBugPage.tsx b/webui2/src/pages/NewBugPage.tsx
index 19e0ce2f9e38560a631ef1cd5cc1e5455634bc2b..3e880b8c0adaaaf1661437a960d9102475a36c58 100644
--- a/webui2/src/pages/NewBugPage.tsx
+++ b/webui2/src/pages/NewBugPage.tsx
@@ -45,7 +45,12 @@ export function NewBugPage() {
 
       <h1 className="mb-6 text-xl font-semibold">New issue</h1>
 
-      <form onSubmit={handleSubmit} className="space-y-4">
+      <form
+        onSubmit={(e) => {
+          void handleSubmit(e);
+        }}
+        className="space-y-4"
+      >
         <div>
           <label htmlFor="title" className="mb-1.5 block text-sm font-medium">
             Title