Commit for #158

Cláudio created 4 years ago

- Fixing github quality code checking issues

Change summary

webui/src/components/Button/GBButton.css | 19 -------------------
webui/src/components/Button/GBButton.tsx | 22 ----------------------
webui/src/pages/bug/CommentInput.tsx     | 11 +++--------
webui/src/pages/list/ListQuery.tsx       |  2 --
4 files changed, 3 insertions(+), 51 deletions(-)

Detailed changes

webui/src/components/Button/GBButton.css

@@ -1,19 +0,0 @@
-.bt-issue {
-    background-color: #2ea44fd9;
-    border: 1px solid;
-    border-color: #1b1f2326;
-    border-radius: 6px;
-    padding: 6px 12px;
-
-    font-size: 14px;
-    color: #ffffff;
-    line-height: 20px;
-    text-decoration: none;
-
-    transition: all 0.2s cubic-bezier(0.3, 0, 0.5, 1);
-}
-
-.bt-issue:hover {
-    background-color: #2ea44f;
-    border-color: #1b1f2326;
-}

webui/src/components/Button/GBButton.tsx

@@ -1,22 +0,0 @@
-import React from 'react';
-import { Link } from 'react-router-dom';
-
-import './GBButton.css';
-
-interface GBButtonProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {
-  to: string;
-  text: string;
-}
-
-/**
- * Standard button for issue actions
- */
-const GBButton: React.FC<GBButtonProps> = (props) => {
-  return (
-    <Link to={props.to} className="bt-issue">
-      {props.text}
-    </Link>
-  );
-};
-
-export default GBButton;

webui/src/pages/bug/CommentInput.tsx

@@ -1,17 +1,12 @@
-import React, { useState, useRef, useEffect } from 'react';
+import React, { useState, useEffect } from 'react';
 
-import Button from '@material-ui/core/Button';
-import Paper from '@material-ui/core/Paper';
 import Tab from '@material-ui/core/Tab';
 import Tabs from '@material-ui/core/Tabs';
 import TextField from '@material-ui/core/TextField';
-import { makeStyles, Theme } from '@material-ui/core/styles';
+import { makeStyles } from '@material-ui/core/styles';
 
 import Content from 'src/components/Content';
 
-import { useAddCommentMutation } from './CommentForm.generated';
-import { TimelineDocument } from './TimelineQuery.generated';
-
 const useStyles = makeStyles((theme) => ({
   container: {
     margin: theme.spacing(2, 0),
@@ -67,7 +62,7 @@ function CommentInput({ loading, onChange }: Props) {
 
   useEffect(() => {
     onChange(input);
-  }, [input]);
+  }, [input, onChange]);
 
   return (
     <div>

webui/src/pages/list/ListQuery.tsx

@@ -12,8 +12,6 @@ import KeyboardArrowLeft from '@material-ui/icons/KeyboardArrowLeft';
 import KeyboardArrowRight from '@material-ui/icons/KeyboardArrowRight';
 import Skeleton from '@material-ui/lab/Skeleton';
 
-import GBButton from 'src/components/Button/GBButton';
-
 import FilterToolbar from './FilterToolbar';
 import List from './List';
 import { useListBugsQuery } from './ListQuery.generated';