From c0d3b4b032b44d4ceff2f3cabdedd16633f1c315 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Mur=C3=A9?= Date: Tue, 4 Sep 2018 18:18:24 +0200 Subject: [PATCH] cache: fix missed code path that should update the cache fix #36 --- cache/repo_cache.go | 7 +++++++ commands/ls.go | 1 + 2 files changed, 8 insertions(+) diff --git a/cache/repo_cache.go b/cache/repo_cache.go index d5dd4c592786d6a7fab6756dcc3301a888f7f79b..d3d02c45b4ddb834aacf353c934ff5f4e2551cb2 100644 --- a/cache/repo_cache.go +++ b/cache/repo_cache.go @@ -247,6 +247,11 @@ func (c *RepoCache) NewBugWithFiles(title string, message string, files []util.H cached := NewBugCache(c, b) c.bugs[b.Id()] = cached + err = c.bugUpdated(b.Id()) + if err != nil { + return nil, err + } + return cached, nil } @@ -257,11 +262,13 @@ func (c *RepoCache) Fetch(remote string) (string, error) { } func (c *RepoCache) MergeAll(remote string) <-chan bug.MergeResult { + // Todo: update the cache properly return bug.MergeAll(c.repo, remote) } // Pull does a Fetch and merge the updates into the local bug states func (c *RepoCache) Pull(remote string, out io.Writer) error { + // Todo: update the cache properly return bug.Pull(c.repo, out, remote) } diff --git a/commands/ls.go b/commands/ls.go index ea5418c424b12ead8f76fcebf0953c96154c6f23..18496e06229f18247ee7bf6e97bc35fb3366fb2f 100644 --- a/commands/ls.go +++ b/commands/ls.go @@ -14,6 +14,7 @@ func runLsBug(cmd *cobra.Command, args []string) error { if err != nil { return err } + defer backend.Close() allIds := backend.AllBugsId(cache.OrderByCreation, cache.OrderAscending)