Remove pointer and unnecessary code

vince created 5 years ago

Change summary

cache/bug_cache.go       |  2 +-
cache/repo_cache_test.go | 18 ------------------
2 files changed, 1 insertion(+), 19 deletions(-)

Detailed changes

cache/bug_cache.go

@@ -19,7 +19,7 @@ var ErrNoMatchingOp = fmt.Errorf("no matching operation found")
 // 3. Deal with concurrency.
 type BugCache struct {
 	repoCache *RepoCache
-	mu        *sync.RWMutex
+	mu        sync.RWMutex
 	bug       *bug.WithSnapshot
 }
 

cache/repo_cache_test.go

@@ -210,21 +210,3 @@ func TestRemove(t *testing.T) {
 	_, err = repoCache.ResolveBug(b1.Id())
 	assert.Error(t, bug.ErrBugNotExist, err)
 }
-
-//func TestConcurrency(t *testing.T) {
-//	repo := repository.CreateTestRepo(false)
-//	defer repository.CleanupTestRepos(repo)
-//
-//	cache, err := NewRepoCache(repo)
-//	require.NoError(t, err)
-//
-//	iden1, err := cache.NewIdentity("René Descartes", "[e-mail]")
-//	require.NoError(t, err)
-//	err = cache.SetUserIdentity(iden1)
-//	require.NoError(t, err)
-//
-//	bug1, _, err := cache.NewBug("title", "message")
-//	require.NoError(t, err)
-//
-//	bug1.mu.Lock()
-//}