Refactor webui changes.

Luke Granger-Brown created 5 years ago

Don't use contexts, just raw Apollo, since it's cached anyway.

Change "ReadonlyHidden" to "IfLoggedIn".

Change summary

webui/src/layout/CurrentIdentity.tsx        | 30 ++++++++--------------
webui/src/layout/CurrentIdentityContext.tsx |  6 ----
webui/src/layout/IfLoggedIn.tsx             | 14 ++++++++++
webui/src/layout/ReadonlyHidden.tsx         | 19 --------------
webui/src/layout/index.tsx                  |  6 +---
webui/src/pages/bug/Bug.tsx                 |  6 ++--
webui/src/pages/bug/CommentForm.graphql     |  4 --
7 files changed, 31 insertions(+), 54 deletions(-)

Detailed changes

webui/src/layout/CurrentIdentity.tsx

@@ -3,7 +3,7 @@ import React from 'react';
 import Avatar from '@material-ui/core/Avatar';
 import { makeStyles } from '@material-ui/core/styles';
 
-import CurrentIdentityContext from './CurrentIdentityContext';
+import { useCurrentIdentityQuery } from './CurrentIdentity.generated';
 
 const useStyles = makeStyles(theme => ({
   displayName: {
@@ -13,26 +13,18 @@ const useStyles = makeStyles(theme => ({
 
 const CurrentIdentity = () => {
   const classes = useStyles();
+  const { loading, error, data } = useCurrentIdentityQuery();
 
-  return (
-    <CurrentIdentityContext.Consumer>
-      {context => {
-        if (!context) return null;
-        const { loading, error, data } = context as any;
-
-        if (error || loading || !data?.repository?.userIdentity) return null;
+  if (error || loading || !data?.repository?.userIdentity) return null;
 
-        const user = data.repository.userIdentity;
-        return (
-          <>
-            <Avatar src={user.avatarUrl ? user.avatarUrl : undefined}>
-              {user.displayName.charAt(0).toUpperCase()}
-            </Avatar>
-            <div className={classes.displayName}>{user.displayName}</div>
-          </>
-        );
-      }}
-    </CurrentIdentityContext.Consumer>
+  const user = data.repository.userIdentity;
+  return (
+    <>
+      <Avatar src={user.avatarUrl ? user.avatarUrl : undefined}>
+        {user.displayName.charAt(0).toUpperCase()}
+      </Avatar>
+      <div className={classes.displayName}>{user.displayName}</div>
+    </>
   );
 };
 

webui/src/layout/CurrentIdentityContext.tsx

@@ -1,6 +0,0 @@
-import React from 'react';
-
-import { CurrentIdentityQueryResult } from './CurrentIdentity.generated';
-
-const Context = React.createContext(null as CurrentIdentityQueryResult | null);
-export default Context;

webui/src/layout/IfLoggedIn.tsx

@@ -0,0 +1,14 @@
+import React from 'react';
+
+import { useCurrentIdentityQuery } from './CurrentIdentity.generated';
+
+type Props = { children: React.ReactNode };
+const IfLoggedIn = ({ children }: Props) => {
+  const { loading, error, data } = useCurrentIdentityQuery();
+
+  if (error || loading || !data?.repository?.userIdentity) return null;
+
+  return <>{children}</>;
+};
+
+export default IfLoggedIn;

webui/src/layout/ReadonlyHidden.tsx

@@ -1,19 +0,0 @@
-import React from 'react';
-
-import CurrentIdentityContext from './CurrentIdentityContext';
-
-type Props = { children: React.ReactNode };
-const ReadonlyHidden = ({ children }: Props) => (
-  <CurrentIdentityContext.Consumer>
-    {context => {
-      if (!context) return null;
-      const { loading, error, data } = context;
-
-      if (error || loading || !data?.repository?.userIdentity) return null;
-
-      return <>{children}</>;
-    }}
-  </CurrentIdentityContext.Consumer>
-);
-
-export default ReadonlyHidden;

webui/src/layout/index.tsx

@@ -2,18 +2,16 @@ import React from 'react';
 
 import CssBaseline from '@material-ui/core/CssBaseline';
 
-import { useCurrentIdentityQuery } from './CurrentIdentity.generated';
-import CurrentIdentityContext from './CurrentIdentityContext';
 import Header from './Header';
 
 type Props = { children: React.ReactNode };
 function Layout({ children }: Props) {
   return (
-    <CurrentIdentityContext.Provider value={useCurrentIdentityQuery()}>
+    <>
       <CssBaseline />
       <Header />
       {children}
-    </CurrentIdentityContext.Provider>
+    </>
   );
 }
 

webui/src/pages/bug/Bug.tsx

@@ -6,7 +6,7 @@ import { makeStyles } from '@material-ui/core/styles';
 import Author from 'src/components/Author';
 import Date from 'src/components/Date';
 import Label from 'src/components/Label';
-import ReadonlyHidden from 'src/layout/ReadonlyHidden';
+import IfLoggedIn from 'src/layout/IfLoggedIn';
 
 import { BugFragment } from './Bug.generated';
 import CommentForm from './CommentForm';
@@ -89,11 +89,11 @@ function Bug({ bug }: Props) {
       <div className={classes.container}>
         <div className={classes.timeline}>
           <TimelineQuery id={bug.id} />
-          <ReadonlyHidden>
+          <IfLoggedIn>
             <div className={classes.commentForm}>
               <CommentForm bugId={bug.id} />
             </div>
-          </ReadonlyHidden>
+          </IfLoggedIn>
         </div>
         <div className={classes.sidebar}>
           <span className={classes.sidebarTitle}>Labels</span>

webui/src/pages/bug/CommentForm.graphql

@@ -1,7 +1,5 @@
 mutation AddComment($input: AddCommentInput!) {
   addComment(input: $input) {
-    operation {
-      id
-    }
+    operation { id }
   }
 }