From d853a6fbc996762ab264452150558bb92bdbd6fc Mon Sep 17 00:00:00 2001 From: Steve Moyer Date: Wed, 15 Jun 2022 10:23:33 -0400 Subject: [PATCH] test(778): simplify and guarantee backend cleanup --- commands/env_testing.go | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/commands/env_testing.go b/commands/env_testing.go index 092ff23317e27094bcce7c039b711e09b04ac2f6..4de66a9db3757d72d541b87d3ff40c493dc5c662 100644 --- a/commands/env_testing.go +++ b/commands/env_testing.go @@ -8,7 +8,6 @@ import ( "github.com/MichaelMure/git-bug/cache" "github.com/MichaelMure/git-bug/repository" - "github.com/MichaelMure/git-bug/util/interrupt" ) type testEnv struct { @@ -32,8 +31,11 @@ func newTestEnv(t *testing.T) *testEnv { backend, err := cache.NewRepoCache(repo) require.NoError(t, err) + t.Cleanup(func() { + backend.Close() + }) - testEnv := &testEnv{ + return &testEnv{ env: &Env{ repo: repo, backend: backend, @@ -43,20 +45,4 @@ func newTestEnv(t *testing.T) *testEnv { cwd: cwd, out: buf, } - - cleaner := func(env *Env) interrupt.CleanerFunc { - return func() error { - if env.backend != nil { - err := env.backend.Close() - env.backend = nil - return err - } - return nil - } - } - - // Cleanup properly on interrupt - interrupt.RegisterCleaner(cleaner(testEnv.env)) - - return testEnv }