Commits in Ia1ad61e54e305bb073efc6853738d3eed81d576c

Commit log

`c2d7b12` Merge pull request #811 from MichaelMure/fix-data-race

Click to expand commit body

graphql: fix two invalid mutex lock leading to data races

Michael Muré created 3 years ago

`7348fb9` github: fix data race when closing event channel

Click to expand commit body

I believe the issue was twofold:

When done importing, the calling context is likely still valid, so if the output channel is not read enough and reach capacity, some event producer down the line can be blocked trying to send in that channel. When closing it, this send is still trying to proceed, which is illegal in go.

In rateLimitHandlerClient, there was a need to 2 different type of output channel: core.ExportResult and ImportEvent. To do so, the previous code was using a single channel type RateLimitingEvent and a series of goroutines to read/cast/send to the final channel. This could result in more async goroutine being stuck trying to send in an at-capacity channel. Instead, the code now use a simple synchronous callback to directly push to the final output channel. No concurrency needed anymore and the code is simpler.

Any of those fixes could have resolved the data race, but both fixes is more correct.

Michael Muré created 3 years ago

`fe23123` graphql: fix two invalid mutex lock leading to data races

Michael Muré created 3 years ago

`eda312f` fix(778): remove extra mutex lock when resolving bug prefix

Steve Moyer created 3 years ago

`295da9c` cache: ensure that the default repo has a non-empty name to make js/apollo happy

Michael Muré created 3 years ago

`96327c3` Merge pull request #806 from MichaelMure/docs

Click to expand commit body

doc: more discoverable docs

Michael Muré created 3 years ago

`1c219f6` doc: more discoverable docs

Michael Muré created 3 years ago

`d94df63` Merge pull request #805 from MichaelMure/completion-cleanup

Click to expand commit body

misc: move all completions in a dedicated folder

Michael Muré created 3 years ago

`c732a18` misc: move all completions in a dedicated folder

Michael Muré created 3 years ago

`ccc342e` refactor: simplify creation of temp dir - after 1.15

Steve Moyer created 3 years ago

`da9f95e` fix: remove only t.Parallel()

Steve Moyer created 3 years ago

`50de030` gogit: close index before deleting it on disk

Michael Muré created 3 years ago

`86dd450` test: clean up temp dir and repo correctly

Steve Moyer created 3 years ago

`90208b5` test(778): execute rm bug in testEnv (hangs)

Steve Moyer created 3 years ago

`ecfffe3` test(778): execute add user in testEnv and return userID

Steve Moyer created 3 years ago

`508d0eb` test(778): clear output after user creation

Steve Moyer created 3 years ago

`50324b8` test(778): verify user create results in an identity and cache

Steve Moyer created 3 years ago

`5962ed8` test(778): verify root command returns main help text

Steve Moyer created 3 years ago

`523a148` test(778): allow alternate CWD via context

Steve Moyer created 3 years ago

`1659fed` test(778): capture stderr and stdout during tests

Steve Moyer created 3 years ago

`8821b67` test: add verification that localStorage.Root() resolves to the correct absolute filepath

Steve Moyer created 3 years ago

`e120fdb` refactor: use namespace instead of application of applicationName

Steve Moyer created 3 years ago

`e29f58b` chore: clean-up commented code

Steve Moyer created 3 years ago

`b42fae3` feat: make local storage configurable

Steve Moyer created 3 years ago

`f20db72` build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0

Click to expand commit body

Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.64.0 to 0.68.0.
- [Release notes](https://github.com/xanzy/go-gitlab/releases)
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.64.0...v0.68.0)

---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

dependabot[bot] created 3 years ago

`650c11d` Merge pull request #788 from hoijui/model_touchup

Click to expand commit body

Model touchup

Michael Muré created 4 years ago

`bd75082` Merge pull request #768 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.1

Click to expand commit body

build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1

Michael Muré created 4 years ago

`66c4da3` Merge pull request #783 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.64.0

Click to expand commit body

build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0

Michael Muré created 4 years ago

`75ca2ce` model: Multiple, minor readability and language improvements

Robin Vobruba created 4 years ago

`9b871c6` model: Removes now outdated statement about ops and root

Robin Vobruba created 4 years ago

`00fb4bc` model: Highlight some words with special meaning

Robin Vobruba created 4 years ago

`e652eb6` model: Links to a section further down

Robin Vobruba created 4 years ago

`2a0331e` model: Moves example description after the example

Robin Vobruba created 4 years ago

`543e7b7` model: Adds link explaining nounce (wikipedia)

Robin Vobruba created 4 years ago

`33c6702` model: strict Markdown requires empty lines before (and after) lists

Robin Vobruba created 4 years ago

`547d626` Merge pull request #531 from krobelus/complete-bug-ids

Click to expand commit body

Complete bug IDs where appropriate

Michael Muré created 4 years ago

`3d534a7` completion: lots of small ironing

Michael Muré created 4 years ago

`b9991d8` ls: fix incorrect query parsing with quotes escaped by the shell

Michael Muré created 4 years ago

`edc8b75` misc: fix bash completion with "git bug"

TsT created 4 years ago

`f25690d` completion: use the correct GenBashCompletionV2 instead of the legacy function

Michael Muré created 4 years ago

`bc6ba02` Add command-specific argument completions

Click to expand commit body

Complete bug IDs, bridges, users, labels where appropriate.

This works in bash and fish. ZSH is not yet supported by Cobra.
In fish, descriptions (the part of a completion after the "\t") are shown
as completion label, and can be searched with Ctrl+S.

Reproduce with

	fish -C 'source misc/fish_completion/git-bug'
	git bug select ^I

(tested with fish version 3.3.1)

Also works with bash, but only for "git-bug" (with the dash)

	bash --rcfile <(echo source misc/bash_completion/git-bug)
	git-bug select ^I

Closes #493

Johannes Altmanninger created 5 years ago

`8ee3335` a few fixes

Michael Muré created 4 years ago

`5354b08` build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0

Click to expand commit body

Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.59.0 to 0.64.0.
- [Release notes](https://github.com/xanzy/go-gitlab/releases)
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.59.0...v0.64.0)

---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

dependabot[bot] created 4 years ago

`a00f1a9` Merge pull request #773 from gaelj/fix-gitlab-pat-format

Click to expand commit body

Allow new gitlab PAT format

Michael Muré created 4 years ago

`b8a799a` Merge pull request #767 from MichaelMure/single-author

Click to expand commit body

bug: don't serialize multiple time the author, only once in OperationPack

Michael Muré created 4 years ago

`09037ba` Allow new gitlab PAT format

Gaël James created 4 years ago

`450d7f7` entity/dag: add an extensive example

Michael Muré created 4 years ago

`d0e65d5` doc: add missing file

Michael Muré created 4 years ago

`14e3d0a` Merge pull request #670 from MichaelMure/update-doc

Click to expand commit body

update doc

Michael Muré created 4 years ago

`c9cec5b` update doc

Michael Muré created 4 years ago

Commit log

c2d7b12 Merge pull request #811 from MichaelMure/fix-data-race

7348fb9 github: fix data race when closing event channel

fe23123 graphql: fix two invalid mutex lock leading to data races

eda312f fix(778): remove extra mutex lock when resolving bug prefix

295da9c cache: ensure that the default repo has a non-empty name to make js/apollo happy

96327c3 Merge pull request #806 from MichaelMure/docs

1c219f6 doc: more discoverable docs

d94df63 Merge pull request #805 from MichaelMure/completion-cleanup

c732a18 misc: move all completions in a dedicated folder

ccc342e refactor: simplify creation of temp dir - after 1.15

da9f95e fix: remove only t.Parallel()

50de030 gogit: close index before deleting it on disk

86dd450 test: clean up temp dir and repo correctly

90208b5 test(778): execute rm bug in testEnv (hangs)

ecfffe3 test(778): execute add user in testEnv and return userID

508d0eb test(778): clear output after user creation

50324b8 test(778): verify user create results in an identity and cache

5962ed8 test(778): verify root command returns main help text

523a148 test(778): allow alternate CWD via context

1659fed test(778): capture stderr and stdout during tests

8821b67 test: add verification that localStorage.Root() resolves to the correct absolute filepath

e120fdb refactor: use namespace instead of application of applicationName

e29f58b chore: clean-up commented code

b42fae3 feat: make local storage configurable

f20db72 build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0

650c11d Merge pull request #788 from hoijui/model_touchup

bd75082 Merge pull request #768 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.1

66c4da3 Merge pull request #783 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.64.0

75ca2ce model: Multiple, minor readability and language improvements

9b871c6 model: Removes now outdated statement about ops and root

00fb4bc model: Highlight some words with special meaning

e652eb6 model: Links to a section further down

2a0331e model: Moves example description after the example

543e7b7 model: Adds link explaining nounce (wikipedia)

33c6702 model: strict Markdown requires empty lines before (and after) lists

547d626 Merge pull request #531 from krobelus/complete-bug-ids

3d534a7 completion: lots of small ironing

b9991d8 ls: fix incorrect query parsing with quotes escaped by the shell

edc8b75 misc: fix bash completion with "git bug"

f25690d completion: use the correct GenBashCompletionV2 instead of the legacy function

bc6ba02 Add command-specific argument completions

8ee3335 a few fixes

5354b08 build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0

a00f1a9 Merge pull request #773 from gaelj/fix-gitlab-pat-format

b8a799a Merge pull request #767 from MichaelMure/single-author

09037ba Allow new gitlab PAT format

450d7f7 entity/dag: add an extensive example

d0e65d5 doc: add missing file

14e3d0a Merge pull request #670 from MichaelMure/update-doc

c9cec5b update doc

`c2d7b12` Merge pull request #811 from MichaelMure/fix-data-race

`7348fb9` github: fix data race when closing event channel

`fe23123` graphql: fix two invalid mutex lock leading to data races

`eda312f` fix(778): remove extra mutex lock when resolving bug prefix

`295da9c` cache: ensure that the default repo has a non-empty name to make js/apollo happy

`96327c3` Merge pull request #806 from MichaelMure/docs

`1c219f6` doc: more discoverable docs

`d94df63` Merge pull request #805 from MichaelMure/completion-cleanup

`c732a18` misc: move all completions in a dedicated folder

`ccc342e` refactor: simplify creation of temp dir - after 1.15

`da9f95e` fix: remove only t.Parallel()

`50de030` gogit: close index before deleting it on disk

`86dd450` test: clean up temp dir and repo correctly

`90208b5` test(778): execute rm bug in testEnv (hangs)

`ecfffe3` test(778): execute add user in testEnv and return userID

`508d0eb` test(778): clear output after user creation

`50324b8` test(778): verify user create results in an identity and cache

`5962ed8` test(778): verify root command returns main help text

`523a148` test(778): allow alternate CWD via context

`1659fed` test(778): capture stderr and stdout during tests

`8821b67` test: add verification that localStorage.Root() resolves to the correct absolute filepath

`e120fdb` refactor: use namespace instead of application of applicationName

`e29f58b` chore: clean-up commented code

`b42fae3` feat: make local storage configurable

`f20db72` build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0

`650c11d` Merge pull request #788 from hoijui/model_touchup

`bd75082` Merge pull request #768 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.1

`66c4da3` Merge pull request #783 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.64.0

`75ca2ce` model: Multiple, minor readability and language improvements

`9b871c6` model: Removes now outdated statement about ops and root

`00fb4bc` model: Highlight some words with special meaning

`e652eb6` model: Links to a section further down

`2a0331e` model: Moves example description after the example

`543e7b7` model: Adds link explaining nounce (wikipedia)

`33c6702` model: strict Markdown requires empty lines before (and after) lists

`547d626` Merge pull request #531 from krobelus/complete-bug-ids

`3d534a7` completion: lots of small ironing

`b9991d8` ls: fix incorrect query parsing with quotes escaped by the shell

`edc8b75` misc: fix bash completion with "git bug"

`f25690d` completion: use the correct GenBashCompletionV2 instead of the legacy function

`bc6ba02` Add command-specific argument completions

`8ee3335` a few fixes

`5354b08` build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0

`a00f1a9` Merge pull request #773 from gaelj/fix-gitlab-pat-format

`b8a799a` Merge pull request #767 from MichaelMure/single-author

`09037ba` Allow new gitlab PAT format

`450d7f7` entity/dag: add an extensive example

`d0e65d5` doc: add missing file

`14e3d0a` Merge pull request #670 from MichaelMure/update-doc

`c9cec5b` update doc