Commit log

1d4667c refactor(809): eliminate need to defer CleanupTestRepos()

Steve Moyer created

f809108 Merge pull request #808 from selesy/fix/778-git-bug-rm-broken

Click to expand commit body 
fix(778): git bug rm broken

Steve Moyer created

d853a6f test(778): simplify and guarantee backend cleanup

Steve Moyer created

0a9aaa9 refactor(778): test only command implementations

Steve Moyer created

b33c1d4 Merge pull request #795 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.68.0

Click to expand commit body 
build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0

Michael Muré created

7e9c1b2 Merge pull request #814 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.2

Click to expand commit body 
build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2

Michael Muré created

941f5b3 chore(808): rearrange imports to git-bug convention

Steve Moyer created

6ec7d67 test(808): document getCWD() and clean-up arguments

Steve Moyer created

f0f5247 test(808): skip root help test that uses a golden file

Steve Moyer created

3b77af7 build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2

Click to expand commit body 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.1...v1.7.2)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

dependabot[bot] created

848f725 fix(808): remove duplication stderr/stdout set-up

Steve Moyer created

54306a8 test(808): make build tag compatible with Go 1.16

Steve Moyer created

99669d7 test(808): do not run golden file tests on Windows

Steve Moyer created

1a504e0 fix(808): simplify handling of Windows line terminations

Steve Moyer created

5982e8f chore(808): merge in LocalStorage namespace configuration

Steve Moyer created

8fc93d8 Merge branch 'master' into fix/778-git-bug-rm-broken

Steve Moyer created

cd1099a fix(808): replace Windows line terminators

Steve Moyer created

dd8134b Merge pull request #803 from MichaelMure/feat/configurable-local-storage

Click to expand commit body 
Feat/configurable local storage

Michael Muré created

ee0bac6 Merge pull request #813 from MichaelMure/fix-data-race2

Click to expand commit body 
Github: fix data race

Michael Muré created

c2d7b12 Merge pull request #811 from MichaelMure/fix-data-race

Click to expand commit body 
graphql: fix two invalid mutex lock leading to data races

Michael Muré created

7348fb9 github: fix data race when closing event channel

Click to expand commit body 
I believe the issue was twofold:

When done importing, the calling context is likely still valid, so if the output channel is not read enough and reach capacity, some event producer down the line can be blocked trying to send in that channel. When closing it, this send is still trying to proceed, which is illegal in go.

In rateLimitHandlerClient, there was a need to 2 different type of output channel: core.ExportResult and ImportEvent. To do so, the previous code was using a single channel type RateLimitingEvent and a series of goroutines to read/cast/send to the final channel. This could result in more async goroutine being stuck trying to send in an at-capacity channel. Instead, the code now use a simple synchronous callback to directly push to the final output channel. No concurrency needed anymore and the code is simpler.

Any of those fixes could have resolved the data race, but both fixes is more correct.

Michael Muré created

fe23123 graphql: fix two invalid mutex lock leading to data races

Michael Muré created

eda312f fix(778): remove extra mutex lock when resolving bug prefix

Steve Moyer created

295da9c cache: ensure that the default repo has a non-empty name to make js/apollo happy

Michael Muré created

96327c3 Merge pull request #806 from MichaelMure/docs

Click to expand commit body 
doc: more discoverable docs

Michael Muré created

1c219f6 doc: more discoverable docs

Michael Muré created

d94df63 Merge pull request #805 from MichaelMure/completion-cleanup

Click to expand commit body 
misc: move all completions in a dedicated folder

Michael Muré created

c732a18 misc: move all completions in a dedicated folder

Michael Muré created

ccc342e refactor: simplify creation of temp dir - after 1.15

Steve Moyer created

da9f95e fix: remove only t.Parallel()

Steve Moyer created

50de030 gogit: close index before deleting it on disk

Michael Muré created

86dd450 test: clean up temp dir and repo correctly

Steve Moyer created

90208b5 test(778): execute rm bug in testEnv (hangs)

Steve Moyer created

ecfffe3 test(778): execute add user in testEnv and return userID

Steve Moyer created

508d0eb test(778): clear output after user creation

Steve Moyer created

50324b8 test(778): verify user create results in an identity and cache

Steve Moyer created

5962ed8 test(778): verify root command returns main help text

Steve Moyer created

523a148 test(778): allow alternate CWD via context

Steve Moyer created

1659fed test(778): capture stderr and stdout during tests

Steve Moyer created

8821b67 test: add verification that localStorage.Root() resolves to the correct absolute filepath

Steve Moyer created

e120fdb refactor: use namespace instead of application of applicationName

Steve Moyer created

e29f58b chore: clean-up commented code

Steve Moyer created

b42fae3 feat: make local storage configurable

Steve Moyer created

f20db72 build(deps): bump github.com/xanzy/go-gitlab from 0.64.0 to 0.68.0

Click to expand commit body 
Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.64.0 to 0.68.0.
- [Release notes](https://github.com/xanzy/go-gitlab/releases)
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.64.0...v0.68.0)

---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

dependabot[bot] created

650c11d Merge pull request #788 from hoijui/model_touchup

Click to expand commit body 
Model touchup

Michael Muré created

bd75082 Merge pull request #768 from MichaelMure/dependabot/go_modules/github.com/stretchr/testify-1.7.1

Click to expand commit body 
build(deps): bump github.com/stretchr/testify from 1.7.0 to 1.7.1

Michael Muré created

66c4da3 Merge pull request #783 from MichaelMure/dependabot/go_modules/github.com/xanzy/go-gitlab-0.64.0

Click to expand commit body 
build(deps): bump github.com/xanzy/go-gitlab from 0.59.0 to 0.64.0

Michael Muré created

75ca2ce model: Multiple, minor readability and language improvements

Robin Vobruba created

9b871c6 model: Removes now outdated statement about ops and root

Robin Vobruba created

00fb4bc model: Highlight some words with special meaning

Robin Vobruba created