From 1b72ab228a3f029f4eac3922d46e4ebf065eabf5 Mon Sep 17 00:00:00 2001 From: mehmet turac Date: Sat, 16 May 2026 08:18:10 +0300 Subject: [PATCH] test: check daemon unmarshal errors (#1296) ## What? - Check JSON unmarshal errors in daemon handler tests. - Fail clearly when a response body cannot be decoded instead of ignoring the error. - Keep the change limited to daemon tests. ## Why? Ignoring `json.Unmarshal` errors can let malformed test responses pass into later assertions with less useful failures. This makes the daemon tests report decode problems at the source. Fixes #718 --- daemon/daemon_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/daemon/daemon_test.go b/daemon/daemon_test.go index 2fe87a490476690018c50ce21c7ab7e72b308710..e6fe250ab6617c9026b5f8851391ffb42cb55399 100644 --- a/daemon/daemon_test.go +++ b/daemon/daemon_test.go @@ -99,7 +99,9 @@ func TestDaemon_PingHandler(t *testing.T) { t.Fatal("expected Response") } var result daemonrpc.PingResult - json.Unmarshal(msg.Response.Result, &result) + if err := json.Unmarshal(msg.Response.Result, &result); err != nil { + t.Fatalf("failed to unmarshal ping result: %v", err) + } if !result.Pong { t.Error("expected pong=true") } @@ -115,7 +117,9 @@ func TestDaemon_StatusHandler(t *testing.T) { msg := handlerTest(t, d, &daemonrpc.Request{ID: 1, Method: daemonrpc.MethodGetStatus}) var result daemonrpc.StatusResult - json.Unmarshal(msg.Response.Result, &result) + if err := json.Unmarshal(msg.Response.Result, &result); err != nil { + t.Fatalf("failed to unmarshal status result: %v", err) + } if !result.Running { t.Error("expected running=true")