fix: remove the tabs for a singular account usage (#125)

Drew Smirnoff created 5 months ago

Change summary

tui/inbox.go      | 30 +++++++++++++++++++-----------
tui/inbox_test.go |  6 +++---
2 files changed, 22 insertions(+), 14 deletions(-)

Detailed changes

tui/inbox.go

@@ -106,11 +106,15 @@ func NewSentInbox(emails []fetcher.Email, accounts []config.Account) *Inbox {
 }
 
 func NewInboxWithMailbox(emails []fetcher.Email, accounts []config.Account, mailbox MailboxKind) *Inbox {
-	// Build tabs: "ALL" + one per account
-	tabs := []AccountTab{{ID: "", Label: "ALL", Email: ""}}
-	for _, acc := range accounts {
-		label := acc.Email
-		tabs = append(tabs, AccountTab{ID: acc.ID, Label: label, Email: acc.Email})
+	// Build tabs: empty for single account, "ALL" + accounts for multiple
+	var tabs []AccountTab
+	if len(accounts) <= 1 {
+		tabs = []AccountTab{{ID: "", Label: "", Email: ""}}
+	} else {
+		tabs = []AccountTab{{ID: "", Label: "ALL", Email: ""}}
+		for _, acc := range accounts {
+			tabs = append(tabs, AccountTab{ID: acc.ID, Label: acc.Email, Email: acc.Email})
+		}
 	}
 
 	// Group emails by account
@@ -152,7 +156,7 @@ func (m *Inbox) updateList() {
 	if m.currentAccountID == "" {
 		// "ALL" view - show all emails sorted by date
 		displayEmails = m.allEmails
-		showAccountLabel = len(m.accounts) > 1
+		showAccountLabel = !(len(m.accounts) <= 1)
 	} else {
 		// Specific account view
 		displayEmails = m.emailsByAccount[m.currentAccountID]
@@ -516,11 +520,15 @@ func (m *Inbox) SetEmails(emails []fetcher.Email, accounts []config.Account) {
 	m.accounts = accounts
 	m.allEmails = emails
 
-	// Rebuild tabs
-	tabs := []AccountTab{{ID: "", Label: "ALL", Email: ""}}
-	for _, acc := range accounts {
-		label := acc.Email
-		tabs = append(tabs, AccountTab{ID: acc.ID, Label: label, Email: acc.Email})
+	// Rebuild tabs: empty for single account, "ALL" + accounts for multiple
+	var tabs []AccountTab
+	if len(accounts) <= 1 {
+		tabs = []AccountTab{{ID: "", Label: "", Email: ""}}
+	} else {
+		tabs = []AccountTab{{ID: "", Label: "ALL", Email: ""}}
+		for _, acc := range accounts {
+			tabs = append(tabs, AccountTab{ID: acc.ID, Label: acc.Email, Email: acc.Email})
+		}
 	}
 	m.tabs = tabs
 

tui/inbox_test.go

@@ -124,9 +124,9 @@ func TestInboxSingleAccount(t *testing.T) {
 
 	inbox := NewInbox(emails, accounts)
 
-	// Should have 2 tabs: ALL + 1 account
-	if len(inbox.tabs) != 2 {
-		t.Errorf("Expected 2 tabs, got %d", len(inbox.tabs))
+	// Should have 0 tabs (visually)
+	if len(inbox.tabs) != 1 {
+		t.Errorf("Expected 1 phantom tab, got %d", len(inbox.tabs))
 	}
 }