Merge branch 'support-more-delivery-failure-metadata' into 'master'

Stephen Paul Weber created 4 years ago

Log the errorCode and description for deliver-failure

See merge request soprani.ca/sgx-bwmsgsv2!3

Change summary

sgx-bwmsgsv2.rb | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

Detailed changes

sgx-bwmsgsv2.rb

@@ -865,10 +865,10 @@ class WebhookHandler < Goliath::API
 			#', state: ' + jparams['state'] +
 			', deliveryState: ' + (jparams['deliveryState'] ?
 				jparams['deliveryState'] : 'NONE') +
-			', deliveryCode: ' + (jparams['deliveryCode'] ?
-				jparams['deliveryCode'] : 'NONE') +
-			', deliveryDesc: ' + (jparams['deliveryDescription'] ?
-				jparams['deliveryDescription'] : 'NONE') +
+			', errorCode: ' + (jparams['errorCode'] ?
+				jparams['errorCode'] : 'NONE') +
+			', description: ' + (jparams['description'] ?
+				jparams['description'] : 'NONE') +
 			', tag: ' + (jparams['tag'] ? jparams['tag'] : 'NONE') +
 			', media: ' + (jparams['media'] ?
 				jparams['media'].to_s : 'NONE')
@@ -1017,11 +1017,11 @@ class WebhookHandler < Goliath::API
 
 				# TODO: add 'errorCode' and/or 'description' val
 				# create an error reply to the bare message
-				msg = Blather::StanzaError.new(
-					msg,
+				msg = msg.as_error(
 					'recipient-unavailable',
-					:wait
-				).to_node
+					:wait,
+					jparams['description']
+				)
 
 				# TODO: make prettier: this should be done above
 				others_num = params['_json'][0]['to']