From 1570fd80aa13fdb77f02edea53e8b4958228f360 Mon Sep 17 00:00:00 2001 From: Denver Gingerich Date: Fri, 8 May 2020 22:40:19 +0000 Subject: [PATCH] add note re MMS on OOB URL for V2 as no Jingle now Since we ripped out support for Jingle File Transfer in 60832f5 we need to figure out the best way to provide MMS by default to users of this SGX (the V2 SGX). Should we just turn it on by default for all users? We could, but we'd have to let anyone migrating from V1 to V2 know about this change. And maybe there should be a different default option? In any case, it still needs to be decided so add a TODO here. --- sgx-bwmsgsv2.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/sgx-bwmsgsv2.rb b/sgx-bwmsgsv2.rb index f48b8546f6266ceb9de6dcb704b01dbf5c5cfd11..2e020f2a0f8481aa098fa4754a1ff8e9ae26c696 100755 --- a/sgx-bwmsgsv2.rb +++ b/sgx-bwmsgsv2.rb @@ -270,6 +270,7 @@ module SGXbwmsgsv2 end puts "MMSOOB: found a url node - checking if to make MMS..." + # TODO: always enable MMS on OOB URL for V2? need 2 inform users REDIS.getbit("catapult_setting_flags-#{s.from.stripped}", CatapultSettingFlagBits::MMS_ON_OOB_URL).then { |oob_on|