From 1ed11ad3393fa97a1688643fcf68ca261a0d04ba Mon Sep 17 00:00:00 2001 From: Denver Gingerich Date: Mon, 10 Apr 2017 14:27:06 +0000 Subject: [PATCH] response output was lost in translation in ff64421 In the pre-refactor code, response.to_s looks something like this: "#". After the refactor in ff64421 the chosen replacement value (http.response) outputs the entire body of the response instead, which is more than we're looking to log. So remove it entirely ("#", the value of http.to_s, is even less useful than response.to_s was) and just print the response code on its own in that line now. This happens to fix an 80-column violation introduced in ff64421 as well, which we should probably have checked by RuboCop at some point. --- mpx-catapult.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mpx-catapult.rb b/mpx-catapult.rb index 330321b10470e162beb956cee0f43103ae941b0c..4d4204777391e8839a1b620fd214964caf9d3b57 100755 --- a/mpx-catapult.rb +++ b/mpx-catapult.rb @@ -52,8 +52,8 @@ class WebhookHandler < Goliath::API 'Authorization' => [token, secret] } ).then { |http| - env.logger.debug "API response to send: #{http.response} "\ - "with code #{http.response_header.status}" + env.logger.debug "API response code to send: " + + http.response_header.status.to_s case http.response_header.status when 200