From 47bf2a23d31a1e020a124ddf1a24e79fe96480e9 Mon Sep 17 00:00:00 2001 From: Phillip Davis Date: Tue, 17 Jun 2025 11:12:07 -0400 Subject: [PATCH] two fixes related to eSIM nicks: 1. actually expose nickanem at eSIM order-time 2. pass nickname to `SIMOrder.commit` as non-kw arg in eSIM sublcass --- lib/sim_order.rb | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/sim_order.rb b/lib/sim_order.rb index d1999afdb7c0cc53e40afec4f3f93f1f0c9712e7..ae91fa058f7b31aa51e81e399efa113b1266c67a 100644 --- a/lib/sim_order.rb +++ b/lib/sim_order.rb @@ -119,7 +119,14 @@ protected end def self.fillable_fields - [] + [ + { + type: "text-single", + var: "nickname", + label: "Nickname", + required: false + } + ] end # @param [Blather::Stanza::Iq] iq the stanza @@ -127,7 +134,7 @@ protected def complete(iq) EMPromise.resolve(nil).then { commit( - nickname: iq.form.field("nickname")&.value.presence || self.class.label + iq.form.field("nickname")&.value.presence || self.class.label ) }.then do |sim| ActivationCode.new(sim).complete