Remove LegacyCustomer

Stephen Paul Weber created 4 years ago

Such customers are not longer a common or valid case.

Change summary

forms/legacy_customer_admin_info.rb   | 29 --------------
forms/legacy_customer_info.rb         |  4 --
forms/legacy_customer_info_partial.rb | 11 -----
lib/customer_info_form.rb             |  1 
lib/customer_repo.rb                  | 11 -----
lib/legacy_customer.rb                | 58 -----------------------------
test/test_customer_info.rb            | 18 ---------
test/test_customer_repo.rb            | 21 ----------
8 files changed, 2 insertions(+), 151 deletions(-)

Detailed changes

forms/legacy_customer_admin_info.rb

@@ -1,29 +0,0 @@
-result!
-title "Customer Info"
-
-render "legacy_customer_info_partial", info: @admin_info.info
-
-field(
-	var: "jid",
-	label: "JID",
-	value: @admin_info.jid.unproxied.to_s
-)
-
-field(
-	var: "cheo_jid",
-	label: "Cheo JID",
-	value: @admin_info.jid.to_s
-)
-
-field(
-	var: "api",
-	label: "API",
-	value: @admin_info.api.to_s
-)
-
-field(
-	var: "link",
-	label: "Link",
-	type: "jid-single",
-	value: "#{@admin_info.info.tel}@#{CONFIG[:upstream_domain]}"
-)

forms/legacy_customer_info.rb

@@ -1,4 +0,0 @@
-result!
-title "Account Info"
-
-render "legacy_customer_info_partial"

forms/legacy_customer_info_partial.rb

@@ -1,11 +0,0 @@
-field(
-	var: "account_status",
-	label: "Account Status",
-	value: "Legacy"
-)
-
-field(
-	var: "tel",
-	label: "Phone Number",
-	value: @info.tel
-)

lib/customer_info_form.rb

@@ -3,7 +3,6 @@
 require_relative "bwmsgsv2_repo"
 require_relative "customer_repo"
 require_relative "proxied_jid"
-require_relative "legacy_customer"
 
 class CustomerInfoForm
 	def initialize(customer_repo=CustomerRepo.new(sgx_repo: Bwmsgsv2Repo.new))

lib/customer_repo.rb

@@ -3,7 +3,6 @@
 require "lazy_object"
 
 require_relative "customer"
-require_relative "legacy_customer"
 require_relative "polyfill"
 
 class CustomerRepo
@@ -34,7 +33,7 @@ class CustomerRepo
 			find($1)
 		else
 			@redis.get("jmp_customer_id-#{jid}").then do |customer_id|
-				next find_legacy_customer(jid) unless customer_id
+				raise "No customer" unless customer_id
 
 				find_inner(customer_id, jid)
 			end
@@ -94,14 +93,6 @@ protected
 		TrivialBackendSgxRepo.new.get(customer_id).with(registered?: false)
 	end
 
-	def find_legacy_customer(jid)
-		@redis.lindex("catapult_cred-#{jid}", 3).then do |tel|
-			raise NotFound, "No customer" unless tel
-
-			LegacyCustomer.new(Blather::JID.new(jid), tel)
-		end
-	end
-
 	def hydrate_plan(customer_id, raw_customer)
 		raw_customer.dup.tap do |data|
 			data[:plan] = CustomerPlan.new(

lib/legacy_customer.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-
-require "value_semantics/monkey_patched"
-require_relative "proxied_jid"
-
-class LegacyCustomer
-	attr_reader :jid, :tel
-
-	def initialize(jid, tel)
-		@jid = jid
-		@tel = tel
-	end
-
-	def customer_id
-		nil
-	end
-
-	def info
-		EMPromise.resolve(nil).then do
-			Info.new(tel: tel)
-		end
-	end
-
-	def admin_info
-		EMPromise.all([
-			info,
-			api
-		]).then do |info, api|
-			AdminInfo.new(info: info, jid: jid, api: api)
-		end
-	end
-
-	def api
-		API.for(self)
-	end
-
-	class Info
-		value_semantics do
-			tel String
-		end
-
-		def form
-			FormTemplate.render("legacy_customer_info", info: self)
-		end
-	end
-
-	class AdminInfo
-		value_semantics do
-			info Info
-			jid ProxiedJID, coerce: ProxiedJID.method(:new)
-			api API
-		end
-
-		def form
-			FormTemplate.render("legacy_customer_admin_info", admin_info: self)
-		end
-	end
-end

test/test_customer_info.rb

@@ -100,24 +100,6 @@ class CustomerInfoTest < Minitest::Test
 	end
 	em :test_inactive_admin_info_does_not_crash
 
-	def test_legacy_customer_info_does_not_crash
-		cust = LegacyCustomer.new(
-			Blather::JID.new("[e-mail]"),
-			"[phone]"
-		)
-		assert cust.info.sync.form
-	end
-	em :test_legacy_customer_info_does_not_crash
-
-	def test_legacy_customer_admin_info_does_not_crash
-		cust = LegacyCustomer.new(
-			Blather::JID.new("[e-mail]"),
-			"[phone]"
-		)
-		assert cust.admin_info.sync.form
-	end
-	em :test_legacy_customer_admin_info_does_not_crash
-
 	def test_missing_customer_admin_info_does_not_crash
 		cust = CustomerInfoForm::NoCustomer.new
 		assert cust.admin_info.form

test/test_customer_repo.rb

@@ -29,12 +29,7 @@ class CustomerRepoTest < Minitest::Test
 		"catapult_jid-[phone]" => "[e-mail]",
 		"[e-mail]" => [
 			"test_bw_customer", "", "", "[phone]"
-		],
-		# legacy customer
-		"[e-mail]" => [
-			"catapult_user", "", "", "[phone]"
-		],
-		"catapult_jid-[phone]" => "[e-mail]"
+		]
 	)
 
 	FAKE_DB = FakeDB.new(
@@ -99,13 +94,6 @@ class CustomerRepoTest < Minitest::Test
 	end
 	em :test_find_by_jid_not_found
 
-	def test_find_legacy_customer
-		customer = @repo.find_by_jid("[e-mail]").sync
-		assert_kind_of LegacyCustomer, customer
-		assert_equal "[phone]", customer.tel
-	end
-	em :test_find_legacy_customer
-
 	def test_find_sgx_customer_by_phone
 		customer = @repo.find_by_tel("[phone]").sync
 		assert_kind_of Customer, customer
@@ -120,13 +108,6 @@ class CustomerRepoTest < Minitest::Test
 	end
 	em :test_find_v2_customer_by_phone
 
-	def test_find_legacy_customer_by_phone
-		customer = @repo.find_by_tel("[phone]").sync
-		assert_kind_of LegacyCustomer, customer
-		assert_equal "[e-mail]", customer.jid.to_s
-	end
-	em :test_find_legacy_customer_by_phone
-
 	def test_find_missing_phone
 		assert_raises do
 			@repo.find_by_tel("[phone]").sync