From eb33c423db0d04e5e5f859201176781bc62ed05b Mon Sep 17 00:00:00 2001
From: Phillip Davis <phdavis1027@gmail.com>
Date: Mon, 29 Jun 2026 12:09:21 -0400
Subject: [PATCH] handle failed porting jobs

customers without tels are no longer considered unknown.
the only other sensible definition of an unknown customer would
be "doesn't have a customer id," but the customer info command
will never return data that didnt come from a CustomerRepo.

anyway, this causes failed registrations to retry
---
 lib/porting_step_repo.rb  | 32 --------------------------------
 test/test_porting_step.rb |  4 +---
 2 files changed, 1 insertion(+), 35 deletions(-)

diff --git a/lib/porting_step_repo.rb b/lib/porting_step_repo.rb
index 4090928d6d63d653057d2824685d9d85d8701ae8..668e368cc165aa36d49c92a66f2ae7b6eee16f88 100644
--- a/lib/porting_step_repo.rb
+++ b/lib/porting_step_repo.rb
@@ -96,36 +96,6 @@ class PortingStepRepo
 				"key `jmp_port_freeze-#{port.id}`"
 		end
 
-		class NoCustomer < self
-			attr_reader :port
-
-			NO_GRACE_PERIOD = 0
-
-			def initialize(port:, **kwargs)
-				@port = port
-				super(**kwargs)
-			end
-
-			def self.for(port:, **kwargs)
-				Alert.for(
-					port,
-					grace_period: NO_GRACE_PERIOD,
-					real_step: new(port: port, **kwargs),
-					output: kwargs[:output],
-					msg: msg(port),
-					key: :port_for_unknown_customer
-				)
-			end
-
-			def self.msg(port)
-				"⚠ Freezing port #{port.id} for unknown customer: #{port.customer_id}."
-			end
-
-			def perform_next_step
-				redis.set("jmp_port_freeze-#{port.id}", 1)
-			end
-		end
-
 		class AdminCommand < self
 			def initialize(exe:, **kwargs)
 				@exe = exe
@@ -139,8 +109,6 @@ class PortingStepRepo
 			def find(port)
 				h = to_h
 				@exe.fetch_and_submit(q: port.customer_id).then do |form|
-					next NoCustomer.for(port: port, **h.except(:exe)) unless form.tel
-
 					if port.tel == form.tel && form.route == port.backend_sgx.to_s
 						GoodNumber.new(**h).find(port)
 					else
diff --git a/test/test_porting_step.rb b/test/test_porting_step.rb
index ade9f89aaaac3c1592fd9b1cf1f960dcc5d21a73..36971c2032225503a42a36aa463e2b57826b8701 100644
--- a/test/test_porting_step.rb
+++ b/test/test_porting_step.rb
@@ -319,9 +319,7 @@ class PortingStepTest < Minitest::Test
 			Blather::JID.new("testroute")
 		)).sync
 
-		assert_kind_of PortingStepRepo::Alert, step
-		assert_equal :port_for_unknown_customer, step.key
-		assert_kind_of PortingStepRepo::Complete::NoCustomer, step.real_step
+		assert_kind_of PortingStepRepo::Complete::AdminCommand::WrongNumber, step
 		assert_mock redis
 		assert_mock notify
 	end