847ff2b
refactor(admin_command): simplify to ternary
Click to expand commit body
registered? never returns nil, no need to handle it
Amolith created
847ff2b
refactor(admin_command): simplify to ternary
registered? never returns nil, no need to handle it
Amolith created
19024b4
fix(admin_command): handle false from registered?
Use `(reg || nil)&.phone` instead of `reg && reg.phone` to satisfy Style/SafeNavigation while still handling false (not just nil). Assisted-by: Claude Opus 4.5 via Crush
Amolith created
8e46bbd
feat: include customer context in admin menu
Display customer ID and contact information (Jabber ID, phone number) when selecting actions to help admins identify which customer they're working with. Implements: https://todo.sr.ht/~singpolyma/soprani.ca/465 Assisted-by: MiniMax M2 via Crush <crush@charm.land>
Amolith created
d03d4a3
Add more datatypes
Stephen Paul Weber created
c41d3fe
Kumi.tube is dead and not coming back
Stephen Paul Weber created
a5cef0c
unused arg
Stephen Paul Weber created
09e95f1
This is usually just the iq error from a backend with no commands
Stephen Paul Weber created
538f56a
stanza expects to to be set to *something*
Stephen Paul Weber created
c63bf73
No more async in list_for
We have a loader, let's use it Probably we want to load list of command as part of the sgx repo? But maybe that's too heavy and we don't always need it?
Stephen Paul Weber created
1b16d8a
No more mixin
Stephen Paul Weber created
e095700
Fix tests
Stephen Paul Weber created
5b320d3
Merge branch '380-set-port-out-pin' of https://git.secluded.site/sgx-jmp
* '380-set-port-out-pin' of https://git.secluded.site/sgx-jmp: feat: add command to set port-out PIN
Stephen Paul Weber created
a18b326
feat: add command to set port-out PIN
Currently, port-out PINs require manual intervention from support. This command allows customers to self-manage their port-out PINs. Actual functionality is delegated to the user's backend. For now, that's just sgx-bwmsgsv2. References: https://todo.sr.ht/~singpolyma/soprani.ca/380
Amolith created
a16a320
verify that mixins refer to valid ivars
- uses solargraph sourcemap, which requires a patch for Ruby 3.4 that is not available (patched solargraph version is incompatible with pinned rubocop) - conditionally checks for two different kinds of ivar nodes using the same check that solargraph uses internally to decide between current and legacy parsers
Phillip Davis created
a5feabe
fix(#458): pass customer as @-var to PleaseTopUp
SIMAction mixin referenced @customer, but PleaseTopUp didn't have such a field, which caused "undefined method `jid’ for nil:NilClass" when checking customer onboarding
Phillip Davis created
f0fc88a
fields are on forms
Stephen Paul Weber created
5cdf6c0
Support data-only registration
Phillip Davis created
0015a69
mark test instances as such
Phillip Davis created
2a30a46
Merge branch 'fix/change-number-for-unregistered' of git.sr.ht:~phdavis1027/sgx-jmp
* 'fix/change-number-for-unregistered' of git.sr.ht:~phdavis1027/sgx-jmp: NumberChange can now handle unregistered cust
Stephen Paul Weber created
4ccca7d
NumberChange can now handle unregistered cust
- old_tel is nil if customer unregistered - test unregistered for blank num ^ involved fixing a race between check_noop and check_orphan act on feedback
Phillip Davis created
bcc97a3
use tn.get_details[:city] in stash_for_later
i apparently thought this was broken earlier, but it seems to just work in test cases i have tried, so let's see if this version just does what it should
Phillip Davis created
809347e
Re enable for now
Stephen Paul Weber created
7ea591e
Clean up abstractions
Stephen Paul Weber created
7dbf0c5
enhance AdminAction::NumberChange, can change sgx
Phillip Davis created
b72e46c
pass price from LocalInventory to Option#option
Phillip Davis created
e532e7c
codes dont make sense here
Phillip Davis created
249f177
check specific status
Phillip Davis created
dbcb6a6
Normalize phone number sooner
for API call
Stephen Paul Weber created
215940c
fix unitialized constant error
Phillip Davis created
d0006ff
add pry-byebug
gives us "step" and "next" commands
Phillip Davis created
0ef2aba
end-to-end change_number test
Phillip Davis created
3a9b181
tests for change_number
Phillip Davis created
1ac3fb5
Fix lint
Stephen Paul Weber created
4c49c75
dont allow porting in our own numbers
Phillip Davis created
7277ecb
update README for postgres setup
- gotta GRANT CREATE ON PUBLIC - postgis - redis_fdw + commands on setting up the foreign server and user mapping
Phillip Davis created
0e2b793
Skip test for disabled feature
Stephen Paul Weber created
b888546
Disable free gplay month for now
Stephen Paul Weber created
db13d4b
More debug log for top up blocked
Stephen Paul Weber created
a0a4c7b
Show price for premium inventory
Stephen Paul Weber created
bc6009c
actually bill for local numbers
Phillip Davis created
8301de9
Log when stashing for later
To figure out why we're saving non-+1 stuff
Stephen Paul Weber created
0769d50
Formatting fix
Stephen Paul Weber created
331cbb1
Forgot this
Stephen Paul Weber created
bcc532c
Merge branch 'premium'
* premium: Factor out BuyNumber Inject price Bill after charge Inline useless methods Remove unused method Fix test charge for premium nums refactor registration_test to use real Tn's two changes related to registration forms price functionality on Tns Remove legacy card charge behaviour two fixes related to eSIM nicks: Factor out reload customer, check balance, maybe bill Unify more invite code handling Remove mostly-unused final_message Remove legacy card charge behaviour
Stephen Paul Weber created
d9f0ee5
Factor out BuyNumber
Stephen Paul Weber created
6675b96
Inject price
Since that's what we actually care about. Also makes JustCharge more generic for future use
Stephen Paul Weber created
c80b2e2
Bill after charge
instead of this blind retry
Stephen Paul Weber created
0dd26e5
Inline useless methods
And use a better transaction id
Stephen Paul Weber created
cafd02f
Remove unused method
And move price method where it actually goes
Stephen Paul Weber created
bdc86ed
Fix test
Stephen Paul Weber created