From fdebb9a60a52dcb4aab207aa959e706d2abe0666 Mon Sep 17 00:00:00 2001 From: Philip Zeyliger Date: Sun, 8 Feb 2026 11:16:55 -0800 Subject: [PATCH] shelley: fix ESLint errors in TerminalPanel Prompt: fix it (link to failing ESLint CI job) Remove unused onCloseAll prop, unused activeInfo variable, and invalid eslint-disable comments for unconfigured react-hooks rule. Co-Authored-By: Claude Opus 4.6 --- ui/src/components/ChatInterface.tsx | 1 - ui/src/components/TerminalPanel.tsx | 7 +------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/ui/src/components/ChatInterface.tsx b/ui/src/components/ChatInterface.tsx index 2617225e0c3a14a131abc71281add338c1eb08a9..ac76ef89885689c9620f0ff618789a0b00256cd5 100644 --- a/ui/src/components/ChatInterface.tsx +++ b/ui/src/components/ChatInterface.tsx @@ -1660,7 +1660,6 @@ function ChatInterface({ setEphemeralTerminals((prev) => prev.filter((t) => t.id !== id))} - onCloseAll={() => setEphemeralTerminals([])} onInsertIntoInput={handleInsertFromTerminal} /> diff --git a/ui/src/components/TerminalPanel.tsx b/ui/src/components/TerminalPanel.tsx index 173066b3c2bd0dbed88261682dd489dc427f17bd..fb0c4f557038ae6c67d7fd271da30c31969d9f0e 100644 --- a/ui/src/components/TerminalPanel.tsx +++ b/ui/src/components/TerminalPanel.tsx @@ -25,7 +25,6 @@ export interface EphemeralTerminal { interface TerminalPanelProps { terminals: EphemeralTerminal[]; onClose: (id: string) => void; - onCloseAll: () => void; onInsertIntoInput?: (text: string) => void; } @@ -210,7 +209,6 @@ function ActionButton({ export default function TerminalPanel({ terminals, onClose, - onCloseAll, onInsertIntoInput, }: TerminalPanelProps) { const [activeTabId, setActiveTabId] = useState(null); @@ -247,7 +245,7 @@ export default function TerminalPanel({ } else { setActiveTabId(null); } - }, [terminals.length]); // eslint-disable-line react-hooks/exhaustive-deps + }, [terminals.length]); // If active tab got closed, switch to the last remaining useEffect(() => { @@ -417,8 +415,6 @@ export default function TerminalPanel({ if (terminals.length === 0) return null; - const activeInfo = activeTabId ? statusMap.get(activeTabId) : null; - // Truncate command for tab label const tabLabel = (cmd: string) => { // Show first word or first 30 chars @@ -659,7 +655,6 @@ function TerminalInstanceWithRegistry({ xterm.dispose(); onUnregister(term.id); }; - // eslint-disable-next-line react-hooks/exhaustive-deps }, [term.id, term.command, term.cwd]); // Update theme