fix(webhook): we don't care about the default branch if it's missing

Ayman Bagabas created 2 years ago

Change summary

pkg/webhook/branch_tag.go   | 5 +----
pkg/webhook/collaborator.go | 5 +----
pkg/webhook/push.go         | 5 +----
pkg/webhook/repository.go   | 5 +----
4 files changed, 4 insertions(+), 16 deletions(-)

Detailed changes

pkg/webhook/branch_tag.go

@@ -77,10 +77,7 @@ func NewBranchTagEvent(ctx context.Context, user proto.User, repo proto.Reposito
 
 	payload.Repository.Owner.ID = owner.ID
 	payload.Repository.Owner.Username = owner.Username
-	payload.Repository.DefaultBranch, err = getDefaultBranch(repo)
-	if err != nil {
-		return BranchTagEvent{}, err
-	}
+	payload.Repository.DefaultBranch, _ = getDefaultBranch(repo)
 
 	return payload, nil
 }

pkg/webhook/collaborator.go

@@ -65,10 +65,7 @@ func NewCollaboratorEvent(ctx context.Context, user proto.User, repo proto.Repos
 
 	payload.Repository.Owner.ID = owner.ID
 	payload.Repository.Owner.Username = owner.Username
-	payload.Repository.DefaultBranch, err = getDefaultBranch(repo)
-	if err != nil {
-		return CollaboratorEvent{}, err
-	}
+	payload.Repository.DefaultBranch, _ = getDefaultBranch(repo)
 
 	collab, err := datastore.GetCollabByUsernameAndRepo(ctx, dbx, collabUsername, repo.Name())
 	if err != nil {

pkg/webhook/push.go

@@ -74,10 +74,7 @@ func NewPushEvent(ctx context.Context, user proto.User, repo proto.Repository, r
 		return PushEvent{}, err
 	}
 
-	payload.Repository.DefaultBranch, err = getDefaultBranch(repo)
-	if err != nil {
-		return PushEvent{}, err
-	}
+	payload.Repository.DefaultBranch, _ = getDefaultBranch(repo)
 
 	rev := after
 	if !git.IsZeroHash(before) {

pkg/webhook/repository.go

@@ -76,10 +76,7 @@ func NewRepositoryEvent(ctx context.Context, user proto.User, repo proto.Reposit
 
 	payload.Repository.Owner.ID = owner.ID
 	payload.Repository.Owner.Username = owner.Username
-	payload.Repository.DefaultBranch, err = getDefaultBranch(repo)
-	if err != nil {
-		return RepositoryEvent{}, err
-	}
+	payload.Repository.DefaultBranch, _ = getDefaultBranch(repo)
 
 	return payload, nil
 }