fix(server): wait for and ensure git command exits

Ayman Bagabas created 2 years ago

We have to wait for exec.Command to exit

Fixes: https://github.com/charmbracelet/soft-serve/issues/262

Change summary

server/git/git.go | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Detailed changes

server/git/git.go

@@ -136,11 +136,11 @@ func RunGit(ctx context.Context, in io.Reader, out io.Writer, er io.Writer, dir
 	})
 
 	if err := errg.Wait(); err != nil {
-		logger.Error("while running git command", "err", err)
-		return err
+		logger.Error("while copying output", "err", err)
 	}
 
-	return nil
+	// Wait for the command to finish
+	return c.Wait()
 }
 
 // WritePktline encodes and writes a pktline to the given writer.