diff --git a/internal/tui/bubble.go b/internal/tui/bubble.go index ed5a314ee202086135812bd5d2c1217e638fc35c..321b0fe86a5c3879ff253aecd3fec4fd3a5e4f8e 100644 --- a/internal/tui/bubble.go +++ b/internal/tui/bubble.go @@ -160,7 +160,7 @@ func (b Bubble) footerView() string { var h []gittypes.HelpEntry if b.state != errorState { h = []gittypes.HelpEntry{ - {"tab", "section"}, + {Key: "tab", Value: "section"}, } if box, ok := b.boxes[b.activeBox].(gittypes.BubbleHelper); ok { help := box.Help() @@ -169,7 +169,7 @@ func (b Bubble) footerView() string { } } } - h = append(h, gittypes.HelpEntry{"q", "quit"}) + h = append(h, gittypes.HelpEntry{Key: "q", Value: "quit"}) for i, v := range h { fmt.Fprint(w, helpEntryRender(v, b.styles)) if i != len(h)-1 { diff --git a/internal/tui/bubbles/git/bubble.go b/internal/tui/bubbles/git/bubble.go index a6ed04a1dac63bd1edda771cb0262c254b88f1f4..4a47467fe37ed64467ef4ac539f53dd9f0ab7b4a 100644 --- a/internal/tui/bubbles/git/bubble.go +++ b/internal/tui/bubbles/git/bubble.go @@ -110,10 +110,10 @@ func (b *Bubble) Help() []types.HelpEntry { h := []types.HelpEntry{} h = append(h, b.boxes[b.state].(types.BubbleHelper).Help()...) if b.repo.Name() != "config" { - h = append(h, types.HelpEntry{"R", "readme"}) - h = append(h, types.HelpEntry{"F", "files"}) - h = append(h, types.HelpEntry{"C", "commits"}) - h = append(h, types.HelpEntry{"B", "branches"}) + h = append(h, types.HelpEntry{Key: "R", Value: "readme"}) + h = append(h, types.HelpEntry{Key: "F", Value: "files"}) + h = append(h, types.HelpEntry{Key: "C", Value: "commits"}) + h = append(h, types.HelpEntry{Key: "B", Value: "branches"}) } return h } diff --git a/internal/tui/bubbles/git/log/bubble.go b/internal/tui/bubbles/git/log/bubble.go index 46118cff6889080e5d0c1f55989227eab426d222..773784e7ab4fe9bc6f0e979b96ef0a9314431326 100644 --- a/internal/tui/bubbles/git/log/bubble.go +++ b/internal/tui/bubbles/git/log/bubble.go @@ -45,7 +45,7 @@ const ( ) type item struct { - *types.Commit + *object.Commit } func (i item) Title() string { @@ -229,28 +229,28 @@ func (b *Bubble) loadCommit() tea.Cmd { // https://github.com/go-git/go-git/issues/281 tree, err := c.Tree() if err != nil { - return types.ErrMsg{err} + return types.ErrMsg{Err: err} } var parent *object.Commit parentTree := &object.Tree{} if c.NumParents() > 0 { parent, err = c.Parents().Next() if err != nil { - return types.ErrMsg{err} + return types.ErrMsg{Err: err} } parentTree, err = parent.Tree() if err != nil { - return types.ErrMsg{err} + return types.ErrMsg{Err: err} } } ctx, cancel := context.WithTimeout(context.TODO(), types.MaxPatchWait) defer cancel() patch, err := parentTree.PatchContext(ctx, tree) if err != nil { - return types.ErrMsg{err} + return types.ErrMsg{Err: err} } return commitMsg{ - commit: c.Commit.Commit, + commit: c.Commit, tree: tree, parent: parent, parentTree: parentTree, diff --git a/internal/tui/bubbles/git/tree/bubble.go b/internal/tui/bubbles/git/tree/bubble.go index 3bbefef5d983db3ff63debe6e7397209c73db321..f16a9d71b14b4bcc356fcd44d2e859a3e90aeff5 100644 --- a/internal/tui/bubbles/git/tree/bubble.go +++ b/internal/tui/bubbles/git/tree/bubble.go @@ -187,7 +187,7 @@ func (b *Bubble) updateItems() tea.Cmd { its := make(items, 0) t, err := b.repo.Tree(b.ref, b.path) if err != nil { - return func() tea.Msg { return types.ErrMsg{err} } + return func() tea.Msg { return types.ErrMsg{Err: err} } } tw := object.NewTreeWalker(t, false, map[plumbing.Hash]bool{}) defer tw.Close() @@ -307,18 +307,18 @@ func (b *Bubble) View() string { func (b *Bubble) loadFile(i item) tea.Cmd { return func() tea.Msg { if !i.Mode().IsFile() || i.file == nil { - return types.ErrMsg{types.ErrInvalidFile} + return types.ErrMsg{Err: types.ErrInvalidFile} } bin, err := i.file.IsBinary() if err != nil { - return types.ErrMsg{err} + return types.ErrMsg{Err: err} } if bin { - return types.ErrMsg{types.ErrBinaryFile} + return types.ErrMsg{Err: types.ErrBinaryFile} } c, err := i.file.Contents() if err != nil { - return types.ErrMsg{err} + return types.ErrMsg{Err: err} } return fileMsg{ content: c, diff --git a/internal/tui/bubbles/git/types/git.go b/internal/tui/bubbles/git/types/git.go index de6bfd1aae84e81306a3da20ee389075189cab18..758f9d126eb39b2018ba03c4f70e869df4b555b8 100644 --- a/internal/tui/bubbles/git/types/git.go +++ b/internal/tui/bubbles/git/types/git.go @@ -17,11 +17,7 @@ type Repo interface { Tree(*plumbing.Reference, string) (*object.Tree, error) } -type Commit struct { - *object.Commit -} - -type Commits []*Commit +type Commits []*object.Commit func (cl Commits) Len() int { return len(cl) } func (cl Commits) Swap(i, j int) { cl[i], cl[j] = cl[j], cl[i] } diff --git a/internal/tui/bubbles/selection/bubble.go b/internal/tui/bubbles/selection/bubble.go index 26730dd214f19f720e65b15cada8d88a3becb44f..eb84b5d6817ac5174b92a1c187ca3eae14546d94 100644 --- a/internal/tui/bubbles/selection/bubble.go +++ b/internal/tui/bubbles/selection/bubble.go @@ -82,7 +82,7 @@ func (b *Bubble) Update(msg tea.Msg) (tea.Model, tea.Cmd) { func (b *Bubble) Help() []gittypes.HelpEntry { return []gittypes.HelpEntry{ - {"↑/↓", "navigate"}, + {Key: "↑/↓", Value: "navigate"}, } }