From 6c8c950acdbdab605420a992c85893b2e280b9bc Mon Sep 17 00:00:00 2001 From: Amolith Date: Thu, 27 Mar 2025 14:11:42 -0600 Subject: [PATCH] fix(db): handle iteration errors --- db/posthooks.go | 8 ++++++++ db/project.go | 4 ++++ db/release.go | 4 ++++ db/users.go | 3 +++ 4 files changed, 19 insertions(+) diff --git a/db/posthooks.go b/db/posthooks.go index a25497f0f81bfcbbbc87fe8582d44dd53203adf8..5f8463f58c82e1a4490de7c64271ea7564d23b40 100644 --- a/db/posthooks.go +++ b/db/posthooks.go @@ -53,6 +53,10 @@ func generateAndInsertProjectIDs(tx *sql.Tx) error { return fmt.Errorf("failed to drop projects_tmp: %w", err) } + if err := rows.Err(); err != nil { + return fmt.Errorf("failed during row iteration for projects_tmp: %w", err) + } + return nil } @@ -85,5 +89,9 @@ func correctProjectIDs(tx *sql.Tx) error { } } + if err := rows.Err(); err != nil { + return fmt.Errorf("failed during row iteration for projects_tmp: %w", err) + } + return nil } diff --git a/db/project.go b/db/project.go index 6a5ed4a3baccd7c47ebca47a6791527d6eb0cd7d..80ec32c601f3cb8b4434bb5b97b4401f8922f4b7 100644 --- a/db/project.go +++ b/db/project.go @@ -6,6 +6,7 @@ package db import ( "database/sql" + "fmt" "sync" ) @@ -76,5 +77,8 @@ func GetProjects(db *sql.DB) ([]map[string]string, error) { } projects = append(projects, project) } + if err := rows.Err(); err != nil { + return nil, fmt.Errorf("failed during row iteration for projects: %w", err) + } return projects, nil } diff --git a/db/release.go b/db/release.go index 0fc909a9a01da4a526b2361853656e2b930778f8..c65c0e9d425db53d73c2f3449293734610b08015 100644 --- a/db/release.go +++ b/db/release.go @@ -6,6 +6,7 @@ package db import ( "database/sql" + "fmt" "sync" ) @@ -56,5 +57,8 @@ func GetReleases(db *sql.DB, projectID string) ([]map[string]string, error) { "date": date, }) } + if err := rows.Err(); err != nil { + return nil, fmt.Errorf("failed during row iteration for releases: %w", err) + } return releases, nil } diff --git a/db/users.go b/db/users.go index 48dad0fcbc39291edfec16d9ef1438aedcdb84f0..4fdff0b5dfad8829c08f3b2b1abe6fb7d4e12e4d 100644 --- a/db/users.go +++ b/db/users.go @@ -53,6 +53,9 @@ func GetUsers(db *sql.DB) ([]string, error) { users = append(users, user) } + if err := rows.Err(); err != nil { + return nil, err + } return users, nil }