From 1225bf7027f624ad7cc0624ebe44943bc410e781 Mon Sep 17 00:00:00 2001 From: Astro Date: Sun, 13 Jan 2019 21:05:19 +0100 Subject: [PATCH] prefix support DRY --- src/xmpp_codec.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/xmpp_codec.rs b/src/xmpp_codec.rs index 199627ba4ffedbd4983dda7451ae6e06e95c4747..69ab5fc23c82b43370d0408a0bb86ce2c0632f11 100644 --- a/src/xmpp_codec.rs +++ b/src/xmpp_codec.rs @@ -14,6 +14,7 @@ use std::io; use std::iter::FromIterator; use std::rc::Rc; use std::str::from_utf8; +use std::borrow::Cow; use tokio_codec::{Decoder, Encoder}; use xml5ever::interface::Attribute; use xml5ever::tokenizer::{Tag, TagKind, Token, TokenSink, XmlTokenizer}; @@ -104,11 +105,12 @@ impl ParserSink { "xmlns" => (), _ if is_prefix_xmlns(attr) => (), _ => { - if let Some(ref prefix) = attr.name.prefix { - el_builder = el_builder.attr(format!("{}:{}", prefix, attr.name.local), attr.value.as_ref()); + let attr_name = if let Some(ref prefix) = attr.name.prefix { + Cow::Owned(format!("{}:{}", prefix, attr.name.local)) } else { - el_builder = el_builder.attr(attr.name.local.as_ref(), attr.value.as_ref()); - } + Cow::Borrowed(attr.name.local.as_ref()) + }; + el_builder = el_builder.attr(attr_name, attr.value.as_ref()); } } }