data_forms: Remove unneccessary swallowing of an error.

Emmanuel Gil Peyrot created 8 years ago

Change summary

src/data_forms.rs | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Detailed changes

src/data_forms.rs

@@ -186,10 +186,8 @@ impl TryFrom<Element> for DataForm {
                             value: value,
                         });
                     } else if element.is("media", ns::MEDIA_ELEMENT) {
-                        match MediaElement::try_from(element.clone()) {
-                            Ok(media_element) => field.media.push(media_element),
-                            Err(_) => (), // TODO: is it really nice to swallow this error?
-                        }
+                        let media_element = MediaElement::try_from(element.clone())?;
+                        field.media.push(media_element);
                     } else {
                         return Err(Error::ParseError("Field child isn’t a value or media element."));
                     }