minidom: clippy

pep created 2 months ago

Signed-off-by: pep <[e-mail]>

Change summary

minidom/CHANGELOG.md        |  2 ++
minidom/src/element.rs      |  2 +-
minidom/src/tree_builder.rs | 10 +++-------
3 files changed, 6 insertions(+), 8 deletions(-)

Detailed changes

minidom/CHANGELOG.md

@@ -1,4 +1,6 @@
 Version NEXT:
+    * Changes
+        - Fix some Clippy warnings
 
 Version 0.18, released 2025-10-28:
   * Breaking:

minidom/src/element.rs

@@ -425,7 +425,7 @@ impl Element {
         writer.write(Item::ElementHeadStart(&namespace, (*self.name).try_into()?))?;
 
         for ((ns, key), value) in &self.attributes {
-            writer.write(Item::Attribute(&ns, key, value))?;
+            writer.write(Item::Attribute(ns, key, value))?;
         }
 
         if !self.children.is_empty() {

minidom/src/tree_builder.rs

@@ -85,7 +85,7 @@ impl TreeBuilder {
     /// Lookup XML namespace declaration for given prefix (or no prefix)
     #[must_use]
     fn lookup_prefix<'a>(
-        prefixes_stack: &'a Vec<Prefixes>,
+        prefixes_stack: &'a [Prefixes],
         prefix: &'a Option<String>,
     ) -> Option<&'a str> {
         for nss in prefixes_stack.iter().rev() {
@@ -149,11 +149,7 @@ impl TreeBuilder {
                                 .push((prefix.to_string(), name.to_string(), value));
                         }
                         (None, name) => {
-                            attrs.insert(
-                                Namespace::NONE,
-                                name.try_into().unwrap(),
-                                value.as_str().to_owned(),
-                            );
+                            attrs.insert(Namespace::NONE, name, value.as_str().to_owned());
                         }
                     }
                 }
@@ -179,7 +175,7 @@ impl TreeBuilder {
                                 &Some(prefix.to_string()),
                             )
                             .map(String::from)
-                            .map(|s| TryInto::<Namespace>::try_into(s).unwrap())
+                            .map(Into::<Namespace>::into)
                             .ok_or(Error::MissingNamespace)?
                             .to_owned()
                         };