CONTRIBUTING.md

  1# CONTRIBUTING
  2
  3Thanks for your interest in contributing to Zed, the collaborative platform that is also a code editor!
  4
  5## Contribution ideas
  6
  7If you already have an idea of what you'd like to contribute, you can skip this section, otherwise, here are a few resources to help you find something to work on:
  8
  9- Our public roadmap [include link] details what features we plan to add to Zed.
 10- Our [Top-Ranking Issues issue](https://github.com/zed-industries/community/issues/52) shows the most popular feature requests and issues, as voted on by the community.
 11
 12*If you are a plugin developer looking to contribute by building out the Zed ecosystem, have a look at these [issues](https://github.com/zed-industries/community/issues?q=is%3Aopen+is%3Aissue+label%3A%22potential+plugin%22+sort%3Areactions-%2B1-desc).*
 13
 14In the short term, we want to provide a generalized solutions to these problems (plugin system/theme system), so we are not looking to add these features to Zed itself.
 15
 16- Adding languages
 17- Themes
 18
 19## Resources
 20
 21### Bird-eye's view of Zed
 22
 23Zed is made up of several smaller crates - let's go over those you're most likely to interact with:
 24- [gpui](/crates/gpui) is a GPU-accelerated UI framework which provides all of the building blocks for Zed.
 25- [editor](/crates/editor) contains the core `Editor` type that drives both the code editor and all various input fields within Zed. It also handles a display layer for LSP features such as Inlay Hints or code completions.
 26- [project](/crates/project) manages files and navigation within the filetree. It is also Zed's side of communication with LSP.
 27- [workspace](/crates/workspace) handles local state serialization and groups projects together.
 28- [vim](/crates/vim) is a thin implementation of Vim workflow over `editor`.
 29- [lsp](/crates/lsp) handles communication with external LSP server.
 30- [language](/crates/language) drives `editor`'s understanding of language - from providing a list of symbols to the syntax map.
 31- [collab](/crates/collab) is the collaboration server itself, driving the collaboration features such as project sharing.
 32- [rpc](/crates/rpc) defines messages to be exchanged with collaboration server.
 33
 34// Let's try to make whoever we come into contact with for the first time
 35// well-equiped to discuss basic concepts around Zed
 36// Ideally these should link to mdbook/source code docs (doubtful given how source code docs might be more in-depth than necessary)
 37### Important concepts
 38
 39- Views vs Models
 40- Contexts
 41- Action
 42- UI
 43    - Render vs RenderOnce
 44    - ui crate
 45    - storybook
 46- Workspace
 47- Project
 48    - Worktree
 49- vim crate
 50    - Editor
 51        - Multibuffers
 52- Settings
 53
 54## Zed channels
 55
 56Once you have an idea of what you'd like to contribute, you'll want to communicate this to the team. If you're new to Zed's channels, here's a guide [link to up-to-date docs] to help bring you up to speed.
 57
 58[Since ~February 2022, the Zed Industries team has been exclusively using Zed to build Zed](https://x.com/nathansobo/status/1497958891509932035). We've built these tools to specifically address our own issues and frustrations with the current state of collaborative coding. These are not features we've built to simply look flashy, we work in channels every day of the workweek, aggressively dogfooding everything.
 59
 60![Staff usage of channels](./assets/screenshots/staff_usage_of_channels.png)
 61
 62*Channel metrics were not collected prior to August 2023*
 63
 64While we still have improvements to make, we believe we've sanded down a lot of the sharp edges and that the experience is both smooth and enjoyable - one that gets you as close to hypothetically sitting next to your teammates as possible, even if you're potentially on different sides of the globe. We want to continue working this way amongst ourselves and we are extremely excited to work with *you* in this way. We invite you to contribute to Zed *through* Zed.
 65
 66### Proposal & Discussion
 67
 68To do that, find a public channel [link to list of all public channels] that is relevant to your contribution, check the channel notes to see which Zed team members typically work in that channel, and post a message in the chat. If you're not sure which channel is best, you can post in the <whatever-general> channel. *Please wait to begin working on your contribution until you've received feedback from the team. Turning down a contribution that was not discussed beforehand is a bummer for everyone.*
 69
 70## Implementation & Help
 71
 72Once approved, feel free to begin working on your contribution. If you have any questions, you can post in the channel you originally proposed your contribution in, or you can post in the <whatever-general> channel. If you need help, reach out to a Zed teammate - we're happy to pair with you to help you learn the codebase and get your contribution merged.
 73
 74Reviewing code in a pull request, after the fact, is hard and tedious - the team generally likes to build trust and review code through pair programming. We'd prefer have conversations about the code, through Zed, while it is being written, so decisions can be made in real-time and less time is spent on fixing things after the fact. Ideally, GitHub is only used to merge code that has already been discussed and reviewed in Zed.
 75
 76--- Piotr's original contribution guide ---
 77
 78Read on if you're looking for an outline of your first contribution - from finding your way around the codebase and asking questions, through modifying and testing the changes, finishing off with submitting your changes for review and interacting with Zed core team and Zed community as a whole.
 79
 80### Getting in touch
 81We believe that journeys are best when shared - hence there are multiple outlets for Zed users and developers to share their success stories and hurdles.
 82
 83If you have questions, ask them away on our [Discord](https://discord.gg/XTtXmZYEpN) or in a dedicated [Zed channel](https://zed.dev/preview/channel/open-source-81). We also plan to organise office hours on a weekly basis - they will take place in forelinked Zed channel.
 84
 85All activity in Zed communities is subject to our [Code of Conduct](https://docs.zed.dev/community/code-of-conduct).
 86
 87
 88If you're just starting out with Zed, it might be worthwhile to look at some of the other crates that implement bits of UI - such as [go to line](/crates/go_to_line) modal that's bound to ctrl-g by default in Zed.
 89
 90### Upstreaming your changes
 91Here be dragons :)
 92---
 93Other things to mention here
 94- [ ] Etiquette
 95- [ ] CLA
 96- [ ] Importance of tests
 97- [ ] Look over Piotr's PR and pull in what this is missing (tour of the codebase, etc.)
 98    - See above
 99- [ ] Ask people to check the PRs to see if something has already been started on
100- [ ] Maybe have a channel that maps out what teammates / community users are working on what, so people can see what's being worked on
101- [ ] Mention Discord or keep it only focused on Zed channels?
102- [ ] Mention issue triage doc (https://github.com/zed-industries/community/blob/main/processes/issues_triage.md)?
103
104Things to do:
105- [ ] Put names devs who "own" each channel in the channel notes