1use anyhow::Result;
2use async_trait::async_trait;
3use language::{LanguageServerName, LspAdapter, LspAdapterDelegate};
4use lsp::LanguageServerBinary;
5use node_runtime::NodeRuntime;
6use project::ContextProviderWithTasks;
7use std::{
8 any::Any,
9 ffi::OsString,
10 path::{Path, PathBuf},
11 sync::Arc,
12};
13use task::{TaskTemplate, TaskTemplates, VariableName};
14use util::ResultExt;
15
16const SERVER_PATH: &str = "node_modules/pyright/langserver.index.js";
17
18fn server_binary_arguments(server_path: &Path) -> Vec<OsString> {
19 vec![server_path.into(), "--stdio".into()]
20}
21
22pub struct PythonLspAdapter {
23 node: Arc<dyn NodeRuntime>,
24}
25
26impl PythonLspAdapter {
27 pub fn new(node: Arc<dyn NodeRuntime>) -> Self {
28 PythonLspAdapter { node }
29 }
30}
31
32#[async_trait(?Send)]
33impl LspAdapter for PythonLspAdapter {
34 fn name(&self) -> LanguageServerName {
35 LanguageServerName("pyright".into())
36 }
37
38 async fn fetch_latest_server_version(
39 &self,
40 _: &dyn LspAdapterDelegate,
41 ) -> Result<Box<dyn 'static + Any + Send>> {
42 Ok(Box::new(self.node.npm_package_latest_version("pyright").await?) as Box<_>)
43 }
44
45 async fn fetch_server_binary(
46 &self,
47 latest_version: Box<dyn 'static + Send + Any>,
48 container_dir: PathBuf,
49 _: &dyn LspAdapterDelegate,
50 ) -> Result<LanguageServerBinary> {
51 let latest_version = latest_version.downcast::<String>().unwrap();
52 let server_path = container_dir.join(SERVER_PATH);
53 let package_name = "pyright";
54
55 let should_install_language_server = self
56 .node
57 .should_install_npm_package(package_name, &server_path, &container_dir, &latest_version)
58 .await;
59
60 if should_install_language_server {
61 self.node
62 .npm_install_packages(&container_dir, &[(package_name, latest_version.as_str())])
63 .await?;
64 }
65
66 Ok(LanguageServerBinary {
67 path: self.node.binary_path().await?,
68 env: None,
69 arguments: server_binary_arguments(&server_path),
70 })
71 }
72
73 async fn cached_server_binary(
74 &self,
75 container_dir: PathBuf,
76 _: &dyn LspAdapterDelegate,
77 ) -> Option<LanguageServerBinary> {
78 get_cached_server_binary(container_dir, &*self.node).await
79 }
80
81 async fn installation_test_binary(
82 &self,
83 container_dir: PathBuf,
84 ) -> Option<LanguageServerBinary> {
85 get_cached_server_binary(container_dir, &*self.node).await
86 }
87
88 async fn process_completions(&self, items: &mut [lsp::CompletionItem]) {
89 // Pyright assigns each completion item a `sortText` of the form `XX.YYYY.name`.
90 // Where `XX` is the sorting category, `YYYY` is based on most recent usage,
91 // and `name` is the symbol name itself.
92 //
93 // Because the symbol name is included, there generally are not ties when
94 // sorting by the `sortText`, so the symbol's fuzzy match score is not taken
95 // into account. Here, we remove the symbol name from the sortText in order
96 // to allow our own fuzzy score to be used to break ties.
97 //
98 // see https://github.com/microsoft/pyright/blob/95ef4e103b9b2f129c9320427e51b73ea7cf78bd/packages/pyright-internal/src/languageService/completionProvider.ts#LL2873
99 for item in items {
100 let Some(sort_text) = &mut item.sort_text else {
101 continue;
102 };
103 let mut parts = sort_text.split('.');
104 let Some(first) = parts.next() else { continue };
105 let Some(second) = parts.next() else { continue };
106 let Some(_) = parts.next() else { continue };
107 sort_text.replace_range(first.len() + second.len() + 1.., "");
108 }
109 }
110
111 async fn label_for_completion(
112 &self,
113 item: &lsp::CompletionItem,
114 language: &Arc<language::Language>,
115 ) -> Option<language::CodeLabel> {
116 let label = &item.label;
117 let grammar = language.grammar()?;
118 let highlight_id = match item.kind? {
119 lsp::CompletionItemKind::METHOD => grammar.highlight_id_for_name("function.method")?,
120 lsp::CompletionItemKind::FUNCTION => grammar.highlight_id_for_name("function")?,
121 lsp::CompletionItemKind::CLASS => grammar.highlight_id_for_name("type")?,
122 lsp::CompletionItemKind::CONSTANT => grammar.highlight_id_for_name("constant")?,
123 _ => return None,
124 };
125 Some(language::CodeLabel {
126 text: label.clone(),
127 runs: vec![(0..label.len(), highlight_id)],
128 filter_range: 0..label.len(),
129 })
130 }
131
132 async fn label_for_symbol(
133 &self,
134 name: &str,
135 kind: lsp::SymbolKind,
136 language: &Arc<language::Language>,
137 ) -> Option<language::CodeLabel> {
138 let (text, filter_range, display_range) = match kind {
139 lsp::SymbolKind::METHOD | lsp::SymbolKind::FUNCTION => {
140 let text = format!("def {}():\n", name);
141 let filter_range = 4..4 + name.len();
142 let display_range = 0..filter_range.end;
143 (text, filter_range, display_range)
144 }
145 lsp::SymbolKind::CLASS => {
146 let text = format!("class {}:", name);
147 let filter_range = 6..6 + name.len();
148 let display_range = 0..filter_range.end;
149 (text, filter_range, display_range)
150 }
151 lsp::SymbolKind::CONSTANT => {
152 let text = format!("{} = 0", name);
153 let filter_range = 0..name.len();
154 let display_range = 0..filter_range.end;
155 (text, filter_range, display_range)
156 }
157 _ => return None,
158 };
159
160 Some(language::CodeLabel {
161 runs: language.highlight_text(&text.as_str().into(), display_range.clone()),
162 text: text[display_range].to_string(),
163 filter_range,
164 })
165 }
166}
167
168async fn get_cached_server_binary(
169 container_dir: PathBuf,
170 node: &dyn NodeRuntime,
171) -> Option<LanguageServerBinary> {
172 let server_path = container_dir.join(SERVER_PATH);
173 if server_path.exists() {
174 Some(LanguageServerBinary {
175 path: node.binary_path().await.log_err()?,
176 env: None,
177 arguments: server_binary_arguments(&server_path),
178 })
179 } else {
180 log::error!("missing executable in directory {:?}", server_path);
181 None
182 }
183}
184
185pub(super) fn python_task_context() -> ContextProviderWithTasks {
186 ContextProviderWithTasks::new(TaskTemplates(vec![
187 TaskTemplate {
188 label: "execute selection".to_owned(),
189 command: "python3".to_owned(),
190 args: vec!["-c".to_owned(), VariableName::SelectedText.template_value()],
191 ..TaskTemplate::default()
192 },
193 TaskTemplate {
194 label: format!("run '{}'", VariableName::File.template_value()),
195 command: "python3".to_owned(),
196 args: vec![VariableName::File.template_value()],
197 ..TaskTemplate::default()
198 },
199 ]))
200}
201
202#[cfg(test)]
203mod tests {
204 use gpui::{BorrowAppContext, Context, ModelContext, TestAppContext};
205 use language::{language_settings::AllLanguageSettings, AutoindentMode, Buffer};
206 use settings::SettingsStore;
207 use std::num::NonZeroU32;
208
209 #[gpui::test]
210 async fn test_python_autoindent(cx: &mut TestAppContext) {
211 cx.executor().set_block_on_ticks(usize::MAX..=usize::MAX);
212 let language = crate::language("python", tree_sitter_python::language());
213 cx.update(|cx| {
214 let test_settings = SettingsStore::test(cx);
215 cx.set_global(test_settings);
216 language::init(cx);
217 cx.update_global::<SettingsStore, _>(|store, cx| {
218 store.update_user_settings::<AllLanguageSettings>(cx, |s| {
219 s.defaults.tab_size = NonZeroU32::new(2);
220 });
221 });
222 });
223
224 cx.new_model(|cx| {
225 let mut buffer = Buffer::local("", cx).with_language(language, cx);
226 let append = |buffer: &mut Buffer, text: &str, cx: &mut ModelContext<Buffer>| {
227 let ix = buffer.len();
228 buffer.edit([(ix..ix, text)], Some(AutoindentMode::EachLine), cx);
229 };
230
231 // indent after "def():"
232 append(&mut buffer, "def a():\n", cx);
233 assert_eq!(buffer.text(), "def a():\n ");
234
235 // preserve indent after blank line
236 append(&mut buffer, "\n ", cx);
237 assert_eq!(buffer.text(), "def a():\n \n ");
238
239 // indent after "if"
240 append(&mut buffer, "if a:\n ", cx);
241 assert_eq!(buffer.text(), "def a():\n \n if a:\n ");
242
243 // preserve indent after statement
244 append(&mut buffer, "b()\n", cx);
245 assert_eq!(buffer.text(), "def a():\n \n if a:\n b()\n ");
246
247 // preserve indent after statement
248 append(&mut buffer, "else", cx);
249 assert_eq!(buffer.text(), "def a():\n \n if a:\n b()\n else");
250
251 // dedent "else""
252 append(&mut buffer, ":", cx);
253 assert_eq!(buffer.text(), "def a():\n \n if a:\n b()\n else:");
254
255 // indent lines after else
256 append(&mut buffer, "\n", cx);
257 assert_eq!(
258 buffer.text(),
259 "def a():\n \n if a:\n b()\n else:\n "
260 );
261
262 // indent after an open paren. the closing paren is not indented
263 // because there is another token before it on the same line.
264 append(&mut buffer, "foo(\n1)", cx);
265 assert_eq!(
266 buffer.text(),
267 "def a():\n \n if a:\n b()\n else:\n foo(\n 1)"
268 );
269
270 // dedent the closing paren if it is shifted to the beginning of the line
271 let argument_ix = buffer.text().find('1').unwrap();
272 buffer.edit(
273 [(argument_ix..argument_ix + 1, "")],
274 Some(AutoindentMode::EachLine),
275 cx,
276 );
277 assert_eq!(
278 buffer.text(),
279 "def a():\n \n if a:\n b()\n else:\n foo(\n )"
280 );
281
282 // preserve indent after the close paren
283 append(&mut buffer, "\n", cx);
284 assert_eq!(
285 buffer.text(),
286 "def a():\n \n if a:\n b()\n else:\n foo(\n )\n "
287 );
288
289 // manually outdent the last line
290 let end_whitespace_ix = buffer.len() - 4;
291 buffer.edit(
292 [(end_whitespace_ix..buffer.len(), "")],
293 Some(AutoindentMode::EachLine),
294 cx,
295 );
296 assert_eq!(
297 buffer.text(),
298 "def a():\n \n if a:\n b()\n else:\n foo(\n )\n"
299 );
300
301 // preserve the newly reduced indentation on the next newline
302 append(&mut buffer, "\n", cx);
303 assert_eq!(
304 buffer.text(),
305 "def a():\n \n if a:\n b()\n else:\n foo(\n )\n\n"
306 );
307
308 // reset to a simple if statement
309 buffer.edit([(0..buffer.len(), "if a:\n b(\n )")], None, cx);
310
311 // dedent "else" on the line after a closing paren
312 append(&mut buffer, "\n else:\n", cx);
313 assert_eq!(buffer.text(), "if a:\n b(\n )\nelse:\n ");
314
315 buffer
316 });
317 }
318}