python.rs

  1use anyhow::Result;
  2use async_trait::async_trait;
  3use language::{ContextProviderWithTasks, LanguageServerName, LspAdapter, LspAdapterDelegate};
  4use lsp::LanguageServerBinary;
  5use node_runtime::NodeRuntime;
  6use std::{
  7    any::Any,
  8    ffi::OsString,
  9    path::{Path, PathBuf},
 10    sync::Arc,
 11};
 12use task::{TaskTemplate, TaskTemplates, VariableName};
 13use util::ResultExt;
 14
 15const SERVER_PATH: &str = "node_modules/pyright/langserver.index.js";
 16
 17fn server_binary_arguments(server_path: &Path) -> Vec<OsString> {
 18    vec![server_path.into(), "--stdio".into()]
 19}
 20
 21pub struct PythonLspAdapter {
 22    node: Arc<dyn NodeRuntime>,
 23}
 24
 25impl PythonLspAdapter {
 26    pub fn new(node: Arc<dyn NodeRuntime>) -> Self {
 27        PythonLspAdapter { node }
 28    }
 29}
 30
 31#[async_trait(?Send)]
 32impl LspAdapter for PythonLspAdapter {
 33    fn name(&self) -> LanguageServerName {
 34        LanguageServerName("pyright".into())
 35    }
 36
 37    async fn fetch_latest_server_version(
 38        &self,
 39        _: &dyn LspAdapterDelegate,
 40    ) -> Result<Box<dyn 'static + Any + Send>> {
 41        Ok(Box::new(self.node.npm_package_latest_version("pyright").await?) as Box<_>)
 42    }
 43
 44    async fn fetch_server_binary(
 45        &self,
 46        latest_version: Box<dyn 'static + Send + Any>,
 47        container_dir: PathBuf,
 48        _: &dyn LspAdapterDelegate,
 49    ) -> Result<LanguageServerBinary> {
 50        let latest_version = latest_version.downcast::<String>().unwrap();
 51        let server_path = container_dir.join(SERVER_PATH);
 52        let package_name = "pyright";
 53
 54        let should_install_language_server = self
 55            .node
 56            .should_install_npm_package(package_name, &server_path, &container_dir, &latest_version)
 57            .await;
 58
 59        if should_install_language_server {
 60            self.node
 61                .npm_install_packages(&container_dir, &[(package_name, latest_version.as_str())])
 62                .await?;
 63        }
 64
 65        Ok(LanguageServerBinary {
 66            path: self.node.binary_path().await?,
 67            env: None,
 68            arguments: server_binary_arguments(&server_path),
 69        })
 70    }
 71
 72    async fn cached_server_binary(
 73        &self,
 74        container_dir: PathBuf,
 75        _: &dyn LspAdapterDelegate,
 76    ) -> Option<LanguageServerBinary> {
 77        get_cached_server_binary(container_dir, &*self.node).await
 78    }
 79
 80    async fn installation_test_binary(
 81        &self,
 82        container_dir: PathBuf,
 83    ) -> Option<LanguageServerBinary> {
 84        get_cached_server_binary(container_dir, &*self.node).await
 85    }
 86
 87    async fn process_completions(&self, items: &mut [lsp::CompletionItem]) {
 88        // Pyright assigns each completion item a `sortText` of the form `XX.YYYY.name`.
 89        // Where `XX` is the sorting category, `YYYY` is based on most recent usage,
 90        // and `name` is the symbol name itself.
 91        //
 92        // Because the symbol name is included, there generally are not ties when
 93        // sorting by the `sortText`, so the symbol's fuzzy match score is not taken
 94        // into account. Here, we remove the symbol name from the sortText in order
 95        // to allow our own fuzzy score to be used to break ties.
 96        //
 97        // see https://github.com/microsoft/pyright/blob/95ef4e103b9b2f129c9320427e51b73ea7cf78bd/packages/pyright-internal/src/languageService/completionProvider.ts#LL2873
 98        for item in items {
 99            let Some(sort_text) = &mut item.sort_text else {
100                continue;
101            };
102            let mut parts = sort_text.split('.');
103            let Some(first) = parts.next() else { continue };
104            let Some(second) = parts.next() else { continue };
105            let Some(_) = parts.next() else { continue };
106            sort_text.replace_range(first.len() + second.len() + 1.., "");
107        }
108    }
109
110    async fn label_for_completion(
111        &self,
112        item: &lsp::CompletionItem,
113        language: &Arc<language::Language>,
114    ) -> Option<language::CodeLabel> {
115        let label = &item.label;
116        let grammar = language.grammar()?;
117        let highlight_id = match item.kind? {
118            lsp::CompletionItemKind::METHOD => grammar.highlight_id_for_name("function.method")?,
119            lsp::CompletionItemKind::FUNCTION => grammar.highlight_id_for_name("function")?,
120            lsp::CompletionItemKind::CLASS => grammar.highlight_id_for_name("type")?,
121            lsp::CompletionItemKind::CONSTANT => grammar.highlight_id_for_name("constant")?,
122            _ => return None,
123        };
124        Some(language::CodeLabel {
125            text: label.clone(),
126            runs: vec![(0..label.len(), highlight_id)],
127            filter_range: 0..label.len(),
128        })
129    }
130
131    async fn label_for_symbol(
132        &self,
133        name: &str,
134        kind: lsp::SymbolKind,
135        language: &Arc<language::Language>,
136    ) -> Option<language::CodeLabel> {
137        let (text, filter_range, display_range) = match kind {
138            lsp::SymbolKind::METHOD | lsp::SymbolKind::FUNCTION => {
139                let text = format!("def {}():\n", name);
140                let filter_range = 4..4 + name.len();
141                let display_range = 0..filter_range.end;
142                (text, filter_range, display_range)
143            }
144            lsp::SymbolKind::CLASS => {
145                let text = format!("class {}:", name);
146                let filter_range = 6..6 + name.len();
147                let display_range = 0..filter_range.end;
148                (text, filter_range, display_range)
149            }
150            lsp::SymbolKind::CONSTANT => {
151                let text = format!("{} = 0", name);
152                let filter_range = 0..name.len();
153                let display_range = 0..filter_range.end;
154                (text, filter_range, display_range)
155            }
156            _ => return None,
157        };
158
159        Some(language::CodeLabel {
160            runs: language.highlight_text(&text.as_str().into(), display_range.clone()),
161            text: text[display_range].to_string(),
162            filter_range,
163        })
164    }
165}
166
167async fn get_cached_server_binary(
168    container_dir: PathBuf,
169    node: &dyn NodeRuntime,
170) -> Option<LanguageServerBinary> {
171    let server_path = container_dir.join(SERVER_PATH);
172    if server_path.exists() {
173        Some(LanguageServerBinary {
174            path: node.binary_path().await.log_err()?,
175            env: None,
176            arguments: server_binary_arguments(&server_path),
177        })
178    } else {
179        log::error!("missing executable in directory {:?}", server_path);
180        None
181    }
182}
183
184pub(super) fn python_task_context() -> ContextProviderWithTasks {
185    ContextProviderWithTasks::new(TaskTemplates(vec![
186        TaskTemplate {
187            label: "execute selection".to_owned(),
188            command: "python3".to_owned(),
189            args: vec![
190                "-c".to_owned(),
191                format!(
192                    "exec(r'''{}''')",
193                    VariableName::SelectedText.template_value()
194                ),
195            ],
196            ignore_previously_resolved: true,
197            ..TaskTemplate::default()
198        },
199        TaskTemplate {
200            label: format!("run '{}'", VariableName::File.template_value()),
201            command: "python3".to_owned(),
202            args: vec![VariableName::File.template_value()],
203            ..TaskTemplate::default()
204        },
205    ]))
206}
207
208#[cfg(test)]
209mod tests {
210    use gpui::{BorrowAppContext, Context, ModelContext, TestAppContext};
211    use language::{language_settings::AllLanguageSettings, AutoindentMode, Buffer};
212    use settings::SettingsStore;
213    use std::num::NonZeroU32;
214
215    #[gpui::test]
216    async fn test_python_autoindent(cx: &mut TestAppContext) {
217        cx.executor().set_block_on_ticks(usize::MAX..=usize::MAX);
218        let language = crate::language("python", tree_sitter_python::language());
219        cx.update(|cx| {
220            let test_settings = SettingsStore::test(cx);
221            cx.set_global(test_settings);
222            language::init(cx);
223            cx.update_global::<SettingsStore, _>(|store, cx| {
224                store.update_user_settings::<AllLanguageSettings>(cx, |s| {
225                    s.defaults.tab_size = NonZeroU32::new(2);
226                });
227            });
228        });
229
230        cx.new_model(|cx| {
231            let mut buffer = Buffer::local("", cx).with_language(language, cx);
232            let append = |buffer: &mut Buffer, text: &str, cx: &mut ModelContext<Buffer>| {
233                let ix = buffer.len();
234                buffer.edit([(ix..ix, text)], Some(AutoindentMode::EachLine), cx);
235            };
236
237            // indent after "def():"
238            append(&mut buffer, "def a():\n", cx);
239            assert_eq!(buffer.text(), "def a():\n  ");
240
241            // preserve indent after blank line
242            append(&mut buffer, "\n  ", cx);
243            assert_eq!(buffer.text(), "def a():\n  \n  ");
244
245            // indent after "if"
246            append(&mut buffer, "if a:\n  ", cx);
247            assert_eq!(buffer.text(), "def a():\n  \n  if a:\n    ");
248
249            // preserve indent after statement
250            append(&mut buffer, "b()\n", cx);
251            assert_eq!(buffer.text(), "def a():\n  \n  if a:\n    b()\n    ");
252
253            // preserve indent after statement
254            append(&mut buffer, "else", cx);
255            assert_eq!(buffer.text(), "def a():\n  \n  if a:\n    b()\n    else");
256
257            // dedent "else""
258            append(&mut buffer, ":", cx);
259            assert_eq!(buffer.text(), "def a():\n  \n  if a:\n    b()\n  else:");
260
261            // indent lines after else
262            append(&mut buffer, "\n", cx);
263            assert_eq!(
264                buffer.text(),
265                "def a():\n  \n  if a:\n    b()\n  else:\n    "
266            );
267
268            // indent after an open paren. the closing  paren is not indented
269            // because there is another token before it on the same line.
270            append(&mut buffer, "foo(\n1)", cx);
271            assert_eq!(
272                buffer.text(),
273                "def a():\n  \n  if a:\n    b()\n  else:\n    foo(\n      1)"
274            );
275
276            // dedent the closing paren if it is shifted to the beginning of the line
277            let argument_ix = buffer.text().find('1').unwrap();
278            buffer.edit(
279                [(argument_ix..argument_ix + 1, "")],
280                Some(AutoindentMode::EachLine),
281                cx,
282            );
283            assert_eq!(
284                buffer.text(),
285                "def a():\n  \n  if a:\n    b()\n  else:\n    foo(\n    )"
286            );
287
288            // preserve indent after the close paren
289            append(&mut buffer, "\n", cx);
290            assert_eq!(
291                buffer.text(),
292                "def a():\n  \n  if a:\n    b()\n  else:\n    foo(\n    )\n    "
293            );
294
295            // manually outdent the last line
296            let end_whitespace_ix = buffer.len() - 4;
297            buffer.edit(
298                [(end_whitespace_ix..buffer.len(), "")],
299                Some(AutoindentMode::EachLine),
300                cx,
301            );
302            assert_eq!(
303                buffer.text(),
304                "def a():\n  \n  if a:\n    b()\n  else:\n    foo(\n    )\n"
305            );
306
307            // preserve the newly reduced indentation on the next newline
308            append(&mut buffer, "\n", cx);
309            assert_eq!(
310                buffer.text(),
311                "def a():\n  \n  if a:\n    b()\n  else:\n    foo(\n    )\n\n"
312            );
313
314            // reset to a simple if statement
315            buffer.edit([(0..buffer.len(), "if a:\n  b(\n  )")], None, cx);
316
317            // dedent "else" on the line after a closing paren
318            append(&mut buffer, "\n  else:\n", cx);
319            assert_eq!(buffer.text(), "if a:\n  b(\n  )\nelse:\n  ");
320
321            buffer
322        });
323    }
324}