1use anyhow::{Context as _, Result};
2use collections::{BTreeMap, HashMap, IndexMap};
3use fs::Fs;
4use gpui::{
5 Action, ActionBuildError, App, InvalidKeystrokeError, KEYSTROKE_PARSE_EXPECTED_MESSAGE,
6 KeyBinding, KeyBindingContextPredicate, KeyBindingMetaIndex, Keystroke, NoAction, SharedString,
7};
8use schemars::{JsonSchema, json_schema};
9use serde::Deserialize;
10use serde_json::{Value, json};
11use std::borrow::Cow;
12use std::{any::TypeId, fmt::Write, rc::Rc, sync::Arc, sync::LazyLock};
13use util::ResultExt as _;
14use util::{
15 asset_str,
16 markdown::{MarkdownEscaped, MarkdownInlineCode, MarkdownString},
17};
18
19use crate::{
20 SettingsAssets, append_top_level_array_value_in_json_text, parse_json_with_comments,
21 replace_top_level_array_value_in_json_text,
22};
23
24pub trait KeyBindingValidator: Send + Sync {
25 fn action_type_id(&self) -> TypeId;
26 fn validate(&self, binding: &KeyBinding) -> Result<(), MarkdownString>;
27}
28
29pub struct KeyBindingValidatorRegistration(pub fn() -> Box<dyn KeyBindingValidator>);
30
31inventory::collect!(KeyBindingValidatorRegistration);
32
33pub(crate) static KEY_BINDING_VALIDATORS: LazyLock<BTreeMap<TypeId, Box<dyn KeyBindingValidator>>> =
34 LazyLock::new(|| {
35 let mut validators = BTreeMap::new();
36 for validator_registration in inventory::iter::<KeyBindingValidatorRegistration> {
37 let validator = validator_registration.0();
38 validators.insert(validator.action_type_id(), validator);
39 }
40 validators
41 });
42
43// Note that the doc comments on these are shown by json-language-server when editing the keymap, so
44// they should be considered user-facing documentation. Documentation is not handled well with
45// schemars-0.8 - when there are newlines, it is rendered as plaintext (see
46// https://github.com/GREsau/schemars/issues/38#issuecomment-2282883519). So for now these docs
47// avoid newlines.
48//
49// TODO: Update to schemars-1.0 once it's released, and add more docs as newlines would be
50// supported. Tracking issue is https://github.com/GREsau/schemars/issues/112.
51
52/// Keymap configuration consisting of sections. Each section may have a context predicate which
53/// determines whether its bindings are used.
54#[derive(Debug, Deserialize, Default, Clone, JsonSchema)]
55#[serde(transparent)]
56pub struct KeymapFile(Vec<KeymapSection>);
57
58/// Keymap section which binds keystrokes to actions.
59#[derive(Debug, Deserialize, Default, Clone, JsonSchema)]
60pub struct KeymapSection {
61 /// Determines when these bindings are active. When just a name is provided, like `Editor` or
62 /// `Workspace`, the bindings will be active in that context. Boolean expressions like `X && Y`,
63 /// `X || Y`, `!X` are also supported. Some more complex logic including checking OS and the
64 /// current file extension are also supported - see [the
65 /// documentation](https://zed.dev/docs/key-bindings#contexts) for more details.
66 #[serde(default)]
67 pub context: String,
68 /// This option enables specifying keys based on their position on a QWERTY keyboard, by using
69 /// position-equivalent mappings for some non-QWERTY keyboards. This is currently only supported
70 /// on macOS. See the documentation for more details.
71 #[serde(default)]
72 use_key_equivalents: bool,
73 /// This keymap section's bindings, as a JSON object mapping keystrokes to actions. The
74 /// keystrokes key is a string representing a sequence of keystrokes to type, where the
75 /// keystrokes are separated by whitespace. Each keystroke is a sequence of modifiers (`ctrl`,
76 /// `alt`, `shift`, `fn`, `cmd`, `super`, or `win`) followed by a key, separated by `-`. The
77 /// order of bindings does matter. When the same keystrokes are bound at the same context depth,
78 /// the binding that occurs later in the file is preferred. For displaying keystrokes in the UI,
79 /// the later binding for the same action is preferred.
80 #[serde(default)]
81 bindings: Option<IndexMap<String, KeymapAction>>,
82 #[serde(flatten)]
83 unrecognized_fields: IndexMap<String, Value>,
84 // This struct intentionally uses permissive types for its fields, rather than validating during
85 // deserialization. The purpose of this is to allow loading the portion of the keymap that doesn't
86 // have errors. The downside of this is that the errors are not reported with line+column info.
87 // Unfortunately the implementations of the `Spanned` types for preserving this information are
88 // highly inconvenient (`serde_spanned`) and in some cases don't work at all here
89 // (`json_spanned_>value`). Serde should really have builtin support for this.
90}
91
92impl KeymapSection {
93 pub fn bindings(&self) -> impl DoubleEndedIterator<Item = (&String, &KeymapAction)> {
94 self.bindings.iter().flatten()
95 }
96}
97
98/// Keymap action as a JSON value, since it can either be null for no action, or the name of the
99/// action, or an array of the name of the action and the action input.
100///
101/// Unlike the other json types involved in keymaps (including actions), this doc-comment will not
102/// be included in the generated JSON schema, as it manually defines its `JsonSchema` impl. The
103/// actual schema used for it is automatically generated in `KeymapFile::generate_json_schema`.
104#[derive(Debug, Deserialize, Default, Clone)]
105#[serde(transparent)]
106pub struct KeymapAction(Value);
107
108impl std::fmt::Display for KeymapAction {
109 fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
110 match &self.0 {
111 Value::String(s) => write!(f, "{}", s),
112 Value::Array(arr) => {
113 let strings: Vec<String> = arr.iter().map(|v| v.to_string()).collect();
114 write!(f, "{}", strings.join(", "))
115 }
116 _ => write!(f, "{}", self.0),
117 }
118 }
119}
120
121impl JsonSchema for KeymapAction {
122 /// This is used when generating the JSON schema for the `KeymapAction` type, so that it can
123 /// reference the keymap action schema.
124 fn schema_name() -> Cow<'static, str> {
125 "KeymapAction".into()
126 }
127
128 /// This schema will be replaced with the full action schema in
129 /// `KeymapFile::generate_json_schema`.
130 fn json_schema(_: &mut schemars::SchemaGenerator) -> schemars::Schema {
131 json_schema!(true)
132 }
133}
134
135#[derive(Debug)]
136#[must_use]
137pub enum KeymapFileLoadResult {
138 Success {
139 key_bindings: Vec<KeyBinding>,
140 },
141 SomeFailedToLoad {
142 key_bindings: Vec<KeyBinding>,
143 error_message: MarkdownString,
144 },
145 JsonParseFailure {
146 error: anyhow::Error,
147 },
148}
149
150impl KeymapFile {
151 pub fn parse(content: &str) -> anyhow::Result<Self> {
152 parse_json_with_comments::<Self>(content)
153 }
154
155 pub fn load_asset(
156 asset_path: &str,
157 source: Option<KeybindSource>,
158 cx: &App,
159 ) -> anyhow::Result<Vec<KeyBinding>> {
160 match Self::load(asset_str::<SettingsAssets>(asset_path).as_ref(), cx) {
161 KeymapFileLoadResult::Success { mut key_bindings } => match source {
162 Some(source) => Ok({
163 for key_binding in &mut key_bindings {
164 key_binding.set_meta(source.meta());
165 }
166 key_bindings
167 }),
168 None => Ok(key_bindings),
169 },
170 KeymapFileLoadResult::SomeFailedToLoad { error_message, .. } => {
171 anyhow::bail!("Error loading built-in keymap \"{asset_path}\": {error_message}",)
172 }
173 KeymapFileLoadResult::JsonParseFailure { error } => {
174 anyhow::bail!("JSON parse error in built-in keymap \"{asset_path}\": {error}")
175 }
176 }
177 }
178
179 #[cfg(feature = "test-support")]
180 pub fn load_asset_allow_partial_failure(
181 asset_path: &str,
182 cx: &App,
183 ) -> anyhow::Result<Vec<KeyBinding>> {
184 match Self::load(asset_str::<SettingsAssets>(asset_path).as_ref(), cx) {
185 KeymapFileLoadResult::SomeFailedToLoad {
186 key_bindings,
187 error_message,
188 ..
189 } if key_bindings.is_empty() => {
190 anyhow::bail!("Error loading built-in keymap \"{asset_path}\": {error_message}",)
191 }
192 KeymapFileLoadResult::Success { key_bindings, .. }
193 | KeymapFileLoadResult::SomeFailedToLoad { key_bindings, .. } => Ok(key_bindings),
194 KeymapFileLoadResult::JsonParseFailure { error } => {
195 anyhow::bail!("JSON parse error in built-in keymap \"{asset_path}\": {error}")
196 }
197 }
198 }
199
200 #[cfg(feature = "test-support")]
201 pub fn load_panic_on_failure(content: &str, cx: &App) -> Vec<KeyBinding> {
202 match Self::load(content, cx) {
203 KeymapFileLoadResult::Success { key_bindings, .. } => key_bindings,
204 KeymapFileLoadResult::SomeFailedToLoad { error_message, .. } => {
205 panic!("{error_message}");
206 }
207 KeymapFileLoadResult::JsonParseFailure { error } => {
208 panic!("JSON parse error: {error}");
209 }
210 }
211 }
212
213 pub fn load(content: &str, cx: &App) -> KeymapFileLoadResult {
214 let key_equivalents =
215 crate::key_equivalents::get_key_equivalents(cx.keyboard_layout().id());
216
217 if content.is_empty() {
218 return KeymapFileLoadResult::Success {
219 key_bindings: Vec::new(),
220 };
221 }
222 let keymap_file = match Self::parse(content) {
223 Ok(keymap_file) => keymap_file,
224 Err(error) => {
225 return KeymapFileLoadResult::JsonParseFailure { error };
226 }
227 };
228
229 // Accumulate errors in order to support partial load of user keymap in the presence of
230 // errors in context and binding parsing.
231 let mut errors = Vec::new();
232 let mut key_bindings = Vec::new();
233
234 for KeymapSection {
235 context,
236 use_key_equivalents,
237 bindings,
238 unrecognized_fields,
239 } in keymap_file.0.iter()
240 {
241 let context_predicate: Option<Rc<KeyBindingContextPredicate>> = if context.is_empty() {
242 None
243 } else {
244 match KeyBindingContextPredicate::parse(context) {
245 Ok(context_predicate) => Some(context_predicate.into()),
246 Err(err) => {
247 // Leading space is to separate from the message indicating which section
248 // the error occurred in.
249 errors.push((
250 context,
251 format!(" Parse error in section `context` field: {}", err),
252 ));
253 continue;
254 }
255 }
256 };
257
258 let key_equivalents = if *use_key_equivalents {
259 key_equivalents.as_ref()
260 } else {
261 None
262 };
263
264 let mut section_errors = String::new();
265
266 if !unrecognized_fields.is_empty() {
267 write!(
268 section_errors,
269 "\n\n - Unrecognized fields: {}",
270 MarkdownInlineCode(&format!("{:?}", unrecognized_fields.keys()))
271 )
272 .unwrap();
273 }
274
275 if let Some(bindings) = bindings {
276 for (keystrokes, action) in bindings {
277 let result = Self::load_keybinding(
278 keystrokes,
279 action,
280 context_predicate.clone(),
281 key_equivalents,
282 cx,
283 );
284 match result {
285 Ok(key_binding) => {
286 key_bindings.push(key_binding);
287 }
288 Err(err) => {
289 let mut lines = err.lines();
290 let mut indented_err = lines.next().unwrap().to_string();
291 for line in lines {
292 indented_err.push_str(" ");
293 indented_err.push_str(line);
294 indented_err.push_str("\n");
295 }
296 write!(
297 section_errors,
298 "\n\n- In binding {}, {indented_err}",
299 MarkdownInlineCode(&format!("\"{}\"", keystrokes))
300 )
301 .unwrap();
302 }
303 }
304 }
305 }
306
307 if !section_errors.is_empty() {
308 errors.push((context, section_errors))
309 }
310 }
311
312 if errors.is_empty() {
313 KeymapFileLoadResult::Success { key_bindings }
314 } else {
315 let mut error_message = "Errors in user keymap file.\n".to_owned();
316 for (context, section_errors) in errors {
317 if context.is_empty() {
318 let _ = write!(error_message, "\n\nIn section without context predicate:");
319 } else {
320 let _ = write!(
321 error_message,
322 "\n\nIn section with {}:",
323 MarkdownInlineCode(&format!("context = \"{}\"", context))
324 );
325 }
326 let _ = write!(error_message, "{section_errors}");
327 }
328 KeymapFileLoadResult::SomeFailedToLoad {
329 key_bindings,
330 error_message: MarkdownString(error_message),
331 }
332 }
333 }
334
335 fn load_keybinding(
336 keystrokes: &str,
337 action: &KeymapAction,
338 context: Option<Rc<KeyBindingContextPredicate>>,
339 key_equivalents: Option<&HashMap<char, char>>,
340 cx: &App,
341 ) -> std::result::Result<KeyBinding, String> {
342 let (build_result, action_input_string) = match &action.0 {
343 Value::Array(items) => {
344 if items.len() != 2 {
345 return Err(format!(
346 "expected two-element array of `[name, input]`. \
347 Instead found {}.",
348 MarkdownInlineCode(&action.0.to_string())
349 ));
350 }
351 let serde_json::Value::String(ref name) = items[0] else {
352 return Err(format!(
353 "expected two-element array of `[name, input]`, \
354 but the first element is not a string in {}.",
355 MarkdownInlineCode(&action.0.to_string())
356 ));
357 };
358 let action_input = items[1].clone();
359 let action_input_string = action_input.to_string();
360 (
361 cx.build_action(&name, Some(action_input)),
362 Some(action_input_string),
363 )
364 }
365 Value::String(name) => (cx.build_action(&name, None), None),
366 Value::Null => (Ok(NoAction.boxed_clone()), None),
367 _ => {
368 return Err(format!(
369 "expected two-element array of `[name, input]`. \
370 Instead found {}.",
371 MarkdownInlineCode(&action.0.to_string())
372 ));
373 }
374 };
375
376 let action = match build_result {
377 Ok(action) => action,
378 Err(ActionBuildError::NotFound { name }) => {
379 return Err(format!(
380 "didn't find an action named {}.",
381 MarkdownInlineCode(&format!("\"{}\"", &name))
382 ));
383 }
384 Err(ActionBuildError::BuildError { name, error }) => match action_input_string {
385 Some(action_input_string) => {
386 return Err(format!(
387 "can't build {} action from input value {}: {}",
388 MarkdownInlineCode(&format!("\"{}\"", &name)),
389 MarkdownInlineCode(&action_input_string),
390 MarkdownEscaped(&error.to_string())
391 ));
392 }
393 None => {
394 return Err(format!(
395 "can't build {} action - it requires input data via [name, input]: {}",
396 MarkdownInlineCode(&format!("\"{}\"", &name)),
397 MarkdownEscaped(&error.to_string())
398 ));
399 }
400 },
401 };
402
403 let key_binding = match KeyBinding::load(
404 keystrokes,
405 action,
406 context,
407 key_equivalents,
408 action_input_string.map(SharedString::from),
409 ) {
410 Ok(key_binding) => key_binding,
411 Err(InvalidKeystrokeError { keystroke }) => {
412 return Err(format!(
413 "invalid keystroke {}. {}",
414 MarkdownInlineCode(&format!("\"{}\"", &keystroke)),
415 KEYSTROKE_PARSE_EXPECTED_MESSAGE
416 ));
417 }
418 };
419
420 if let Some(validator) = KEY_BINDING_VALIDATORS.get(&key_binding.action().type_id()) {
421 match validator.validate(&key_binding) {
422 Ok(()) => Ok(key_binding),
423 Err(error) => Err(error.0),
424 }
425 } else {
426 Ok(key_binding)
427 }
428 }
429
430 /// Creates a JSON schema generator, suitable for generating json schemas
431 /// for actions
432 pub fn action_schema_generator() -> schemars::SchemaGenerator {
433 schemars::generate::SchemaSettings::draft2019_09().into_generator()
434 }
435
436 pub fn generate_json_schema_for_registered_actions(cx: &mut App) -> Value {
437 // instead of using DefaultDenyUnknownFields, actions typically use
438 // `#[serde(deny_unknown_fields)]` so that these cases are reported as parse failures. This
439 // is because the rest of the keymap will still load in these cases, whereas other settings
440 // files would not.
441 let mut generator = Self::action_schema_generator();
442
443 let action_schemas = cx.action_schemas(&mut generator);
444 let deprecations = cx.deprecated_actions_to_preferred_actions();
445 let deprecation_messages = cx.action_deprecation_messages();
446 KeymapFile::generate_json_schema(
447 generator,
448 action_schemas,
449 deprecations,
450 deprecation_messages,
451 )
452 }
453
454 fn generate_json_schema(
455 mut generator: schemars::SchemaGenerator,
456 action_schemas: Vec<(&'static str, Option<schemars::Schema>)>,
457 deprecations: &HashMap<&'static str, &'static str>,
458 deprecation_messages: &HashMap<&'static str, &'static str>,
459 ) -> serde_json::Value {
460 fn add_deprecation(schema: &mut schemars::Schema, message: String) {
461 schema.insert(
462 // deprecationMessage is not part of the JSON Schema spec, but
463 // json-language-server recognizes it.
464 "deprecationMessage".to_string(),
465 Value::String(message),
466 );
467 }
468
469 fn add_deprecation_preferred_name(schema: &mut schemars::Schema, new_name: &str) {
470 add_deprecation(schema, format!("Deprecated, use {new_name}"));
471 }
472
473 fn add_description(schema: &mut schemars::Schema, description: String) {
474 schema.insert("description".to_string(), Value::String(description));
475 }
476
477 let empty_object = json_schema!({
478 "type": "object"
479 });
480
481 // This is a workaround for a json-language-server issue where it matches the first
482 // alternative that matches the value's shape and uses that for documentation.
483 //
484 // In the case of the array validations, it would even provide an error saying that the name
485 // must match the name of the first alternative.
486 let mut plain_action = json_schema!({
487 "type": "string",
488 "const": ""
489 });
490 let no_action_message = "No action named this.";
491 add_description(&mut plain_action, no_action_message.to_owned());
492 add_deprecation(&mut plain_action, no_action_message.to_owned());
493
494 let mut matches_action_name = json_schema!({
495 "const": ""
496 });
497 let no_action_message_input = "No action named this that takes input.";
498 add_description(&mut matches_action_name, no_action_message_input.to_owned());
499 add_deprecation(&mut matches_action_name, no_action_message_input.to_owned());
500
501 let action_with_input = json_schema!({
502 "type": "array",
503 "items": [
504 matches_action_name,
505 true
506 ],
507 "minItems": 2,
508 "maxItems": 2
509 });
510 let mut keymap_action_alternatives = vec![plain_action, action_with_input];
511
512 for (name, action_schema) in action_schemas.into_iter() {
513 let description = action_schema.as_ref().and_then(|schema| {
514 schema
515 .as_object()
516 .and_then(|obj| obj.get("description"))
517 .and_then(|v| v.as_str())
518 .map(|s| s.to_string())
519 });
520
521 let deprecation = if name == NoAction.name() {
522 Some("null")
523 } else {
524 deprecations.get(name).copied()
525 };
526
527 // Add an alternative for plain action names.
528 let mut plain_action = json_schema!({
529 "type": "string",
530 "const": name
531 });
532 if let Some(message) = deprecation_messages.get(name) {
533 add_deprecation(&mut plain_action, message.to_string());
534 } else if let Some(new_name) = deprecation {
535 add_deprecation_preferred_name(&mut plain_action, new_name);
536 }
537 if let Some(desc) = description.clone() {
538 add_description(&mut plain_action, desc);
539 }
540 keymap_action_alternatives.push(plain_action);
541
542 // Add an alternative for actions with data specified as a [name, data] array.
543 //
544 // When a struct with no deserializable fields is added by deriving `Action`, an empty
545 // object schema is produced. The action should be invoked without data in this case.
546 if let Some(schema) = action_schema {
547 if schema != empty_object {
548 let mut matches_action_name = json_schema!({
549 "const": name
550 });
551 if let Some(desc) = description.clone() {
552 add_description(&mut matches_action_name, desc);
553 }
554 if let Some(message) = deprecation_messages.get(name) {
555 add_deprecation(&mut matches_action_name, message.to_string());
556 } else if let Some(new_name) = deprecation {
557 add_deprecation_preferred_name(&mut matches_action_name, new_name);
558 }
559 let action_with_input = json_schema!({
560 "type": "array",
561 "items": [matches_action_name, schema],
562 "minItems": 2,
563 "maxItems": 2
564 });
565 keymap_action_alternatives.push(action_with_input);
566 }
567 }
568 }
569
570 // Placing null first causes json-language-server to default assuming actions should be
571 // null, so place it last.
572 keymap_action_alternatives.push(json_schema!({
573 "type": "null"
574 }));
575
576 // The `KeymapSection` schema will reference the `KeymapAction` schema by name, so setting
577 // the definition of `KeymapAction` results in the full action schema being used.
578 generator.definitions_mut().insert(
579 KeymapAction::schema_name().to_string(),
580 json!({
581 "oneOf": keymap_action_alternatives
582 }),
583 );
584
585 generator.root_schema_for::<KeymapFile>().to_value()
586 }
587
588 pub fn sections(&self) -> impl DoubleEndedIterator<Item = &KeymapSection> {
589 self.0.iter()
590 }
591
592 pub async fn load_keymap_file(fs: &Arc<dyn Fs>) -> Result<String> {
593 match fs.load(paths::keymap_file()).await {
594 result @ Ok(_) => result,
595 Err(err) => {
596 if let Some(e) = err.downcast_ref::<std::io::Error>() {
597 if e.kind() == std::io::ErrorKind::NotFound {
598 return Ok(crate::initial_keymap_content().to_string());
599 }
600 }
601 Err(err)
602 }
603 }
604 }
605
606 pub fn update_keybinding<'a>(
607 mut operation: KeybindUpdateOperation<'a>,
608 mut keymap_contents: String,
609 tab_size: usize,
610 ) -> Result<String> {
611 match operation {
612 // if trying to replace a keybinding that is not user-defined, treat it as an add operation
613 KeybindUpdateOperation::Replace {
614 target_keybind_source: target_source,
615 source,
616 target,
617 } if target_source != KeybindSource::User => {
618 operation = KeybindUpdateOperation::Add {
619 source,
620 from: Some(target),
621 };
622 }
623 // if trying to remove a keybinding that is not user-defined, treat it as creating a binding
624 // that binds it to `zed::NoAction`
625 KeybindUpdateOperation::Remove {
626 target,
627 target_keybind_source,
628 } if target_keybind_source != KeybindSource::User => {
629 let mut source = target.clone();
630 source.action_name = gpui::NoAction.name();
631 source.action_arguments.take();
632 operation = KeybindUpdateOperation::Add {
633 source,
634 from: Some(target),
635 };
636 }
637 _ => {}
638 }
639
640 // Sanity check that keymap contents are valid, even though we only use it for Replace.
641 // We don't want to modify the file if it's invalid.
642 let keymap = Self::parse(&keymap_contents).context("Failed to parse keymap")?;
643
644 if let KeybindUpdateOperation::Remove { target, .. } = operation {
645 let target_action_value = target
646 .action_value()
647 .context("Failed to generate target action JSON value")?;
648 let Some((index, keystrokes_str)) =
649 find_binding(&keymap, &target, &target_action_value)
650 else {
651 anyhow::bail!("Failed to find keybinding to remove");
652 };
653 let is_only_binding = keymap.0[index]
654 .bindings
655 .as_ref()
656 .map_or(true, |bindings| bindings.len() == 1);
657 let key_path: &[&str] = if is_only_binding {
658 &[]
659 } else {
660 &["bindings", keystrokes_str]
661 };
662 let (replace_range, replace_value) = replace_top_level_array_value_in_json_text(
663 &keymap_contents,
664 key_path,
665 None,
666 None,
667 index,
668 tab_size,
669 )
670 .context("Failed to remove keybinding")?;
671 keymap_contents.replace_range(replace_range, &replace_value);
672 return Ok(keymap_contents);
673 }
674
675 if let KeybindUpdateOperation::Replace { source, target, .. } = operation {
676 let target_action_value = target
677 .action_value()
678 .context("Failed to generate target action JSON value")?;
679 let source_action_value = source
680 .action_value()
681 .context("Failed to generate source action JSON value")?;
682
683 if let Some((index, keystrokes_str)) =
684 find_binding(&keymap, &target, &target_action_value)
685 {
686 if target.context == source.context {
687 // if we are only changing the keybinding (common case)
688 // not the context, etc. Then just update the binding in place
689
690 let (replace_range, replace_value) =
691 replace_top_level_array_value_in_json_text(
692 &keymap_contents,
693 &["bindings", keystrokes_str],
694 Some(&source_action_value),
695 Some(&source.keystrokes_unparsed()),
696 index,
697 tab_size,
698 )
699 .context("Failed to replace keybinding")?;
700 keymap_contents.replace_range(replace_range, &replace_value);
701
702 return Ok(keymap_contents);
703 } else if keymap.0[index]
704 .bindings
705 .as_ref()
706 .map_or(true, |bindings| bindings.len() == 1)
707 {
708 // if we are replacing the only binding in the section,
709 // just update the section in place, updating the context
710 // and the binding
711
712 let (replace_range, replace_value) =
713 replace_top_level_array_value_in_json_text(
714 &keymap_contents,
715 &["bindings", keystrokes_str],
716 Some(&source_action_value),
717 Some(&source.keystrokes_unparsed()),
718 index,
719 tab_size,
720 )
721 .context("Failed to replace keybinding")?;
722 keymap_contents.replace_range(replace_range, &replace_value);
723
724 let (replace_range, replace_value) =
725 replace_top_level_array_value_in_json_text(
726 &keymap_contents,
727 &["context"],
728 source.context.map(Into::into).as_ref(),
729 None,
730 index,
731 tab_size,
732 )
733 .context("Failed to replace keybinding")?;
734 keymap_contents.replace_range(replace_range, &replace_value);
735 return Ok(keymap_contents);
736 } else {
737 // if we are replacing one of multiple bindings in a section
738 // with a context change, remove the existing binding from the
739 // section, then treat this operation as an add operation of the
740 // new binding with the updated context.
741
742 let (replace_range, replace_value) =
743 replace_top_level_array_value_in_json_text(
744 &keymap_contents,
745 &["bindings", keystrokes_str],
746 None,
747 None,
748 index,
749 tab_size,
750 )
751 .context("Failed to replace keybinding")?;
752 keymap_contents.replace_range(replace_range, &replace_value);
753 operation = KeybindUpdateOperation::Add {
754 source,
755 from: Some(target),
756 };
757 }
758 } else {
759 log::warn!(
760 "Failed to find keybinding to update `{:?} -> {}` creating new binding for `{:?} -> {}` instead",
761 target.keystrokes,
762 target_action_value,
763 source.keystrokes,
764 source_action_value,
765 );
766 operation = KeybindUpdateOperation::Add {
767 source,
768 from: Some(target),
769 };
770 }
771 }
772
773 if let KeybindUpdateOperation::Add {
774 source: keybinding,
775 from,
776 } = operation
777 {
778 let mut value = serde_json::Map::with_capacity(4);
779 if let Some(context) = keybinding.context {
780 value.insert("context".to_string(), context.into());
781 }
782 let use_key_equivalents = from.and_then(|from| {
783 let action_value = from.action_value().context("Failed to serialize action value. `use_key_equivalents` on new keybinding may be incorrect.").log_err()?;
784 let (index, _) = find_binding(&keymap, &from, &action_value)?;
785 Some(keymap.0[index].use_key_equivalents)
786 }).unwrap_or(false);
787 if use_key_equivalents {
788 value.insert("use_key_equivalents".to_string(), true.into());
789 }
790
791 value.insert("bindings".to_string(), {
792 let mut bindings = serde_json::Map::new();
793 let action = keybinding.action_value()?;
794 bindings.insert(keybinding.keystrokes_unparsed(), action);
795 bindings.into()
796 });
797
798 let (replace_range, replace_value) = append_top_level_array_value_in_json_text(
799 &keymap_contents,
800 &value.into(),
801 tab_size,
802 )?;
803 keymap_contents.replace_range(replace_range, &replace_value);
804 }
805 return Ok(keymap_contents);
806
807 fn find_binding<'a, 'b>(
808 keymap: &'b KeymapFile,
809 target: &KeybindUpdateTarget<'a>,
810 target_action_value: &Value,
811 ) -> Option<(usize, &'b str)> {
812 let target_context_parsed =
813 KeyBindingContextPredicate::parse(target.context.unwrap_or("")).ok();
814 for (index, section) in keymap.sections().enumerate() {
815 let section_context_parsed =
816 KeyBindingContextPredicate::parse(§ion.context).ok();
817 if section_context_parsed != target_context_parsed {
818 continue;
819 }
820 let Some(bindings) = §ion.bindings else {
821 continue;
822 };
823 for (keystrokes_str, action) in bindings {
824 let Ok(keystrokes) = keystrokes_str
825 .split_whitespace()
826 .map(Keystroke::parse)
827 .collect::<Result<Vec<_>, _>>()
828 else {
829 continue;
830 };
831 if keystrokes.len() != target.keystrokes.len()
832 || !keystrokes
833 .iter()
834 .zip(target.keystrokes)
835 .all(|(a, b)| a.should_match(b))
836 {
837 continue;
838 }
839 if &action.0 != target_action_value {
840 continue;
841 }
842 return Some((index, &keystrokes_str));
843 }
844 }
845 None
846 }
847 }
848}
849
850#[derive(Clone)]
851pub enum KeybindUpdateOperation<'a> {
852 Replace {
853 /// Describes the keybind to create
854 source: KeybindUpdateTarget<'a>,
855 /// Describes the keybind to remove
856 target: KeybindUpdateTarget<'a>,
857 target_keybind_source: KeybindSource,
858 },
859 Add {
860 source: KeybindUpdateTarget<'a>,
861 from: Option<KeybindUpdateTarget<'a>>,
862 },
863 Remove {
864 target: KeybindUpdateTarget<'a>,
865 target_keybind_source: KeybindSource,
866 },
867}
868
869impl KeybindUpdateOperation<'_> {
870 pub fn generate_telemetry(
871 &self,
872 ) -> (
873 // The keybind that is created
874 String,
875 // The keybinding that was removed
876 String,
877 // The source of the keybinding
878 String,
879 ) {
880 let (new_binding, removed_binding, source) = match &self {
881 KeybindUpdateOperation::Replace {
882 source,
883 target,
884 target_keybind_source,
885 } => (Some(source), Some(target), Some(*target_keybind_source)),
886 KeybindUpdateOperation::Add { source, .. } => (Some(source), None, None),
887 KeybindUpdateOperation::Remove {
888 target,
889 target_keybind_source,
890 } => (None, Some(target), Some(*target_keybind_source)),
891 };
892
893 let new_binding = new_binding
894 .map(KeybindUpdateTarget::telemetry_string)
895 .unwrap_or("null".to_owned());
896 let removed_binding = removed_binding
897 .map(KeybindUpdateTarget::telemetry_string)
898 .unwrap_or("null".to_owned());
899
900 let source = source
901 .as_ref()
902 .map(KeybindSource::name)
903 .map(ToOwned::to_owned)
904 .unwrap_or("null".to_owned());
905
906 (new_binding, removed_binding, source)
907 }
908}
909
910impl<'a> KeybindUpdateOperation<'a> {
911 pub fn add(source: KeybindUpdateTarget<'a>) -> Self {
912 Self::Add { source, from: None }
913 }
914}
915
916#[derive(Debug, Clone)]
917pub struct KeybindUpdateTarget<'a> {
918 pub context: Option<&'a str>,
919 pub keystrokes: &'a [Keystroke],
920 pub action_name: &'a str,
921 pub action_arguments: Option<&'a str>,
922}
923
924impl<'a> KeybindUpdateTarget<'a> {
925 fn action_value(&self) -> Result<Value> {
926 if self.action_name == gpui::NoAction.name() {
927 return Ok(Value::Null);
928 }
929 let action_name: Value = self.action_name.into();
930 let value = match self.action_arguments {
931 Some(args) => {
932 let args = serde_json::from_str::<Value>(args)
933 .context("Failed to parse action arguments as JSON")?;
934 serde_json::json!([action_name, args])
935 }
936 None => action_name,
937 };
938 return Ok(value);
939 }
940
941 fn keystrokes_unparsed(&self) -> String {
942 let mut keystrokes = String::with_capacity(self.keystrokes.len() * 8);
943 for keystroke in self.keystrokes {
944 keystrokes.push_str(&keystroke.unparse());
945 keystrokes.push(' ');
946 }
947 keystrokes.pop();
948 keystrokes
949 }
950
951 fn telemetry_string(&self) -> String {
952 format!(
953 "action_name: {}, context: {}, action_arguments: {}, keystrokes: {}",
954 self.action_name,
955 self.context.unwrap_or("global"),
956 self.action_arguments.unwrap_or("none"),
957 self.keystrokes_unparsed()
958 )
959 }
960}
961
962#[derive(Clone, Copy, PartialEq, Eq)]
963pub enum KeybindSource {
964 User,
965 Default,
966 Base,
967 Vim,
968}
969
970impl KeybindSource {
971 const BASE: KeyBindingMetaIndex = KeyBindingMetaIndex(0);
972 const DEFAULT: KeyBindingMetaIndex = KeyBindingMetaIndex(1);
973 const VIM: KeyBindingMetaIndex = KeyBindingMetaIndex(2);
974 const USER: KeyBindingMetaIndex = KeyBindingMetaIndex(3);
975
976 pub fn name(&self) -> &'static str {
977 match self {
978 KeybindSource::User => "User",
979 KeybindSource::Default => "Default",
980 KeybindSource::Base => "Base",
981 KeybindSource::Vim => "Vim",
982 }
983 }
984
985 pub fn meta(&self) -> KeyBindingMetaIndex {
986 match self {
987 KeybindSource::User => Self::USER,
988 KeybindSource::Default => Self::DEFAULT,
989 KeybindSource::Base => Self::BASE,
990 KeybindSource::Vim => Self::VIM,
991 }
992 }
993
994 pub fn from_meta(index: KeyBindingMetaIndex) -> Self {
995 match index {
996 Self::USER => KeybindSource::User,
997 Self::BASE => KeybindSource::Base,
998 Self::DEFAULT => KeybindSource::Default,
999 Self::VIM => KeybindSource::Vim,
1000 _ => unreachable!(),
1001 }
1002 }
1003}
1004
1005impl From<KeyBindingMetaIndex> for KeybindSource {
1006 fn from(index: KeyBindingMetaIndex) -> Self {
1007 Self::from_meta(index)
1008 }
1009}
1010
1011impl From<KeybindSource> for KeyBindingMetaIndex {
1012 fn from(source: KeybindSource) -> Self {
1013 return source.meta();
1014 }
1015}
1016
1017#[cfg(test)]
1018mod tests {
1019 use gpui::Keystroke;
1020 use unindent::Unindent;
1021
1022 use crate::{
1023 KeybindSource, KeymapFile,
1024 keymap_file::{KeybindUpdateOperation, KeybindUpdateTarget},
1025 };
1026
1027 #[test]
1028 fn can_deserialize_keymap_with_trailing_comma() {
1029 let json = indoc::indoc! {"[
1030 // Standard macOS bindings
1031 {
1032 \"bindings\": {
1033 \"up\": \"menu::SelectPrevious\",
1034 },
1035 },
1036 ]
1037 "
1038 };
1039 KeymapFile::parse(json).unwrap();
1040 }
1041
1042 #[track_caller]
1043 fn check_keymap_update(
1044 input: impl ToString,
1045 operation: KeybindUpdateOperation,
1046 expected: impl ToString,
1047 ) {
1048 let result = KeymapFile::update_keybinding(operation, input.to_string(), 4)
1049 .expect("Update succeeded");
1050 pretty_assertions::assert_eq!(expected.to_string(), result);
1051 }
1052
1053 #[track_caller]
1054 fn parse_keystrokes(keystrokes: &str) -> Vec<Keystroke> {
1055 return keystrokes
1056 .split(' ')
1057 .map(|s| Keystroke::parse(s).expect("Keystrokes valid"))
1058 .collect();
1059 }
1060
1061 #[test]
1062 fn keymap_update() {
1063 zlog::init_test();
1064
1065 check_keymap_update(
1066 "[]",
1067 KeybindUpdateOperation::add(KeybindUpdateTarget {
1068 keystrokes: &parse_keystrokes("ctrl-a"),
1069 action_name: "zed::SomeAction",
1070 context: None,
1071 action_arguments: None,
1072 }),
1073 r#"[
1074 {
1075 "bindings": {
1076 "ctrl-a": "zed::SomeAction"
1077 }
1078 }
1079 ]"#
1080 .unindent(),
1081 );
1082
1083 check_keymap_update(
1084 r#"[
1085 {
1086 "bindings": {
1087 "ctrl-a": "zed::SomeAction"
1088 }
1089 }
1090 ]"#
1091 .unindent(),
1092 KeybindUpdateOperation::add(KeybindUpdateTarget {
1093 keystrokes: &parse_keystrokes("ctrl-b"),
1094 action_name: "zed::SomeOtherAction",
1095 context: None,
1096 action_arguments: None,
1097 }),
1098 r#"[
1099 {
1100 "bindings": {
1101 "ctrl-a": "zed::SomeAction"
1102 }
1103 },
1104 {
1105 "bindings": {
1106 "ctrl-b": "zed::SomeOtherAction"
1107 }
1108 }
1109 ]"#
1110 .unindent(),
1111 );
1112
1113 check_keymap_update(
1114 r#"[
1115 {
1116 "bindings": {
1117 "ctrl-a": "zed::SomeAction"
1118 }
1119 }
1120 ]"#
1121 .unindent(),
1122 KeybindUpdateOperation::add(KeybindUpdateTarget {
1123 keystrokes: &parse_keystrokes("ctrl-b"),
1124 action_name: "zed::SomeOtherAction",
1125 context: None,
1126 action_arguments: Some(r#"{"foo": "bar"}"#),
1127 }),
1128 r#"[
1129 {
1130 "bindings": {
1131 "ctrl-a": "zed::SomeAction"
1132 }
1133 },
1134 {
1135 "bindings": {
1136 "ctrl-b": [
1137 "zed::SomeOtherAction",
1138 {
1139 "foo": "bar"
1140 }
1141 ]
1142 }
1143 }
1144 ]"#
1145 .unindent(),
1146 );
1147
1148 check_keymap_update(
1149 r#"[
1150 {
1151 "bindings": {
1152 "ctrl-a": "zed::SomeAction"
1153 }
1154 }
1155 ]"#
1156 .unindent(),
1157 KeybindUpdateOperation::add(KeybindUpdateTarget {
1158 keystrokes: &parse_keystrokes("ctrl-b"),
1159 action_name: "zed::SomeOtherAction",
1160 context: Some("Zed > Editor && some_condition = true"),
1161 action_arguments: Some(r#"{"foo": "bar"}"#),
1162 }),
1163 r#"[
1164 {
1165 "bindings": {
1166 "ctrl-a": "zed::SomeAction"
1167 }
1168 },
1169 {
1170 "context": "Zed > Editor && some_condition = true",
1171 "bindings": {
1172 "ctrl-b": [
1173 "zed::SomeOtherAction",
1174 {
1175 "foo": "bar"
1176 }
1177 ]
1178 }
1179 }
1180 ]"#
1181 .unindent(),
1182 );
1183
1184 check_keymap_update(
1185 r#"[
1186 {
1187 "bindings": {
1188 "ctrl-a": "zed::SomeAction"
1189 }
1190 }
1191 ]"#
1192 .unindent(),
1193 KeybindUpdateOperation::Replace {
1194 target: KeybindUpdateTarget {
1195 keystrokes: &parse_keystrokes("ctrl-a"),
1196 action_name: "zed::SomeAction",
1197 context: None,
1198 action_arguments: None,
1199 },
1200 source: KeybindUpdateTarget {
1201 keystrokes: &parse_keystrokes("ctrl-b"),
1202 action_name: "zed::SomeOtherAction",
1203 context: None,
1204 action_arguments: Some(r#"{"foo": "bar"}"#),
1205 },
1206 target_keybind_source: KeybindSource::Base,
1207 },
1208 r#"[
1209 {
1210 "bindings": {
1211 "ctrl-a": "zed::SomeAction"
1212 }
1213 },
1214 {
1215 "bindings": {
1216 "ctrl-b": [
1217 "zed::SomeOtherAction",
1218 {
1219 "foo": "bar"
1220 }
1221 ]
1222 }
1223 }
1224 ]"#
1225 .unindent(),
1226 );
1227
1228 check_keymap_update(
1229 r#"[
1230 {
1231 "bindings": {
1232 "a": "zed::SomeAction"
1233 }
1234 }
1235 ]"#
1236 .unindent(),
1237 KeybindUpdateOperation::Replace {
1238 target: KeybindUpdateTarget {
1239 keystrokes: &parse_keystrokes("a"),
1240 action_name: "zed::SomeAction",
1241 context: None,
1242 action_arguments: None,
1243 },
1244 source: KeybindUpdateTarget {
1245 keystrokes: &parse_keystrokes("ctrl-b"),
1246 action_name: "zed::SomeOtherAction",
1247 context: None,
1248 action_arguments: Some(r#"{"foo": "bar"}"#),
1249 },
1250 target_keybind_source: KeybindSource::User,
1251 },
1252 r#"[
1253 {
1254 "bindings": {
1255 "ctrl-b": [
1256 "zed::SomeOtherAction",
1257 {
1258 "foo": "bar"
1259 }
1260 ]
1261 }
1262 }
1263 ]"#
1264 .unindent(),
1265 );
1266
1267 check_keymap_update(
1268 r#"[
1269 {
1270 "bindings": {
1271 "ctrl-a": "zed::SomeAction"
1272 }
1273 }
1274 ]"#
1275 .unindent(),
1276 KeybindUpdateOperation::Replace {
1277 target: KeybindUpdateTarget {
1278 keystrokes: &parse_keystrokes("ctrl-a"),
1279 action_name: "zed::SomeNonexistentAction",
1280 context: None,
1281 action_arguments: None,
1282 },
1283 source: KeybindUpdateTarget {
1284 keystrokes: &parse_keystrokes("ctrl-b"),
1285 action_name: "zed::SomeOtherAction",
1286 context: None,
1287 action_arguments: None,
1288 },
1289 target_keybind_source: KeybindSource::User,
1290 },
1291 r#"[
1292 {
1293 "bindings": {
1294 "ctrl-a": "zed::SomeAction"
1295 }
1296 },
1297 {
1298 "bindings": {
1299 "ctrl-b": "zed::SomeOtherAction"
1300 }
1301 }
1302 ]"#
1303 .unindent(),
1304 );
1305
1306 check_keymap_update(
1307 r#"[
1308 {
1309 "bindings": {
1310 // some comment
1311 "ctrl-a": "zed::SomeAction"
1312 // some other comment
1313 }
1314 }
1315 ]"#
1316 .unindent(),
1317 KeybindUpdateOperation::Replace {
1318 target: KeybindUpdateTarget {
1319 keystrokes: &parse_keystrokes("ctrl-a"),
1320 action_name: "zed::SomeAction",
1321 context: None,
1322 action_arguments: None,
1323 },
1324 source: KeybindUpdateTarget {
1325 keystrokes: &parse_keystrokes("ctrl-b"),
1326 action_name: "zed::SomeOtherAction",
1327 context: None,
1328 action_arguments: Some(r#"{"foo": "bar"}"#),
1329 },
1330 target_keybind_source: KeybindSource::User,
1331 },
1332 r#"[
1333 {
1334 "bindings": {
1335 // some comment
1336 "ctrl-b": [
1337 "zed::SomeOtherAction",
1338 {
1339 "foo": "bar"
1340 }
1341 ]
1342 // some other comment
1343 }
1344 }
1345 ]"#
1346 .unindent(),
1347 );
1348
1349 check_keymap_update(
1350 r#"[
1351 {
1352 "context": "SomeContext",
1353 "bindings": {
1354 "a": "foo::bar",
1355 "b": "baz::qux",
1356 }
1357 }
1358 ]"#
1359 .unindent(),
1360 KeybindUpdateOperation::Replace {
1361 target: KeybindUpdateTarget {
1362 keystrokes: &parse_keystrokes("a"),
1363 action_name: "foo::bar",
1364 context: Some("SomeContext"),
1365 action_arguments: None,
1366 },
1367 source: KeybindUpdateTarget {
1368 keystrokes: &parse_keystrokes("c"),
1369 action_name: "foo::baz",
1370 context: Some("SomeOtherContext"),
1371 action_arguments: None,
1372 },
1373 target_keybind_source: KeybindSource::User,
1374 },
1375 r#"[
1376 {
1377 "context": "SomeContext",
1378 "bindings": {
1379 "b": "baz::qux",
1380 }
1381 },
1382 {
1383 "context": "SomeOtherContext",
1384 "bindings": {
1385 "c": "foo::baz"
1386 }
1387 }
1388 ]"#
1389 .unindent(),
1390 );
1391
1392 check_keymap_update(
1393 r#"[
1394 {
1395 "context": "SomeContext",
1396 "bindings": {
1397 "a": "foo::bar",
1398 }
1399 }
1400 ]"#
1401 .unindent(),
1402 KeybindUpdateOperation::Replace {
1403 target: KeybindUpdateTarget {
1404 keystrokes: &parse_keystrokes("a"),
1405 action_name: "foo::bar",
1406 context: Some("SomeContext"),
1407 action_arguments: None,
1408 },
1409 source: KeybindUpdateTarget {
1410 keystrokes: &parse_keystrokes("c"),
1411 action_name: "foo::baz",
1412 context: Some("SomeOtherContext"),
1413 action_arguments: None,
1414 },
1415 target_keybind_source: KeybindSource::User,
1416 },
1417 r#"[
1418 {
1419 "context": "SomeOtherContext",
1420 "bindings": {
1421 "c": "foo::baz",
1422 }
1423 }
1424 ]"#
1425 .unindent(),
1426 );
1427
1428 check_keymap_update(
1429 r#"[
1430 {
1431 "context": "SomeContext",
1432 "bindings": {
1433 "a": "foo::bar",
1434 "c": "foo::baz",
1435 }
1436 },
1437 ]"#
1438 .unindent(),
1439 KeybindUpdateOperation::Remove {
1440 target: KeybindUpdateTarget {
1441 context: Some("SomeContext"),
1442 keystrokes: &parse_keystrokes("a"),
1443 action_name: "foo::bar",
1444 action_arguments: None,
1445 },
1446 target_keybind_source: KeybindSource::User,
1447 },
1448 r#"[
1449 {
1450 "context": "SomeContext",
1451 "bindings": {
1452 "c": "foo::baz",
1453 }
1454 },
1455 ]"#
1456 .unindent(),
1457 );
1458
1459 check_keymap_update(
1460 r#"[
1461 {
1462 "context": "SomeContext",
1463 "bindings": {
1464 "a": ["foo::bar", true],
1465 "c": "foo::baz",
1466 }
1467 },
1468 ]"#
1469 .unindent(),
1470 KeybindUpdateOperation::Remove {
1471 target: KeybindUpdateTarget {
1472 context: Some("SomeContext"),
1473 keystrokes: &parse_keystrokes("a"),
1474 action_name: "foo::bar",
1475 action_arguments: Some("true"),
1476 },
1477 target_keybind_source: KeybindSource::User,
1478 },
1479 r#"[
1480 {
1481 "context": "SomeContext",
1482 "bindings": {
1483 "c": "foo::baz",
1484 }
1485 },
1486 ]"#
1487 .unindent(),
1488 );
1489
1490 check_keymap_update(
1491 r#"[
1492 {
1493 "context": "SomeContext",
1494 "bindings": {
1495 "b": "foo::baz",
1496 }
1497 },
1498 {
1499 "context": "SomeContext",
1500 "bindings": {
1501 "a": ["foo::bar", true],
1502 }
1503 },
1504 {
1505 "context": "SomeContext",
1506 "bindings": {
1507 "c": "foo::baz",
1508 }
1509 },
1510 ]"#
1511 .unindent(),
1512 KeybindUpdateOperation::Remove {
1513 target: KeybindUpdateTarget {
1514 context: Some("SomeContext"),
1515 keystrokes: &parse_keystrokes("a"),
1516 action_name: "foo::bar",
1517 action_arguments: Some("true"),
1518 },
1519 target_keybind_source: KeybindSource::User,
1520 },
1521 r#"[
1522 {
1523 "context": "SomeContext",
1524 "bindings": {
1525 "b": "foo::baz",
1526 }
1527 },
1528 {
1529 "context": "SomeContext",
1530 "bindings": {
1531 "c": "foo::baz",
1532 }
1533 },
1534 ]"#
1535 .unindent(),
1536 );
1537 check_keymap_update(
1538 r#"[
1539 {
1540 "context": "SomeOtherContext",
1541 "use_key_equivalents": true,
1542 "bindings": {
1543 "b": "foo::bar",
1544 }
1545 },
1546 ]"#
1547 .unindent(),
1548 KeybindUpdateOperation::Add {
1549 source: KeybindUpdateTarget {
1550 context: Some("SomeContext"),
1551 keystrokes: &parse_keystrokes("a"),
1552 action_name: "foo::baz",
1553 action_arguments: Some("true"),
1554 },
1555 from: Some(KeybindUpdateTarget {
1556 context: Some("SomeOtherContext"),
1557 keystrokes: &parse_keystrokes("b"),
1558 action_name: "foo::bar",
1559 action_arguments: None,
1560 }),
1561 },
1562 r#"[
1563 {
1564 "context": "SomeOtherContext",
1565 "use_key_equivalents": true,
1566 "bindings": {
1567 "b": "foo::bar",
1568 }
1569 },
1570 {
1571 "context": "SomeContext",
1572 "use_key_equivalents": true,
1573 "bindings": {
1574 "a": [
1575 "foo::baz",
1576 true
1577 ]
1578 }
1579 }
1580 ]"#
1581 .unindent(),
1582 );
1583
1584 check_keymap_update(
1585 r#"[
1586 {
1587 "context": "SomeOtherContext",
1588 "use_key_equivalents": true,
1589 "bindings": {
1590 "b": "foo::bar",
1591 }
1592 },
1593 ]"#
1594 .unindent(),
1595 KeybindUpdateOperation::Remove {
1596 target: KeybindUpdateTarget {
1597 context: Some("SomeContext"),
1598 keystrokes: &parse_keystrokes("a"),
1599 action_name: "foo::baz",
1600 action_arguments: Some("true"),
1601 },
1602 target_keybind_source: KeybindSource::Default,
1603 },
1604 r#"[
1605 {
1606 "context": "SomeOtherContext",
1607 "use_key_equivalents": true,
1608 "bindings": {
1609 "b": "foo::bar",
1610 }
1611 },
1612 {
1613 "context": "SomeContext",
1614 "bindings": {
1615 "a": null
1616 }
1617 }
1618 ]"#
1619 .unindent(),
1620 );
1621 }
1622}