inline_completion_button: Fix links to account page (#31558)

Marshall Bowers created 6 months ago

This PR fixes an issue where the various links to the account page from
the Edit Prediction menu were not working.

The `OpenZedUrl` action is opening URLs that deep-link _into_ Zed.

Fixes https://github.com/zed-industries/zed/issues/31060.

Release Notes:

- Fixed an issue with opening links to the Zed account page from the
Edit Prediction menu.

Change summary

crates/inline_completion_button/src/inline_completion_button.rs | 47 --
1 file changed, 9 insertions(+), 38 deletions(-)

Detailed changes

crates/inline_completion_button/src/inline_completion_button.rs

@@ -33,7 +33,7 @@ use workspace::{
     StatusItemView, Toast, Workspace, create_and_open_local_file, item::ItemHandle,
     notifications::NotificationId,
 };
-use zed_actions::{OpenBrowser, OpenZedUrl};
+use zed_actions::OpenBrowser;
 use zed_llm_client::UsageLimit;
 use zeta::RateCompletions;
 
@@ -735,13 +735,8 @@ impl InlineCompletionButton {
                         move |_, cx| cx.open_url(&zed_urls::account_url(cx)),
                     )
                     .when(usage.over_limit(), |menu| -> ContextMenu {
-                        menu.entry("Subscribe to increase your limit", None, |window, cx| {
-                            window.dispatch_action(
-                                Box::new(OpenZedUrl {
-                                    url: zed_urls::account_url(cx),
-                                }),
-                                cx,
-                            );
+                        menu.entry("Subscribe to increase your limit", None, |_window, cx| {
+                            cx.open_url(&zed_urls::account_url(cx))
                         })
                     })
                     .separator();
@@ -763,26 +758,12 @@ impl InlineCompletionButton {
                                 )
                                 .into_any_element()
                         },
-                        |window, cx| {
-                            window.dispatch_action(
-                                Box::new(OpenZedUrl {
-                                    url: zed_urls::account_url(cx),
-                                }),
-                                cx,
-                            );
-                        },
+                        |_window, cx| cx.open_url(&zed_urls::account_url(cx)),
                     )
                     .entry(
                         "You need to upgrade to Zed Pro or contact us.",
                         None,
-                        |window, cx| {
-                            window.dispatch_action(
-                                Box::new(OpenZedUrl {
-                                    url: zed_urls::account_url(cx),
-                                }),
-                                cx,
-                            );
-                        },
+                        |_window, cx| cx.open_url(&zed_urls::account_url(cx)),
                     )
                     .separator();
             } else if self.user_store.read(cx).has_overdue_invoices() {
@@ -803,25 +784,15 @@ impl InlineCompletionButton {
                                 )
                                 .into_any_element()
                         },
-                        |window, cx| {
-                            window.dispatch_action(
-                                Box::new(OpenZedUrl {
-                                    url: zed_urls::account_url(cx),
-                                }),
-                                cx,
-                            );
+                        |_window, cx| {
+                            cx.open_url(&zed_urls::account_url(cx))
                         },
                     )
                     .entry(
                         "Check your payment status or contact us at [e-mail] to continue using this feature.",
                         None,
-                        |window, cx| {
-                            window.dispatch_action(
-                                Box::new(OpenZedUrl {
-                                    url: zed_urls::account_url(cx),
-                                }),
-                                cx,
-                            );
+                        |_window, cx| {
+                            cx.open_url(&zed_urls::account_url(cx))
                         },
                     )
                     .separator();