From 016a4c5bf3147541b30d6ab93c4359da92daba52 Mon Sep 17 00:00:00 2001 From: Cole Miller Date: Mon, 13 Oct 2025 11:36:40 -0400 Subject: [PATCH] Add a comment about the use of `shell_kind` in terminal.rs (#40114) Release Notes: - N/A Co-authored-by: Jakub Konka --- crates/terminal/src/terminal.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crates/terminal/src/terminal.rs b/crates/terminal/src/terminal.rs index cf6851ac346cbc26b88029822fddb88b408be16e..bf8fd6a5aeb26312cde37ff22dcef40508e6802d 100644 --- a/crates/terminal/src/terminal.rs +++ b/crates/terminal/src/terminal.rs @@ -495,6 +495,11 @@ impl TerminalBuilder { .unwrap_or(params.program.clone()) }); + // Note: when remoting, this shell_kind will scrutinize `ssh` or + // `wsl.exe` as a shell and fall back to posix or powershell based on + // the compilation target. This is fine right now due to the restricted + // way we use the return value, but would become incorrect if we + // supported remoting into windows. let shell_kind = shell.shell_kind(cfg!(windows)); let pty_options = {