From 0a9023bce09daf889bc323fc14580a9ffec32b04 Mon Sep 17 00:00:00 2001
From: Devdatta Talele <50290838+devdattatalele@users.noreply.github.com>
Date: Thu, 18 Sep 2025 20:45:10 +0530
Subject: [PATCH] ui: Use hoverable tooltips for Badge component to fix tooltip
 behavior (#38387)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Summary

Fixes #38362 - Privacy tooltip behavior issues in AI Setup onboarding

## Problem
The Privacy tooltip in AI Setup onboarding had incorrect behavior:
1. Tooltip remained visible after mouse left the Privacy button
2. Clicking the button didn't toggle tooltip properly
3. Clicking in intersection area between tooltip and button didn't work

## Root Cause
Badge component used `tooltip()` instead of `hoverable_tooltip()`,
causing:
- Immediate tooltip hiding when mouse left triggering element
- No support for tooltip content interaction
- Poor intersection area click handling

## Solution
**Single line change** in `crates/ui/src/components/badge.rs:61`:
```rust
// Before:
this.tooltip(move |window, cx| tooltip(window, cx))

// After:
this.hoverable_tooltip(move |window, cx| tooltip(window, cx))
```

## Technical Details
- Leverages existing GPUI `hoverable_tooltip()` infrastructure
- Enables 500ms grace period before tooltip hiding
- Allows hovering over tooltip content without disappearing
- Uses proper tooltip bounds detection for click handling
- Affects all Badge tooltips system-wide (positive improvement)
- Full backward compatibility - no API changes

## Test Plan
- [x] Hover over Privacy badge → tooltip appears
- [x] Move mouse away → tooltip stays visible for 500ms
- [x] Move mouse to tooltip content → tooltip remains visible
- [x] Click on tooltip content → properly handled
- [x] Move mouse completely away → tooltip hides after delay
- [x] Verify no regression in other Badge tooltip usage

Release Notes:

- N/A
---
 crates/ui/src/components/badge.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crates/ui/src/components/badge.rs b/crates/ui/src/components/badge.rs
index f36e03291c5915f70e8370c6cc1e037d097622b0..9db6fd616f56769b03d1856cfda3fdeef66e446f 100644
--- a/crates/ui/src/components/badge.rs
+++ b/crates/ui/src/components/badge.rs
@@ -58,7 +58,7 @@ impl RenderOnce for Badge {
             .child(Divider::vertical().color(DividerColor::Border))
             .child(Label::new(self.label.clone()).size(LabelSize::Small).ml_1())
             .when_some(tooltip, |this, tooltip| {
-                this.tooltip(move |window, cx| tooltip(window, cx))
+                this.hoverable_tooltip(move |window, cx| tooltip(window, cx))
             })
     }
 }