From 0b4afe518b9d8937120d07279051d134309cd780 Mon Sep 17 00:00:00 2001
From: Bennet Bo Fenner <bennet@zed.dev>
Date: Mon, 29 Jul 2024 17:37:11 +0200
Subject: [PATCH] assistant: Remove feature flag for terminal inline assistant
 (#15432)

This PR removes the feature flag for the terminal inline assistant,
making it available to everyone.

Release Notes:

- Use Ctrl+Enter to summon the inline assistant in the terminal, which
let's you generate terminal commands based on your description
([demo](https://twitter.com/thorstenball/status/1814241447383605329))
---
 Cargo.lock                                | 1 -
 crates/assistant/Cargo.toml               | 1 -
 crates/assistant/src/assistant_panel.rs   | 5 -----
 crates/feature_flags/src/feature_flags.rs | 5 -----
 4 files changed, 12 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 7759a5865094a359a21e1591f7dba5c978991a38..ea28e44fb458e485b19bf5498f7ba3c0b524ef75 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -410,7 +410,6 @@ dependencies = [
  "ctor",
  "editor",
  "env_logger",
- "feature_flags",
  "fs",
  "futures 0.3.28",
  "fuzzy",
diff --git a/crates/assistant/Cargo.toml b/crates/assistant/Cargo.toml
index 6e7bef88ca1ef0fc7b47517684eb97267f6738a7..1f86d17dc26e51d92ac46dbd402d1f3f366596bc 100644
--- a/crates/assistant/Cargo.toml
+++ b/crates/assistant/Cargo.toml
@@ -34,7 +34,6 @@ collections.workspace = true
 command_palette_hooks.workspace = true
 completion.workspace = true
 editor.workspace = true
-feature_flags.workspace = true
 fs.workspace = true
 futures.workspace = true
 fuzzy.workspace = true
diff --git a/crates/assistant/src/assistant_panel.rs b/crates/assistant/src/assistant_panel.rs
index ec72cbd1ff7542822c5acf294fc71a0ea2c3b402..09e308f60215262661047d3b4e9451d225a40b6b 100644
--- a/crates/assistant/src/assistant_panel.rs
+++ b/crates/assistant/src/assistant_panel.rs
@@ -644,11 +644,6 @@ impl AssistantPanel {
                 .focus_handle(cx)
                 .contains_focused(cx)
             {
-                use feature_flags::FeatureFlagAppExt;
-                if !cx.has_flag::<feature_flags::TerminalInlineAssist>() {
-                    return None;
-                }
-
                 if let Some(terminal_view) = terminal_panel
                     .read(cx)
                     .pane()
diff --git a/crates/feature_flags/src/feature_flags.rs b/crates/feature_flags/src/feature_flags.rs
index c9deabe5a994c81aab67427dd7772ee483e965c7..cb37ca392e72b4a58b2a6209d9054d72048636ae 100644
--- a/crates/feature_flags/src/feature_flags.rs
+++ b/crates/feature_flags/src/feature_flags.rs
@@ -43,11 +43,6 @@ impl FeatureFlag for LanguageModels {
     const NAME: &'static str = "language-models";
 }
 
-pub struct TerminalInlineAssist {}
-impl FeatureFlag for TerminalInlineAssist {
-    const NAME: &'static str = "terminal-inline-assist";
-}
-
 pub struct GroupedDiagnostics {}
 impl FeatureFlag for GroupedDiagnostics {
     const NAME: &'static str = "grouped-diagnostics";