Only send unit eval failures to Slack for cron job (#42479)

Richard Feldman created 1 week ago

Release Notes:

- N/A

Change summary

.github/workflows/run_cron_unit_evals.yml            |  9 -------
.github/workflows/run_unit_evals.yml                 |  9 -------
tooling/xtask/src/tasks/workflows/run_agent_evals.rs | 16 --------------
3 files changed, 34 deletions(-)

Detailed changes

.github/workflows/run_cron_unit_evals.yml

@@ -50,15 +50,6 @@ jobs:
         OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
         GOOGLE_AI_API_KEY: ${{ secrets.GOOGLE_AI_API_KEY }}
         GOOGLE_CLOUD_PROJECT: ${{ secrets.GOOGLE_CLOUD_PROJECT }}
-    - name: run_agent_evals::unit_evals::send_failure_to_slack
-      if: ${{ failure() }}
-      uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52
-      with:
-        method: chat.postMessage
-        token: ${{ secrets.SLACK_APP_ZED_UNIT_EVALS_BOT_TOKEN }}
-        payload: |
-          channel: C04UDRNNJFQ
-          text: "Unit Evals Failed: https://github.com/zed-industries/zed/actions/runs/${{ github.run_id }}"
     - name: steps::cleanup_cargo_config
       if: always()
       run: |

.github/workflows/run_unit_evals.yml

@@ -60,15 +60,6 @@ jobs:
         GOOGLE_AI_API_KEY: ${{ secrets.GOOGLE_AI_API_KEY }}
         GOOGLE_CLOUD_PROJECT: ${{ secrets.GOOGLE_CLOUD_PROJECT }}
         UNIT_EVAL_COMMIT: ${{ inputs.commit_sha }}
-    - name: run_agent_evals::unit_evals::send_failure_to_slack
-      if: ${{ failure() }}
-      uses: slackapi/slack-github-action@b0fa283ad8fea605de13dc3f449259339835fc52
-      with:
-        method: chat.postMessage
-        token: ${{ secrets.SLACK_APP_ZED_UNIT_EVALS_BOT_TOKEN }}
-        payload: |
-          channel: C04UDRNNJFQ
-          text: "Unit Evals Failed: https://github.com/zed-industries/zed/actions/runs/${{ github.run_id }}"
     - name: steps::cleanup_cargo_config
       if: always()
       run: |

tooling/xtask/src/tasks/workflows/run_agent_evals.rs

@@ -118,21 +118,6 @@ fn cron_unit_evals() -> NamedJob {
 }
 
 fn unit_evals(commit: Option<&Input>) -> Job {
-    fn send_failure_to_slack() -> Step<Use> {
-        named::uses(
-            "slackapi",
-            "slack-github-action",
-            "b0fa283ad8fea605de13dc3f449259339835fc52",
-        )
-        .if_condition(Expression::new("${{ failure() }}"))
-        .add_with(("method", "chat.postMessage"))
-        .add_with(("token", vars::SLACK_APP_ZED_UNIT_EVALS_BOT_TOKEN))
-        .add_with(("payload", indoc::indoc!{r#"
-            channel: C04UDRNNJFQ
-            text: "Unit Evals Failed: https://github.com/zed-industries/zed/actions/runs/${{ github.run_id }}"
-        "#}))
-    }
-
     let script_step = add_api_keys(steps::script("./script/run-unit-evals"));
 
     Job::default()
@@ -147,6 +132,5 @@ fn unit_evals(commit: Option<&Input>) -> Job {
             Some(commit) => script_step.add_env(("UNIT_EVAL_COMMIT", commit)),
             None => script_step,
         })
-        .add_step(send_failure_to_slack())
         .add_step(steps::cleanup_cargo_config(Platform::Linux))
 }