From 0f4e64026b7c5ef9533606efe3e7ba6c2f39b8fa Mon Sep 17 00:00:00 2001 From: Agus Zubiaga Date: Thu, 24 Jul 2025 12:59:56 -0300 Subject: [PATCH] Remove todo Co-authored-by: Ben Brandt Co-authored-by: Richard Feldman --- crates/acp_thread/src/acp_thread.rs | 3 ++- crates/agent_ui/src/acp/thread_view.rs | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/acp_thread/src/acp_thread.rs b/crates/acp_thread/src/acp_thread.rs index a0948922b22bffdc64dff6e4ca554821153dc3ea..0fafb75583af2b90b29707d08355b6dbfff8eaef 100644 --- a/crates/acp_thread/src/acp_thread.rs +++ b/crates/acp_thread/src/acp_thread.rs @@ -734,7 +734,8 @@ impl AcpThread { } fn tool_call_mut(&mut self, id: &acp::ToolCallId) -> Option<(usize, &mut ToolCall)> { - // todo! use map + // The tool call we are looking for is typically the last one, or very close to the end. + // At the moment, it doesn't seem like a hashmap would be a good fit for this use case. self.entries .iter_mut() .enumerate() diff --git a/crates/agent_ui/src/acp/thread_view.rs b/crates/agent_ui/src/acp/thread_view.rs index 884d31d5c3dfd0077578e6c9b7784d51ecf24679..7f5de9db5f2c8f7b900a698193f0599e6c7270a2 100644 --- a/crates/agent_ui/src/acp/thread_view.rs +++ b/crates/agent_ui/src/acp/thread_view.rs @@ -1064,7 +1064,6 @@ impl AcpThreadView { ) .into_any_element() })) - // todo! confirm this looks ok .child(self.render_permission_buttons( options, entry_ix,