From 114791e1a86e29097ea9c8636938496f0da3d7d7 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Fri, 26 Sep 2025 11:54:52 -0600 Subject: [PATCH] Revert "Fix arrow function detection in TypeScript/JavaScript outline (#38411)" (#38982) This reverts commit 1bbf98aea6f335e791f19d8f76ba8a5f0510937f. We found that #38411 caused problems where anonymous functions are included too many times in the outline. We'd like to figure out a better fix before shipping this to stable. Fixes #38956 Release Notes: - (preview only) revert changes to outline view --- crates/languages/src/javascript/outline.scm | 22 --------------------- crates/languages/src/tsx/outline.scm | 22 --------------------- crates/languages/src/typescript/outline.scm | 22 --------------------- 3 files changed, 66 deletions(-) diff --git a/crates/languages/src/javascript/outline.scm b/crates/languages/src/javascript/outline.scm index 8a58b6dc1b04b0b36f6155055bd8439bc2ddeca2..ca16c27a27be3e1e09ced16cd2eef7aa28345f9e 100644 --- a/crates/languages/src/javascript/outline.scm +++ b/crates/languages/src/javascript/outline.scm @@ -116,26 +116,4 @@ ) ) @item -; Arrow functions in variable declarations (anywhere in the tree, including nested in functions) -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (arrow_function)) @item) - -; Async arrow functions in variable declarations -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (arrow_function - "async" @context)) @item) - -; Named function expressions in variable declarations -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (function_expression)) @item) - (comment) @annotation diff --git a/crates/languages/src/tsx/outline.scm b/crates/languages/src/tsx/outline.scm index 72efff9ab74155c626bd7b91ad1cf8b580431492..f4261b9697d376f517b717bc942387190e0b6dde 100644 --- a/crates/languages/src/tsx/outline.scm +++ b/crates/languages/src/tsx/outline.scm @@ -124,26 +124,4 @@ ) ) @item -; Arrow functions in variable declarations (anywhere in the tree, including nested in functions) -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (arrow_function)) @item) - -; Async arrow functions in variable declarations -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (arrow_function - "async" @context)) @item) - -; Named function expressions in variable declarations -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (function_expression)) @item) - (comment) @annotation diff --git a/crates/languages/src/typescript/outline.scm b/crates/languages/src/typescript/outline.scm index 72efff9ab74155c626bd7b91ad1cf8b580431492..f4261b9697d376f517b717bc942387190e0b6dde 100644 --- a/crates/languages/src/typescript/outline.scm +++ b/crates/languages/src/typescript/outline.scm @@ -124,26 +124,4 @@ ) ) @item -; Arrow functions in variable declarations (anywhere in the tree, including nested in functions) -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (arrow_function)) @item) - -; Async arrow functions in variable declarations -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (arrow_function - "async" @context)) @item) - -; Named function expressions in variable declarations -(lexical_declaration - ["let" "const"] @context - (variable_declarator - name: (_) @name - value: (function_expression)) @item) - (comment) @annotation