Enable `clippy::eq_op` (#9369)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::eq_op`](https://rust-lang.github.io/rust-clippy/master/index.html#/eq_op)
rule and fixes the outstanding violations.

Enabling this rule seems to have caught two bugs!

Release Notes:

- N/A

Change summary

Cargo.toml                                    | 1 -
crates/language_tools/src/syntax_tree_view.rs | 2 +-
crates/story/src/story.rs                     | 4 ++--
crates/workspace/src/workspace.rs             | 2 +-
4 files changed, 4 insertions(+), 5 deletions(-)

Detailed changes

Cargo.toml

@@ -412,7 +412,6 @@ almost_complete_range = "allow"
 arc_with_non_send_sync = "allow"
 borrowed_box = "allow"
 derive_ord_xor_partial_ord = "allow"
-eq_op = "allow"
 let_underscore_future = "allow"
 map_entry = "allow"
 non_canonical_clone_impl = "allow"

crates/language_tools/src/syntax_tree_view.rs

@@ -148,7 +148,7 @@ impl SyntaxTreeView {
         if did_reparse {
             prev_layer = buffer_state.active_layer.take();
         }
-        if buffer_state.buffer != buffer || buffer_state.excerpt_id != buffer_state.excerpt_id {
+        if buffer_state.buffer != buffer || buffer_state.excerpt_id != excerpt_id {
             buffer_state.buffer = buffer.clone();
             buffer_state.excerpt_id = excerpt_id;
             buffer_state.active_layer = None;

crates/story/src/story.rs

@@ -37,10 +37,10 @@ impl StoryColor {
             primary: hsla(216. / 360., 11. / 100., 0. / 100., 1.),
             secondary: hsla(216. / 360., 11. / 100., 16. / 100., 1.),
             border: hsla(216. / 360., 11. / 100., 91. / 100., 1.),
-            background: hsla(0. / 360., 0. / 100., 100. / 100., 1.),
+            background: hsla(0. / 360., 0. / 100., 1., 1.),
             card_background: hsla(0. / 360., 0. / 100., 96. / 100., 1.),
             divider: hsla(216. / 360., 11. / 100., 86. / 100., 1.),
-            link: hsla(206. / 360., 100. / 100., 50. / 100., 1.),
+            link: hsla(206. / 360., 1., 50. / 100., 1.),
         }
     }
 }

crates/workspace/src/workspace.rs

@@ -2663,7 +2663,7 @@ impl Workspace {
         if self
             .follower_states
             .values()
-            .all(|state| state.leader_id != state.leader_id)
+            .all(|state| state.leader_id != leader_id)
         {
             let project_id = self.project.read(cx).remote_id();
             let room_id = self.active_call()?.read(cx).room()?.read(cx).id();