Revert "Added support for dismissing the toolchain path selector via … (#49504) (cherry-pick to stable) (#49529)

zed-zippy[bot] and Kurian Jojo created 1 month ago

Cherry-pick of #49504 to stable

----
…`esc` (#48201)"

This reverts commit 174fc5115243fda191da6a526fa1f12b627c1fcd.

Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent,
and it goes to the Search State
- This prevents the selected toolchain from being resolved and the
ScopePicker being presented

cc: @JosephTLyons 

Release Notes:

- Fixed a regression where the toolchain path selector would immediately
dismiss upon selecting a path, preventing the addition of new
toolchains.

Co-authored-by: Kurian Jojo <[e-mail]>

Change summary

crates/toolchain_selector/src/toolchain_selector.rs | 39 +++++----------
1 file changed, 13 insertions(+), 26 deletions(-)

Detailed changes

crates/toolchain_selector/src/toolchain_selector.rs

@@ -119,20 +119,10 @@ impl AddToolchainState {
                 picker
             });
 
-            let weak_toolchain_selector = weak.clone();
-            let window_handle = window.window_handle();
             Self {
                 state: AddState::Path {
-                    _subscription: cx.subscribe(&picker, move |_, _, _: &DismissEvent, cx| {
-                        if let Some(toolchain_selector) = weak_toolchain_selector.upgrade() {
-                            window_handle
-                                .update(cx, |_, window, cx| {
-                                    toolchain_selector.update(cx, |this, cx| {
-                                        this.cancel(&menu::Cancel, window, cx);
-                                    });
-                                })
-                                .ok();
-                        }
+                    _subscription: cx.subscribe(&picker, |_, _, _: &DismissEvent, cx| {
+                        cx.stop_propagation();
                     }),
                     picker,
                     error: None,
@@ -394,6 +384,7 @@ impl Focusable for State {
 impl Render for AddToolchainState {
     fn render(&mut self, window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
         let theme = cx.theme().clone();
+        let weak = self.weak.upgrade();
         let label = SharedString::new_static("Add");
 
         v_flex()
@@ -404,6 +395,16 @@ impl Render for AddToolchainState {
             .border_1()
             .border_color(cx.theme().colors().border_variant)
             .rounded_lg()
+            .when_some(weak, |this, weak| {
+                this.on_action(window.listener_for(
+                    &weak,
+                    |this: &mut ToolchainSelector, _: &menu::Cancel, window, cx| {
+                        this.state = State::Search((this.create_search_state)(window, cx));
+                        this.state.focus_handle(cx).focus(window, cx);
+                        cx.notify();
+                    },
+                ))
+            })
             .on_action(cx.listener(Self::confirm_toolchain))
             .map(|this| match &self.state {
                 AddState::Path { picker, .. } => this.child(picker.clone()),
@@ -726,19 +727,6 @@ impl ToolchainSelector {
             cx.notify();
         }
     }
-
-    fn cancel(&mut self, _: &menu::Cancel, window: &mut Window, cx: &mut Context<Self>) {
-        match &self.state {
-            State::Search(_) => {
-                cx.emit(DismissEvent);
-            }
-            State::AddToolchain(_) => {
-                self.state = State::Search((self.create_search_state)(window, cx));
-                self.state.focus_handle(cx).focus(window, cx);
-                cx.notify();
-            }
-        }
-    }
 }
 
 impl Render for ToolchainSelector {
@@ -749,7 +737,6 @@ impl Render for ToolchainSelector {
         v_flex()
             .key_context(key_context)
             .w(rems(34.))
-            .on_action(cx.listener(Self::cancel))
             .on_action(cx.listener(Self::handle_add_toolchain))
             .child(self.state.clone().render(window, cx))
     }