Compile and instantiate wasm modules on a background thread (cherry-pick #11270) (#11287)

gcp-cherry-pick-bot[bot] and Max Brunsfeld created 2 years ago

Cherry-picked Compile and instantiate wasm modules on a background
thread (#11270)

Release Notes:

- Fixed a hang that could occur when loading some extensions, by loading
extensions on a background thread.

Co-authored-by: Max Brunsfeld <[e-mail]>

Change summary

crates/extension/src/wasm_host.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Detailed changes

crates/extension/src/wasm_host.rs

@@ -106,9 +106,9 @@ impl WasmHost {
         wasm_bytes: Vec<u8>,
         manifest: Arc<ExtensionManifest>,
         executor: BackgroundExecutor,
-    ) -> impl 'static + Future<Output = Result<WasmExtension>> {
+    ) -> Task<Result<WasmExtension>> {
         let this = self.clone();
-        async move {
+        executor.clone().spawn(async move {
             let zed_api_version = parse_wasm_extension_version(&manifest.id, &wasm_bytes)?;
 
             let component = Component::from_binary(&this.engine, &wasm_bytes)
@@ -147,7 +147,7 @@ impl WasmHost {
                 tx,
                 zed_api_version,
             })
-        }
+        })
     }
 
     async fn build_wasi_ctx(&self, manifest: &Arc<ExtensionManifest>) -> Result<wasi::WasiCtx> {