tasks: change placeholder text in a modal (#10166)

Piotr Osiewicz created 2 years ago

Related to: #10132

Release Notes:

- N/A

Change summary

Cargo.lock                   |  1 -
crates/tasks_ui/Cargo.toml   |  1 -
crates/tasks_ui/src/modal.rs | 11 ++++-------
3 files changed, 4 insertions(+), 9 deletions(-)

Detailed changes

Cargo.lock

@@ -9500,7 +9500,6 @@ dependencies = [
  "gpui",
  "itertools 0.11.0",
  "language",
- "menu",
  "picker",
  "project",
  "serde",

crates/tasks_ui/Cargo.toml

@@ -13,7 +13,6 @@ anyhow.workspace = true
 editor.workspace = true
 fuzzy.workspace = true
 gpui.workspace = true
-menu.workspace = true
 picker.workspace = true
 project.workspace = true
 task.workspace = true

crates/tasks_ui/src/modal.rs

@@ -55,6 +55,7 @@ pub(crate) struct TasksModalDelegate {
     workspace: WeakView<Workspace>,
     prompt: String,
     task_context: TaskContext,
+    placeholder_text: Arc<str>,
 }
 
 impl TasksModalDelegate {
@@ -71,6 +72,7 @@ impl TasksModalDelegate {
             selected_index: 0,
             prompt: String::default(),
             task_context,
+            placeholder_text: Arc::from("Run a task..."),
         }
     }
 
@@ -197,13 +199,8 @@ impl PickerDelegate for TasksModalDelegate {
         self.selected_index = ix;
     }
 
-    fn placeholder_text(&self, cx: &mut WindowContext) -> Arc<str> {
-        Arc::from(format!(
-            "{} use task name as prompt, {} spawns a bash-like task from the prompt, {} runs the selected task",
-            cx.keystroke_text_for(&picker::UseSelectedQuery),
-            cx.keystroke_text_for(&picker::ConfirmInput {secondary: false}),
-            cx.keystroke_text_for(&menu::Confirm),
-        ))
+    fn placeholder_text(&self, _: &mut WindowContext) -> Arc<str> {
+        self.placeholder_text.clone()
     }
 
     fn update_matches(