From 1f9d5ef6849e482fc35dda552adc4c417cca1f0a Mon Sep 17 00:00:00 2001 From: Agus Zubiaga Date: Tue, 25 Nov 2025 16:49:16 -0300 Subject: [PATCH] Always display terminal cursor when blinking is disabled (#43487) Fixes an issue where the terminal cursor wouldn't always be displayed in the default `blink: "terminal_controlled"` mode unless the terminal requested cursor blinking. Release Notes: - N/A --- crates/terminal_view/src/terminal_view.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/terminal_view/src/terminal_view.rs b/crates/terminal_view/src/terminal_view.rs index 7c8bda83be864353c35b0317efc8599456dca6e5..7b3e29ac9b0582d081a286539d973fe8f1a453c5 100644 --- a/crates/terminal_view/src/terminal_view.rs +++ b/crates/terminal_view/src/terminal_view.rs @@ -649,9 +649,10 @@ impl TerminalView { // When focused, check blinking settings and blink manager state match TerminalSettings::get_global(cx).blinking { TerminalBlink::Off => true, - TerminalBlink::On | TerminalBlink::TerminalControlled => { - self.blink_manager.read(cx).visible() + TerminalBlink::TerminalControlled => { + !self.blinking_terminal_enabled || self.blink_manager.read(cx).visible() } + TerminalBlink::On => self.blink_manager.read(cx).visible(), } }