Revert "Default agent panel to left dock when multi-workspace is enabled" (#49080)

Mikayla Maki created 2 months ago

Reverts zed-industries/zed#49034

This proved to be a bit disruptive, we should re-land once we have more
of the pieces together.

Release Notes:

- N/A

Change summary

crates/agent_ui/src/agent_ui.rs       | 17 ++---------------
crates/settings/src/settings_store.rs | 11 -----------
2 files changed, 2 insertions(+), 26 deletions(-)

Detailed changes

crates/agent_ui/src/agent_ui.rs

@@ -32,7 +32,7 @@ use client::Client;
 use command_palette_hooks::CommandPaletteFilter;
 use feature_flags::{AgentV2FeatureFlag, FeatureFlagAppExt as _};
 use fs::Fs;
-use gpui::{Action, App, Context, Entity, SharedString, UpdateGlobal, Window, actions};
+use gpui::{Action, App, Context, Entity, SharedString, Window, actions};
 use language::{
     LanguageRegistry,
     language_settings::{AllLanguageSettings, EditPredictionProvider},
@@ -44,7 +44,7 @@ use project::DisableAiSettings;
 use prompt_store::PromptBuilder;
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
-use settings::{DockPosition, LanguageModelSelection, Settings as _, SettingsStore};
+use settings::{LanguageModelSelection, Settings as _, SettingsStore};
 use std::any::TypeId;
 use workspace::Workspace;
 
@@ -336,19 +336,6 @@ pub fn init(
         update_command_palette_filter(cx);
     })
     .detach();
-
-    cx.observe_flag::<AgentV2FeatureFlag, _>(|is_enabled, cx| {
-        SettingsStore::update_global(cx, |store, cx| {
-            store.update_default_settings(cx, |defaults| {
-                defaults.agent.get_or_insert_default().dock = Some(if is_enabled {
-                    DockPosition::Left
-                } else {
-                    DockPosition::Right
-                });
-            });
-        });
-    })
-    .detach();
 }
 
 fn update_command_palette_filter(cx: &mut App) {

crates/settings/src/settings_store.rs

@@ -794,17 +794,6 @@ impl SettingsStore {
         edits
     }
 
-    /// Mutates the default settings in place and recomputes all setting values.
-    pub fn update_default_settings(
-        &mut self,
-        cx: &mut App,
-        update: impl FnOnce(&mut SettingsContent),
-    ) {
-        let default_settings = Rc::make_mut(&mut self.default_settings);
-        update(default_settings);
-        self.recompute_values(None, cx);
-    }
-
     /// Sets the default settings via a JSON string.
     ///
     /// The string should contain a JSON object with a default value for every setting.