migrate to in tree denoise crate

David Kleingeld created 2 months ago

Change summary

Cargo.lock                                           | 1 +
crates/audio/Cargo.toml                              | 2 +-
crates/audio/src/audio.rs                            | 2 +-
crates/audio/src/rodio_ext.rs                        | 3 ++-
crates/livekit_client/src/livekit_client/playback.rs | 1 -
5 files changed, 5 insertions(+), 4 deletions(-)

Detailed changes

Cargo.lock

@@ -1404,6 +1404,7 @@ dependencies = [
  "async-tar",
  "collections",
  "crossbeam",
+ "denoise",
  "gpui",
  "libwebrtc",
  "log",

crates/audio/Cargo.toml

@@ -17,7 +17,7 @@ anyhow.workspace = true
 async-tar.workspace = true
 collections.workspace = true
 crossbeam.workspace = true
-denoise = { path = "/home/davidsk/Documents/denoise" }
+denoise = { path = "../denoise" }
 gpui.workspace = true
 log.workspace = true
 parking_lot.workspace = true

crates/audio/src/audio.rs

@@ -9,7 +9,7 @@ mod non_windows_and_freebsd_deps {
     pub(super) use log::info;
     pub(super) use parking_lot::Mutex;
     pub(super) use rodio::cpal::Sample;
-    pub(super) use rodio::source::{LimitSettings, UniformSourceIterator};
+    pub(super) use rodio::source::LimitSettings;
     pub(super) use std::sync::Arc;
 }
 

crates/audio/src/rodio_ext.rs

@@ -8,7 +8,8 @@ use std::{
 };
 
 use crossbeam::queue::ArrayQueue;
-use rodio::{ChannelCount, Sample, SampleRate, Source};
+use denoise::{Denoiser, DenoiserError};
+use rodio::{ChannelCount, Sample, SampleRate, Source, source::UniformSourceIterator};
 
 #[derive(Debug, thiserror::Error)]
 #[error("Replay duration is too short must be >= 100ms")]

crates/livekit_client/src/livekit_client/playback.rs

@@ -214,7 +214,6 @@ impl AudioStack {
                     }
                 };
                 send_to_livekit(frame_tx, microphone);
-                Ok::<(), anyhow::Error>(())
             });
             Task::ready(Ok(()))
         } else {