From 22d5d4a175d27a58127db4bc4fb2d22f07d2a2b4 Mon Sep 17 00:00:00 2001 From: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> Date: Fri, 31 Oct 2025 16:24:55 +0100 Subject: [PATCH] save-if is unnecessary --- .github/workflows/run_tests.yml | 7 ------- tooling/xtask/src/tasks/workflows/steps.rs | 1 - 2 files changed, 8 deletions(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index e0a2f9d118fc18d19e01a294ef3e4704b3ff7342..782accc60f5a5896e0678319f5b0bbe49e87d828 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -65,7 +65,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest @@ -156,7 +155,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest @@ -233,7 +231,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest @@ -284,7 +281,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest @@ -348,7 +344,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest @@ -389,7 +384,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest @@ -435,7 +429,6 @@ jobs: - name: steps::cache_rust_dependencies_namespace uses: namespacelabs/nscloud-cache-action@v1 with: - save-if: ${{ github.ref == 'refs/heads/main' }} cache: rust path: |- /home/runner/.cargo/bin/cargo-nextest diff --git a/tooling/xtask/src/tasks/workflows/steps.rs b/tooling/xtask/src/tasks/workflows/steps.rs index 0c0aa7a661cdbb24ed2748fed62924a351628630..bad637030d433b8406defeae560f147fa3fc5eaa 100644 --- a/tooling/xtask/src/tasks/workflows/steps.rs +++ b/tooling/xtask/src/tasks/workflows/steps.rs @@ -119,7 +119,6 @@ pub(crate) fn cache_rust_dependencies_namespace() -> Step { ] .join("\n"); named::uses("namespacelabs", "nscloud-cache-action", "v1") - .add_with(("save-if", "${{ github.ref == 'refs/heads/main' }}")) .add_with(("cache", "rust")) .add_with(("path", allowlisted_binaries)) }