Notify when pinning a tab even if the tab isn't moved (#31880)

Joseph T. Lyons created 6 months ago

The optimization to not move a tab being pinned (when the destination
index is the same as its index) in
https://github.com/zed-industries/zed/pull/31871 caused a regression, as
we were no longer calling `cx.notify()` indirectly through `move_item`.
Thanks for catching this, @smitbarmase.

Release Notes:

- N/A

Change summary

crates/workspace/src/pane.rs | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Detailed changes

crates/workspace/src/pane.rs

@@ -2063,7 +2063,9 @@ impl Pane {
                 self.set_preview_item_id(None, cx);
             }
 
-            if ix != destination_index {
+            if ix == destination_index {
+                cx.notify();
+            } else {
                 self.workspace
                     .update(cx, |_, cx| {
                         cx.defer_in(window, move |_, window, cx| {