From 26662728ed9288392a3290e08ce34d25a995b9dd Mon Sep 17 00:00:00 2001 From: "gcp-cherry-pick-bot[bot]" <98988430+gcp-cherry-pick-bot[bot]@users.noreply.github.com> Date: Fri, 23 May 2025 11:29:05 +0300 Subject: [PATCH] Change default diagnostics_max_severity to 'hint' (cherry-pick #31229) (#31245) Cherry-picked Change default diagnostics_max_severity to 'hint' (#31229) Closes https://github.com/blopker/codebook/issues/79 Recently, the setting `diagnostics_max_severity` was changed from `null` to `warning`in this PR: https://github.com/zed-industries/zed/pull/30316 This change has caused the various spell checking extensions to not work as expected by default, most of which use the `hint` diagnostic. This goes against user expectations when installing one of these extensions. Without `hint` as the default, extension authors will either need to change the diagnostic levels, or instruct users to add `diagnostics_max_severity` to their settings as an additional step, neither of which is a great user experience. This PR sets the default `hint`, which is closer to the original behavior before the aforementioned PR. Release Notes: - Changed `diagnostics_max_severity` to `hint` instead of `warning` by default --------- Co-authored-by: Kirill Bulatov Co-authored-by: Bo Lopker Co-authored-by: Kirill Bulatov --- assets/settings/default.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/assets/settings/default.json b/assets/settings/default.json index 2f8c7f48c685ccbd48dfb764a2b2ec3c748ebcc0..ca236b0f7ff2952f889991ab1417c71a832ea426 100644 --- a/assets/settings/default.json +++ b/assets/settings/default.json @@ -230,11 +230,11 @@ // Possible values: // - "off" — no diagnostics are allowed // - "error" - // - "warning" (default) + // - "warning" // - "info" // - "hint" - // - null — allow all diagnostics - "diagnostics_max_severity": "warning", + // - null — allow all diagnostics (default) + "diagnostics_max_severity": null, // Whether to show wrap guides (vertical rulers) in the editor. // Setting this to true will show a guide at the 'preferred_line_length' value // if 'soft_wrap' is set to 'preferred_line_length', and will show any