From 271c5af251f07e988181f78bab50b86e691ff1aa Mon Sep 17 00:00:00 2001 From: "zed-zippy[bot]" <234243425+zed-zippy[bot]@users.noreply.github.com> Date: Mon, 20 Apr 2026 14:57:01 -0400 Subject: [PATCH] Remove flaky`test_dev_container_modal_not_dismissed_on_background_click` (#54062) (cherry-pick to preview) (#54350) Cherry-pick of #54062 to preview ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A Co-authored-by: Cole Miller --- crates/recent_projects/src/recent_projects.rs | 67 +------------------ 1 file changed, 1 insertion(+), 66 deletions(-) diff --git a/crates/recent_projects/src/recent_projects.rs b/crates/recent_projects/src/recent_projects.rs index cf511b835d8d16e975fd02011c70ab1626c069be..045815800286e5d3787241939d57159aabcc5b77 100644 --- a/crates/recent_projects/src/recent_projects.rs +++ b/crates/recent_projects/src/recent_projects.rs @@ -2145,7 +2145,7 @@ impl RecentProjectsDelegate { #[cfg(test)] mod tests { - use gpui::{TestAppContext, UpdateGlobal, VisualTestContext}; + use gpui::{TestAppContext, UpdateGlobal}; use serde_json::json; use settings::SettingsStore; @@ -2219,71 +2219,6 @@ mod tests { .unwrap(); } - #[gpui::test] - async fn test_dev_container_modal_not_dismissed_on_backdrop_click(cx: &mut TestAppContext) { - let app_state = init_test(cx); - - app_state - .fs - .as_fake() - .insert_tree( - path!("/project"), - json!({ - ".devcontainer": { - "devcontainer.json": "{}" - }, - "src": { - "main.rs": "fn main() {}" - } - }), - ) - .await; - - cx.update(|cx| { - open_paths( - &[PathBuf::from(path!("/project"))], - app_state, - workspace::OpenOptions::default(), - cx, - ) - }) - .await - .unwrap(); - - assert_eq!(cx.update(|cx| cx.windows().len()), 1); - let multi_workspace = cx.update(|cx| cx.windows()[0].downcast::().unwrap()); - - cx.run_until_parked(); - - cx.dispatch_action(*multi_workspace, OpenDevContainer); - - multi_workspace - .update(cx, |multi_workspace, _, cx| { - assert!( - multi_workspace - .active_modal::(cx) - .is_some(), - "Dev container modal should be open" - ); - }) - .unwrap(); - - // Click outside the modal (on the backdrop) to try to dismiss it - let mut vcx = VisualTestContext::from_window(*multi_workspace, cx); - vcx.simulate_click(gpui::point(px(1.0), px(1.0)), gpui::Modifiers::default()); - - multi_workspace - .update(cx, |multi_workspace, _, cx| { - assert!( - multi_workspace - .active_modal::(cx) - .is_some(), - "Dev container modal should remain open during creation" - ); - }) - .unwrap(); - } - #[gpui::test] async fn test_open_dev_container_action_with_multiple_configs(cx: &mut TestAppContext) { let app_state = init_test(cx);