From 273a6cb00d9bbc539ab9ddb284f8009886d33764 Mon Sep 17 00:00:00 2001 From: Finn Evers Date: Tue, 24 Feb 2026 19:37:20 +0100 Subject: [PATCH] extension_ci: Remove merge-base `fork-point` flag in version check (#50014) Also removes the debugging step again. Release Notes: - N/A --- .github/workflows/extension_bump.yml | 2 +- .github/workflows/extension_tests.yml | 8 +------- .../xtask/src/tasks/workflows/extension_bump.rs | 2 +- .../xtask/src/tasks/workflows/extension_tests.rs | 14 +------------- 4 files changed, 4 insertions(+), 22 deletions(-) diff --git a/.github/workflows/extension_bump.yml b/.github/workflows/extension_bump.yml index 4b0ba05201a9161eaaed3f983e9c23e392e61683..cbd4da3e4066984cbabb1ad603e9d74aa2f29b64 100644 --- a/.github/workflows/extension_bump.yml +++ b/.github/workflows/extension_bump.yml @@ -40,7 +40,7 @@ jobs: CURRENT_VERSION="$(sed -n 's/^version = \"\(.*\)\"/\1/p' < extension.toml | tr -d '[:space:]')" if [[ "${{ github.event_name }}" == "pull_request" ]]; then - PR_FORK_POINT="$(git merge-base --fork-point origin/main HEAD)" + PR_FORK_POINT="$(git merge-base origin/main HEAD)" git checkout "$PR_FORK_POINT" elif BRANCH_PARENT_SHA="$(git merge-base origin/main origin/zed-zippy-autobump)"; then git checkout "$BRANCH_PARENT_SHA" diff --git a/.github/workflows/extension_tests.yml b/.github/workflows/extension_tests.yml index 92d4bc9be86ccfbc1dd59a6c626422495e9efd13..ef0e28715ce038c6ca9e38d4126b20e2276ce3c2 100644 --- a/.github/workflows/extension_tests.yml +++ b/.github/workflows/extension_tests.yml @@ -115,7 +115,7 @@ jobs: CURRENT_VERSION="$(sed -n 's/^version = \"\(.*\)\"/\1/p' < extension.toml | tr -d '[:space:]')" if [[ "${{ github.event_name }}" == "pull_request" ]]; then - PR_FORK_POINT="$(git merge-base --fork-point origin/main HEAD)" + PR_FORK_POINT="$(git merge-base origin/main HEAD)" git checkout "$PR_FORK_POINT" elif BRANCH_PARENT_SHA="$(git merge-base origin/main origin/zed-zippy-autobump)"; then git checkout "$BRANCH_PARENT_SHA" @@ -137,12 +137,6 @@ jobs: echo "Version changes happen in separate PRs and will be performed by the zed-zippy bot" exit 42 fi - - name: extension_tests::breakpoint - if: failure() - uses: namespacelabs/breakpoint-action@ca62bf12510ebf1115a560cf337a35fad5eb052b - with: - duration: 15m - authorized-users: MrSubidubi timeout-minutes: 6 tests_pass: needs: diff --git a/tooling/xtask/src/tasks/workflows/extension_bump.rs b/tooling/xtask/src/tasks/workflows/extension_bump.rs index d435cb9bfca5bcca4041a549515b8b18a4c40633..88d0cf85300b793aa386d50638fafc7e444e8519 100644 --- a/tooling/xtask/src/tasks/workflows/extension_bump.rs +++ b/tooling/xtask/src/tasks/workflows/extension_bump.rs @@ -151,7 +151,7 @@ pub(crate) fn compare_versions() -> (Step, StepOutput, StepOutput) { CURRENT_VERSION="$({VERSION_CHECK})" if [[ "${{{{ github.event_name }}}}" == "pull_request" ]]; then - PR_FORK_POINT="$(git merge-base --fork-point origin/main HEAD)" + PR_FORK_POINT="$(git merge-base origin/main HEAD)" git checkout "$PR_FORK_POINT" elif BRANCH_PARENT_SHA="$(git merge-base origin/main origin/zed-zippy-autobump)"; then git checkout "$BRANCH_PARENT_SHA" diff --git a/tooling/xtask/src/tasks/workflows/extension_tests.rs b/tooling/xtask/src/tasks/workflows/extension_tests.rs index 73a911d49cb4537361c07c15337737bd939c7564..a650013bacfcfc1ac89a60ccfe8674a5621fb1c7 100644 --- a/tooling/xtask/src/tasks/workflows/extension_tests.rs +++ b/tooling/xtask/src/tasks/workflows/extension_tests.rs @@ -95,23 +95,11 @@ pub(crate) fn check_extension() -> NamedJob { .add_step(cache_rust_dependencies_namespace()) // Extensions can compile Rust, so provide the cache if needed. .add_step(check()) .add_step(check_version_job) - .add_step(verify_version_did_not_change(version_changed)) - .add_step(breakpoint()); + .add_step(verify_version_did_not_change(version_changed)); named::job(job) } -fn breakpoint() -> Step { - named::uses( - "namespacelabs", - "breakpoint-action", - "ca62bf12510ebf1115a560cf337a35fad5eb052b", - ) - .if_condition(Expression::new("failure()")) - .add_with(("duration", "15m")) - .add_with(("authorized-users", "MrSubidubi")) -} - pub fn cache_zed_extension_cli() -> (Step, StepOutput) { let step = named::uses( "actions",